linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: Kirkwood: make kirkwood_disable_mbus_error_propagation() static
@ 2016-06-09 11:52 Ben Dooks
  2016-06-09 13:32 ` Andrew Lunn
  2016-06-16 10:00 ` Gregory CLEMENT
  0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks @ 2016-06-09 11:52 UTC (permalink / raw)
  To: linux-arm-kernel

The kirkwood_disable_mbus_error_propagation is not exported or declared
elsewhere, so make it static to avoid the following warning:

arch/arm/mach-mvebu/kirkwood.c:153:6: warning: symbol 'kirkwood_disable_mbus_error_propagation' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@free-electrons.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: linux-arm-kernel at lists.infradead.org
---
 arch/arm/mach-mvebu/kirkwood.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
index f9d8e1e..a3f4029 100644
--- a/arch/arm/mach-mvebu/kirkwood.c
+++ b/arch/arm/mach-mvebu/kirkwood.c
@@ -150,7 +150,7 @@ eth_fixup_skip:
  * causes mbus errors (which can occur for example for PCI aborts) to
  * throw CPU aborts, which we're not set up to deal with.
  */
-void kirkwood_disable_mbus_error_propagation(void)
+static void kirkwood_disable_mbus_error_propagation(void)
 {
 	void __iomem *cpu_config;
 
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: Kirkwood: make kirkwood_disable_mbus_error_propagation() static
  2016-06-09 11:52 [PATCH] ARM: Kirkwood: make kirkwood_disable_mbus_error_propagation() static Ben Dooks
@ 2016-06-09 13:32 ` Andrew Lunn
  2016-06-16 10:00 ` Gregory CLEMENT
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2016-06-09 13:32 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jun 09, 2016 at 12:52:25PM +0100, Ben Dooks wrote:
> The kirkwood_disable_mbus_error_propagation is not exported or declared
> elsewhere, so make it static to avoid the following warning:
> 
> arch/arm/mach-mvebu/kirkwood.c:153:6: warning: symbol 'kirkwood_disable_mbus_error_propagation' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: Kirkwood: make kirkwood_disable_mbus_error_propagation() static
  2016-06-09 11:52 [PATCH] ARM: Kirkwood: make kirkwood_disable_mbus_error_propagation() static Ben Dooks
  2016-06-09 13:32 ` Andrew Lunn
@ 2016-06-16 10:00 ` Gregory CLEMENT
  1 sibling, 0 replies; 3+ messages in thread
From: Gregory CLEMENT @ 2016-06-16 10:00 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Ben,
 
 On jeu., juin 09 2016, Ben Dooks <ben.dooks@codethink.co.uk> wrote:

> The kirkwood_disable_mbus_error_propagation is not exported or declared
> elsewhere, so make it static to avoid the following warning:
>
> arch/arm/mach-mvebu/kirkwood.c:153:6: warning: symbol 'kirkwood_disable_mbus_error_propagation' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Applied on mvebu/cleanup

Thanks,

Gregory

> ---
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Gregory Clement <gregory.clement@free-electrons.com>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Cc: linux-arm-kernel at lists.infradead.org
> ---
>  arch/arm/mach-mvebu/kirkwood.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
> index f9d8e1e..a3f4029 100644
> --- a/arch/arm/mach-mvebu/kirkwood.c
> +++ b/arch/arm/mach-mvebu/kirkwood.c
> @@ -150,7 +150,7 @@ eth_fixup_skip:
>   * causes mbus errors (which can occur for example for PCI aborts) to
>   * throw CPU aborts, which we're not set up to deal with.
>   */
> -void kirkwood_disable_mbus_error_propagation(void)
> +static void kirkwood_disable_mbus_error_propagation(void)
>  {
>  	void __iomem *cpu_config;
>  
> -- 
> 2.8.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-06-16 10:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-09 11:52 [PATCH] ARM: Kirkwood: make kirkwood_disable_mbus_error_propagation() static Ben Dooks
2016-06-09 13:32 ` Andrew Lunn
2016-06-16 10:00 ` Gregory CLEMENT

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).