linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: mx25: fix missing common.h include
@ 2016-06-09 12:06 Ben Dooks
  2016-06-09 13:37 ` Fabio Estevam
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2016-06-09 12:06 UTC (permalink / raw)
  To: linux-arm-kernel

The prototype for imx25_pm_init() was not in any of the included
headers, so add common.h where it is declared to remove the
following warning:

arch/arm/mach-imx/pm-imx25.c:34:13: warning: symbol 'imx25_pm_init' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: linux-arm-kernel at lists.infradead.org
---
 arch/arm/mach-imx/pm-imx25.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-imx/pm-imx25.c b/arch/arm/mach-imx/pm-imx25.c
index 8bba9fc..35aa082 100644
--- a/arch/arm/mach-imx/pm-imx25.c
+++ b/arch/arm/mach-imx/pm-imx25.c
@@ -10,6 +10,8 @@
 #include <linux/suspend.h>
 #include <linux/io.h>
 
+#include "common.h"
+
 static int imx25_suspend_enter(suspend_state_t state)
 {
 	if (!IS_ENABLED(CONFIG_PM))
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: mx25: fix missing common.h include
  2016-06-09 12:06 [PATCH] ARM: mx25: fix missing common.h include Ben Dooks
@ 2016-06-09 13:37 ` Fabio Estevam
  0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2016-06-09 13:37 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jun 9, 2016 at 9:06 AM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The prototype for imx25_pm_init() was not in any of the included
> headers, so add common.h where it is declared to remove the
> following warning:
>
> arch/arm/mach-imx/pm-imx25.c:34:13: warning: symbol 'imx25_pm_init' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Thanks for the patch:

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-09 13:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-09 12:06 [PATCH] ARM: mx25: fix missing common.h include Ben Dooks
2016-06-09 13:37 ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).