linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: imx6: tag boards that have the HW workaround for ERR006687
Date: Mon, 13 Jun 2016 13:03:18 +0200	[thread overview]
Message-ID: <1465815798.2313.13.camel@pengutronix.de> (raw)
In-Reply-To: <20160607124650.1e69c658@jclayton-pc>

Am Dienstag, den 07.06.2016, 12:46 -0700 schrieb Joshua Clayton:
> On Thu, 02 Jun 2016 10:25:06 +0200
> Lucas Stach <l.stach@pengutronix.de> wrote:
> 
> > Am Mittwoch, den 01.06.2016, 17:17 +0100 schrieb Russell King - ARM
> > Linux:
> > > On Wed, Jun 01, 2016 at 05:29:43PM +0200, Lucas Stach wrote:  
> > > > @@ -97,6 +97,7 @@
> > > >  	phy-reset-gpios = <&gpio3 31 0>;
> > > >  	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
> > > >  			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
> > > > +	fsl,err006687-war-present;  
> > > 
> 
> Why can't we just have the quirk detect the interrupts-extended
> property, which is not present on boards without the workaround.
> Wouldn't that be better? No dts change needed.
> 
I pondered that idea too, but have gone with the solution presented in
this patch series as it's more explicit and - with far more weight to it
- does not require the driver to touch DT properties that are outside of
its domain of responsibility. The "interrupts-extended" properties are
not meant to be parsed by the driver, but rather the IRQ subsystem.

Regards,
Lucas

  reply	other threads:[~2016-06-13 11:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01 15:29 [PATCH 0/2] Software workaround for i.MX6Q/DL ERR006687 Lucas Stach
2016-06-01 15:29 ` [PATCH 1/2] ARM: imx6: disable deeper idle states when FEC is active w/o HW workaround Lucas Stach
2016-06-16 15:47   ` Arnd Bergmann
2016-06-21  2:40     ` Shawn Guo
2016-06-01 15:29 ` [PATCH 2/2] ARM: dts: imx6: tag boards that have the HW workaround for ERR006687 Lucas Stach
2016-06-01 16:17   ` Russell King - ARM Linux
2016-06-02  8:25     ` Lucas Stach
2016-06-07 19:46       ` Joshua Clayton
2016-06-13 11:03         ` Lucas Stach [this message]
2016-06-02 19:10 ` [PATCH 0/2] Software workaround for i.MX6Q/DL ERR006687 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465815798.2313.13.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).