* [PATCH 1/3] dt-bindings: Change compatible string to "allwinner, sun6i-a31-mmc" for A31, A23-A33 and H3.
2016-06-13 20:37 [PATCH 0/3] Allwinner MMC Fifo register Emmanuel Vadot
@ 2016-06-13 20:37 ` Emmanuel Vadot
2016-06-13 20:37 ` [PATCH 2/3] dt-bindings: Add "allwinner, sun6i-a31-mmc" in documentation Documentation Emmanuel Vadot
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Emmanuel Vadot @ 2016-06-13 20:37 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
arch/arm/boot/dts/sun6i-a31.dtsi | 8 ++++----
arch/arm/boot/dts/sun8i-a23-a33.dtsi | 6 +++---
arch/arm/boot/dts/sun8i-h3.dtsi | 6 +++---
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
index 1867af2..6163256 100644
--- a/arch/arm/boot/dts/sun6i-a31.dtsi
+++ b/arch/arm/boot/dts/sun6i-a31.dtsi
@@ -469,7 +469,7 @@
};
mmc0: mmc at 01c0f000 {
- compatible = "allwinner,sun5i-a13-mmc";
+ compatible = "allwinner,sun6i-a31-mmc";
reg = <0x01c0f000 0x1000>;
clocks = <&ahb1_gates 8>,
<&mmc0_clk 0>,
@@ -488,7 +488,7 @@
};
mmc1: mmc at 01c10000 {
- compatible = "allwinner,sun5i-a13-mmc";
+ compatible = "allwinner,sun6i-a31-mmc";
reg = <0x01c10000 0x1000>;
clocks = <&ahb1_gates 9>,
<&mmc1_clk 0>,
@@ -507,7 +507,7 @@
};
mmc2: mmc at 01c11000 {
- compatible = "allwinner,sun5i-a13-mmc";
+ compatible = "allwinner,sun6i-a31-mmc";
reg = <0x01c11000 0x1000>;
clocks = <&ahb1_gates 10>,
<&mmc2_clk 0>,
@@ -526,7 +526,7 @@
};
mmc3: mmc at 01c12000 {
- compatible = "allwinner,sun5i-a13-mmc";
+ compatible = "allwinner,sun6i-a31-mmc";
reg = <0x01c12000 0x1000>;
clocks = <&ahb1_gates 11>,
<&mmc3_clk 0>,
diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
index 7e05e09..9275d11 100644
--- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
+++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
@@ -266,7 +266,7 @@
};
mmc0: mmc at 01c0f000 {
- compatible = "allwinner,sun5i-a13-mmc";
+ compatible = "allwinner,sun6i-a31-mmc";
reg = <0x01c0f000 0x1000>;
clocks = <&ahb1_gates 8>,
<&mmc0_clk 0>,
@@ -285,7 +285,7 @@
};
mmc1: mmc at 01c10000 {
- compatible = "allwinner,sun5i-a13-mmc";
+ compatible = "allwinner,sun6i-a31-mmc";
reg = <0x01c10000 0x1000>;
clocks = <&ahb1_gates 9>,
<&mmc1_clk 0>,
@@ -304,7 +304,7 @@
};
mmc2: mmc at 01c11000 {
- compatible = "allwinner,sun5i-a13-mmc";
+ compatible = "allwinner,sun6i-a31-mmc";
reg = <0x01c11000 0x1000>;
clocks = <&ahb1_gates 10>,
<&mmc2_clk 0>,
diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
index 4a4926b..b1edf73 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi
@@ -333,7 +333,7 @@
};
mmc0: mmc at 01c0f000 {
- compatible = "allwinner,sun5i-a13-mmc";
+ compatible = "allwinner,sun6i-a31-mmc";
reg = <0x01c0f000 0x1000>;
clocks = <&bus_gates 8>,
<&mmc0_clk 0>,
@@ -352,7 +352,7 @@
};
mmc1: mmc at 01c10000 {
- compatible = "allwinner,sun5i-a13-mmc";
+ compatible = "allwinner,sun6i-a31-mmc";
reg = <0x01c10000 0x1000>;
clocks = <&bus_gates 9>,
<&mmc1_clk 0>,
@@ -371,7 +371,7 @@
};
mmc2: mmc at 01c11000 {
- compatible = "allwinner,sun5i-a13-mmc";
+ compatible = "allwinner,sun6i-a31-mmc";
reg = <0x01c11000 0x1000>;
clocks = <&bus_gates 10>,
<&mmc2_clk 0>,
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/3] dt-bindings: Add "allwinner, sun6i-a31-mmc" in documentation Documentation.
2016-06-13 20:37 [PATCH 0/3] Allwinner MMC Fifo register Emmanuel Vadot
2016-06-13 20:37 ` [PATCH 1/3] dt-bindings: Change compatible string to "allwinner, sun6i-a31-mmc" for A31, A23-A33 and H3 Emmanuel Vadot
@ 2016-06-13 20:37 ` Emmanuel Vadot
2016-06-13 20:37 ` [PATCH 3/3] sunxi: Add "allwinner, sun6i-a31-mmc" support in the driver Emmanuel Vadot
2016-06-14 0:24 ` [PATCH 0/3] Allwinner MMC Fifo register Chen-Yu Tsai
3 siblings, 0 replies; 5+ messages in thread
From: Emmanuel Vadot @ 2016-06-13 20:37 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
Documentation/devicetree/bindings/mmc/sunxi-mmc.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
index 4bf41d8..e60b24e 100644
--- a/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/sunxi-mmc.txt
@@ -8,7 +8,8 @@ as the speed of SD standard 3.0.
Absolute maximum transfer rate is 200MB/s
Required properties:
- - compatible : "allwinner,sun4i-a10-mmc" or "allwinner,sun5i-a13-mmc"
+ - compatible : "allwinner,sun4i-a10-mmc", "allwinner,sun5i-a13-mmc" or
+ "allwinner,sun6i-a31-mmc"
- reg : mmc controller base registers
- clocks : a list with 4 phandle + clock specifier pairs
- clock-names : must contain "ahb", "mmc", "output" and "sample"
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] sunxi: Add "allwinner, sun6i-a31-mmc" support in the driver.
2016-06-13 20:37 [PATCH 0/3] Allwinner MMC Fifo register Emmanuel Vadot
2016-06-13 20:37 ` [PATCH 1/3] dt-bindings: Change compatible string to "allwinner, sun6i-a31-mmc" for A31, A23-A33 and H3 Emmanuel Vadot
2016-06-13 20:37 ` [PATCH 2/3] dt-bindings: Add "allwinner, sun6i-a31-mmc" in documentation Documentation Emmanuel Vadot
@ 2016-06-13 20:37 ` Emmanuel Vadot
2016-06-14 0:24 ` [PATCH 0/3] Allwinner MMC Fifo register Chen-Yu Tsai
3 siblings, 0 replies; 5+ messages in thread
From: Emmanuel Vadot @ 2016-06-13 20:37 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
drivers/mmc/host/sunxi-mmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index 2ee4c21..333db71 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c
@@ -941,6 +941,7 @@ static int sunxi_mmc_card_busy(struct mmc_host *mmc)
static const struct of_device_id sunxi_mmc_of_match[] = {
{ .compatible = "allwinner,sun4i-a10-mmc", },
{ .compatible = "allwinner,sun5i-a13-mmc", },
+ { .compatible = "allwinner,sun6i-a31-mmc", },
{ .compatible = "allwinner,sun9i-a80-mmc", },
{ /* sentinel */ }
};
--
2.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 0/3] Allwinner MMC Fifo register
2016-06-13 20:37 [PATCH 0/3] Allwinner MMC Fifo register Emmanuel Vadot
` (2 preceding siblings ...)
2016-06-13 20:37 ` [PATCH 3/3] sunxi: Add "allwinner, sun6i-a31-mmc" support in the driver Emmanuel Vadot
@ 2016-06-14 0:24 ` Chen-Yu Tsai
3 siblings, 0 replies; 5+ messages in thread
From: Chen-Yu Tsai @ 2016-06-14 0:24 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tue, Jun 14, 2016 at 4:37 AM, Emmanuel Vadot <manu@freebsd.org> wrote:
> Hi everyone,
>
> The mmc fifo register in A31 and later is at address 0x200 (0x100 for A10 and A20).
> Therefore the compatible string shouldn't be the same.
You should explain this in the commit logs of the patches.
I understand you're coming from FreeBSD, but there's a different process
for the Linux kernel. The commit subject should follow the format you can
find in the git history, such as "ARM: dts: sunXi: ..." or "mmc: sunxi: ...".
You should send the patches to the respective maintainers and CC the relevant
maintainers. Use "scripts/get_maintainer.pl" for this.
Regards
ChenYu
> Emmanuel Vadot (3):
> Change compatible string to "allwinner,sun6i-a31-mmc" for A31, A23-A33
> and H3.
> Add "allwinner,sun6i-a31-mmc" compatible string in the Documentation.
> Add "allwinner,sun6i-a31-mmc" support in the driver.
>
> Documentation/devicetree/bindings/mmc/sunxi-mmc.txt | 3 ++-
> arch/arm/boot/dts/sun6i-a31.dtsi | 8 ++++----
> arch/arm/boot/dts/sun8i-a23-a33.dtsi | 6 +++---
> arch/arm/boot/dts/sun8i-h3.dtsi | 6 +++---
> drivers/mmc/host/sunxi-mmc.c | 1 +
> 5 files changed, 13 insertions(+), 11 deletions(-)
>
> --
> 2.8.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread