From: tthayer@opensource.altera.com (tthayer at opensource.altera.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 2/7] EDAC, altera: Add panic flag check to A10 IRQ
Date: Mon, 13 Jun 2016 16:19:07 -0500 [thread overview]
Message-ID: <1465852752-11018-3-git-send-email-tthayer@opensource.altera.com> (raw)
In-Reply-To: <1465852752-11018-1-git-send-email-tthayer@opensource.altera.com>
From: Thor Thayer <tthayer@opensource.altera.com>
In preparation for additional memory module ECCs, the
IRQ function will check a panic flag before doing a
kernel panic on double bit errors. ECCs on buffers
will not cause a kernel panic on DBERRs.
Signed-off-by: Thor Thayer <tthayer@opensource.altera.com>
---
v2 New patch. Add panic flag to IRQ function.
v3 No change
---
drivers/edac/altera_edac.c | 4 +++-
drivers/edac/altera_edac.h | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index 926bcaf..a9d8fa7 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -897,7 +897,8 @@ static irqreturn_t altr_edac_a10_ecc_irq(int irq, void *dev_id)
writel(ALTR_A10_ECC_DERRPENA,
base + ALTR_A10_ECC_INTSTAT_OFST);
edac_device_handle_ue(dci->edac_dev, 0, 0, dci->edac_dev_name);
- panic("\nEDAC:ECC_DEVICE[Uncorrectable errors]\n");
+ if (dci->data->panic)
+ panic("\nEDAC:ECC_DEVICE[Uncorrectable errors]\n");
return IRQ_HANDLED;
}
@@ -936,6 +937,7 @@ const struct edac_device_prv_data a10_ocramecc_data = {
.set_err_ofst = ALTR_A10_ECC_INTTEST_OFST,
.ecc_irq_handler = altr_edac_a10_ecc_irq,
.inject_fops = &altr_edac_a10_device_inject_fops,
+ .panic = true,
};
#endif /* CONFIG_EDAC_ALTERA_OCRAM */
diff --git a/drivers/edac/altera_edac.h b/drivers/edac/altera_edac.h
index 62b0fa0..cf4e8cb 100644
--- a/drivers/edac/altera_edac.h
+++ b/drivers/edac/altera_edac.h
@@ -298,6 +298,7 @@ struct edac_device_prv_data {
irqreturn_t (*ecc_irq_handler)(int irq, void *dev_id);
int trig_alloc_sz;
const struct file_operations *inject_fops;
+ bool panic;
};
struct altr_edac_device_dev {
--
1.7.9.5
next prev parent reply other threads:[~2016-06-13 21:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 21:19 [PATCHv3 0/7] Add Ethernet EDAC & peripheral init functions tthayer at opensource.altera.com
2016-06-13 21:19 ` [PATCHv3 1/7] EDAC, altera: Check parent status for Arria10 EDAC block tthayer at opensource.altera.com
2016-06-17 16:46 ` Borislav Petkov
2016-06-17 16:54 ` Thor Thayer
2016-06-17 16:54 ` Borislav Petkov
2016-06-13 21:19 ` tthayer at opensource.altera.com [this message]
2016-06-17 16:51 ` [PATCHv3 2/7] EDAC, altera: Add panic flag check to A10 IRQ Borislav Petkov
2016-06-17 17:05 ` Thor Thayer
2016-06-17 17:02 ` Borislav Petkov
2016-06-17 17:11 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 3/7] EDAC, altera: Share Arria10 check_deps & IRQ functions tthayer at opensource.altera.com
2016-06-17 17:00 ` Borislav Petkov
2016-06-17 17:09 ` Thor Thayer
2016-06-17 17:11 ` Borislav Petkov
2016-06-17 17:37 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 4/7] Documentation: dt: socfpga: Add Arria10 Ethernet binding tthayer at opensource.altera.com
2016-06-16 18:39 ` Rob Herring
2016-06-16 19:12 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 5/7] EDAC, altera: Add Arria10 ECC memory init functions tthayer at opensource.altera.com
2016-06-17 17:21 ` Borislav Petkov
2016-06-17 17:42 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 6/7] EDAC, altera: Add Arria10 Ethernet EDAC support tthayer at opensource.altera.com
2016-06-17 17:29 ` Borislav Petkov
2016-06-17 17:43 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 7/7] ARM: dts: Add Arria10 Ethernet EDAC devicetree entry tthayer at opensource.altera.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465852752-11018-3-git-send-email-tthayer@opensource.altera.com \
--to=tthayer@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).