From: tfiga@chromium.org (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/8] iommu/rockchip: Prepare to support generic DMA mapping
Date: Tue, 21 Jun 2016 13:34:38 +0900 [thread overview]
Message-ID: <1466483681-36110-6-git-send-email-tfiga@chromium.org> (raw)
In-Reply-To: <1466483681-36110-1-git-send-email-tfiga@chromium.org>
From: Shunqian Zheng <zhengsq@rock-chips.com>
Set geometry for allocated domains and fix .domain_alloc() callback to
work with IOMMU_DOMAIN_DMA domain type, which is used for implicit
domains on ARM64.
Signed-off-by: Shunqian Zheng <zhengsq@rock-chips.com>
Signed-off-by: Tomasz Figa <tfiga@chromium.org>
---
drivers/iommu/rockchip-iommu.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
index 0551146..d5fd074 100644
--- a/drivers/iommu/rockchip-iommu.c
+++ b/drivers/iommu/rockchip-iommu.c
@@ -888,7 +888,7 @@ static struct iommu_domain *rk_iommu_domain_alloc(unsigned type)
struct platform_device *pdev;
struct device *iommu_dev;
- if (type != IOMMU_DOMAIN_UNMANAGED)
+ if (type != IOMMU_DOMAIN_UNMANAGED && type != IOMMU_DOMAIN_DMA)
return NULL;
/* Register a pdev per domain, so DMA API can base on this *dev
@@ -905,8 +905,8 @@ static struct iommu_domain *rk_iommu_domain_alloc(unsigned type)
rk_domain->pdev = pdev;
- /* To init the iovad which is required by iommu_dma_init_domain() */
- if (iommu_get_dma_cookie(&rk_domain->domain))
+ if (type == IOMMU_DOMAIN_DMA &&
+ iommu_get_dma_cookie(&rk_domain->domain))
goto err_unreg_pdev;
/*
@@ -932,12 +932,17 @@ static struct iommu_domain *rk_iommu_domain_alloc(unsigned type)
spin_lock_init(&rk_domain->dt_lock);
INIT_LIST_HEAD(&rk_domain->iommus);
+ rk_domain->domain.geometry.aperture_start = 0;
+ rk_domain->domain.geometry.aperture_end = DMA_BIT_MASK(32);
+ rk_domain->domain.geometry.force_aperture = true;
+
return &rk_domain->domain;
err_free_dt:
free_page((unsigned long)rk_domain->dt);
err_put_cookie:
- iommu_put_dma_cookie(&rk_domain->domain);
+ if (type == IOMMU_DOMAIN_DMA)
+ iommu_put_dma_cookie(&rk_domain->domain);
err_unreg_pdev:
platform_device_unregister(pdev);
@@ -966,7 +971,8 @@ static void rk_iommu_domain_free(struct iommu_domain *domain)
SPAGE_SIZE, DMA_TO_DEVICE);
free_page((unsigned long)rk_domain->dt);
- iommu_put_dma_cookie(&rk_domain->domain);
+ if (domain->type == IOMMU_DOMAIN_DMA)
+ iommu_put_dma_cookie(&rk_domain->domain);
platform_device_unregister(rk_domain->pdev);
}
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-06-21 4:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 4:34 [PATCH v4 0/8] iommu/rockchip: Fix bugs and enable on ARM64 Tomasz Figa
2016-06-21 4:34 ` [PATCH v4 1/8] iommu/rockchip: Fix devm_{request,free}_irq parameter Tomasz Figa
2016-06-21 4:34 ` [PATCH v4 2/8] iommu/rockchip: Add map_sg callback for rk_iommu_ops Tomasz Figa
2016-06-21 4:34 ` [PATCH v4 3/8] iommu/rockchip: Fix allocation of bases array in driver probe Tomasz Figa
2016-06-21 17:19 ` Doug Anderson
2016-06-21 4:34 ` [PATCH v4 4/8] iommu/rockchip: Use DMA API to manage coherency Tomasz Figa
2016-06-21 4:34 ` Tomasz Figa [this message]
2016-06-21 4:34 ` [PATCH v4 6/8] drm/rockchip: Do not use DMA mapping API if attached to IOMMU domain Tomasz Figa
2016-06-21 4:34 ` [PATCH v4 7/8] drm/rockchip: Use common IOMMU API to attach devices Tomasz Figa
2016-06-21 4:34 ` [PATCH v4 8/8] iommu/rockchip: Enable Rockchip IOMMU on ARM64 Tomasz Figa
2016-06-21 9:17 ` [PATCH v4 0/8] iommu/rockchip: Fix bugs and enable " Joerg Roedel
2016-06-21 12:42 ` Tomasz Figa
2016-06-21 12:54 ` Joerg Roedel
2016-06-21 13:18 ` Heiko Stübner
2016-06-21 13:52 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466483681-36110-6-git-send-email-tfiga@chromium.org \
--to=tfiga@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).