* [PATCH] ARM: keystone: fix missing keystone.h in pm_domain.c
@ 2016-06-21 12:05 Ben Dooks
2016-06-21 16:08 ` Santosh Shilimkar
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2016-06-21 12:05 UTC (permalink / raw)
To: linux-arm-kernel
The declaration of keystone_pm_runtime_init() is not included
from keystone.h in pm_domain.c. Including the file fixes the
following sparse warning:
arch/arm/mach-keystone/pm_domain.c:37:12: warning: symbol 'keystone_pm_runtime_init' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Santosh Shilimkar <ssantosh@kernel.org>
Cc: linux-arm-kernel at lists.infradead.org
---
arch/arm/mach-keystone/pm_domain.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-keystone/pm_domain.c b/arch/arm/mach-keystone/pm_domain.c
index e283939..8cbb357 100644
--- a/arch/arm/mach-keystone/pm_domain.c
+++ b/arch/arm/mach-keystone/pm_domain.c
@@ -18,6 +18,8 @@
#include <linux/platform_device.h>
#include <linux/of.h>
+#include "keystone.h"
+
static struct dev_pm_domain keystone_pm_domain = {
.ops = {
USE_PM_CLK_RUNTIME_OPS
--
2.8.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: keystone: fix missing keystone.h in pm_domain.c
2016-06-21 12:05 [PATCH] ARM: keystone: fix missing keystone.h in pm_domain.c Ben Dooks
@ 2016-06-21 16:08 ` Santosh Shilimkar
0 siblings, 0 replies; 2+ messages in thread
From: Santosh Shilimkar @ 2016-06-21 16:08 UTC (permalink / raw)
To: linux-arm-kernel
On 6/21/2016 5:05 AM, Ben Dooks wrote:
> The declaration of keystone_pm_runtime_init() is not included
> from keystone.h in pm_domain.c. Including the file fixes the
> following sparse warning:
>
> arch/arm/mach-keystone/pm_domain.c:37:12: warning: symbol 'keystone_pm_runtime_init' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
Looks good. Will pick it up.
Regards,
Santosh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-21 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-21 12:05 [PATCH] ARM: keystone: fix missing keystone.h in pm_domain.c Ben Dooks
2016-06-21 16:08 ` Santosh Shilimkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).