[PATCH] usb: renesas_usbhs: make usbhs_write32() static

[PATCH] usb: renesas_usbhs: make usbhs_write32() static

[Ben Dooks]

The usbhs_write32 function is not used outside of the rcar3.c
file, so fix the following sparse warning by making it static:

drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb at vger.kernel.org
Cc: linux-renesas-soc at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
---
 drivers/usb/renesas_usbhs/rcar3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c
index 38b01f2..1d70add 100644
--- a/drivers/usb/renesas_usbhs/rcar3.c
+++ b/drivers/usb/renesas_usbhs/rcar3.c
@@ -23,7 +23,7 @@
 #define UGCTRL2_RESERVED_3	0x00000001	/* bit[3:0] should be B'0001 */
 #define UGCTRL2_USB0SEL_OTG	0x00000030
 
-void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data)
+static void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data)
 {
 	iowrite32(data, priv->base + reg);
 }
-- 
2.8.1

[PATCH] usb: renesas_usbhs: make usbhs_write32() static

[Mathieu Malaterre]

On Tue, Jun 21, 2016 at 7:52 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The usbhs_write32 function is not used outside of the rcar3.c
> file, so fix the following sparse warning by making it static:
>
> drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb at vger.kernel.org
> Cc: linux-renesas-soc at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> ---
>  drivers/usb/renesas_usbhs/rcar3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c
> index 38b01f2..1d70add 100644
> --- a/drivers/usb/renesas_usbhs/rcar3.c
> +++ b/drivers/usb/renesas_usbhs/rcar3.c
> @@ -23,7 +23,7 @@
>  #define UGCTRL2_RESERVED_3     0x00000001      /* bit[3:0] should be B'0001 */
>  #define UGCTRL2_USB0SEL_OTG    0x00000030
>
> -void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data)
> +static void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data)
>  {
>         iowrite32(data, priv->base + reg);
>  }
> --
> 2.8.1

static inline ?

[PATCH] usb: renesas_usbhs: make usbhs_write32() static

[Felipe Balbi]

Hi,

Mathieu Malaterre <mathieu.malaterre@gmail.com> writes:
> On Tue, Jun 21, 2016 at 7:52 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>> The usbhs_write32 function is not used outside of the rcar3.c
>> file, so fix the following sparse warning by making it static:
>>
>> drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was not declared. Should it be static?
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: linux-usb at vger.kernel.org
>> Cc: linux-renesas-soc at vger.kernel.org
>> Cc: linux-arm-kernel at lists.infradead.org
>> ---
>>  drivers/usb/renesas_usbhs/rcar3.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c
>> index 38b01f2..1d70add 100644
>> --- a/drivers/usb/renesas_usbhs/rcar3.c
>> +++ b/drivers/usb/renesas_usbhs/rcar3.c
>> @@ -23,7 +23,7 @@
>>  #define UGCTRL2_RESERVED_3     0x00000001      /* bit[3:0] should be B'0001 */
>>  #define UGCTRL2_USB0SEL_OTG    0x00000030
>>
>> -void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data)
>> +static void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data)
>>  {
>>         iowrite32(data, priv->base + reg);
>>  }
>> --
>> 2.8.1
>
> static inline ?

why? compiler can make that choice

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160622/f3a7f447/attachment.sig>

[PATCH] usb: renesas_usbhs: make usbhs_write32() static

[Yoshihiro Shimoda]

Hi,

> From: Ben Dooks
> Sent: Wednesday, June 22, 2016 2:53 AM
> 
> The usbhs_write32 function is not used outside of the rcar3.c
> file, so fix the following sparse warning by making it static:
> 
> drivers/usb/renesas_usbhs/rcar3.c:26:6: warning: symbol 'usbhs_write32' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Thank you for the patch.

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

> ---
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-usb at vger.kernel.org
> Cc: linux-renesas-soc at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> ---
>  drivers/usb/renesas_usbhs/rcar3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/renesas_usbhs/rcar3.c b/drivers/usb/renesas_usbhs/rcar3.c
> index 38b01f2..1d70add 100644
> --- a/drivers/usb/renesas_usbhs/rcar3.c
> +++ b/drivers/usb/renesas_usbhs/rcar3.c
> @@ -23,7 +23,7 @@
>  #define UGCTRL2_RESERVED_3	0x00000001	/* bit[3:0] should be B'0001 */
>  #define UGCTRL2_USB0SEL_OTG	0x00000030
> 
> -void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data)
> +static void usbhs_write32(struct usbhs_priv *priv, u32 reg, u32 data)
>  {
>  	iowrite32(data, priv->base + reg);
>  }
> --
> 2.8.1