From: andi.shyti@samsung.com (Andi Shyti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] spi: s3c64xx: use unsigned type for fifo handling variables
Date: Tue, 28 Jun 2016 11:41:15 +0900 [thread overview]
Message-ID: <1467081676-8442-6-git-send-email-andi.shyti@samsung.com> (raw)
In-Reply-To: <1467081676-8442-1-git-send-email-andi.shyti@samsung.com>
The 'quirks' variable cannot ever be negative, therefore use u8
instead of int. The 8 bit size is given from the fact that
currently the quirks variable has very few statuses.
The rx_lvl_offset and tx_st_done store shift values, so that u8
is a proper size.
fifo_lvl_mask stores a series of masks, to be in we will keep the
32 bit size.
Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/spi/spi-s3c64xx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 6d8486f..6c9503a 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -150,10 +150,10 @@ struct s3c64xx_spi_dma_data {
* which is provided as driver data to the driver.
*/
struct s3c64xx_spi_port_config {
- int fifo_lvl_mask[MAX_SPI_PORTS];
- int rx_lvl_offset;
- int tx_st_done;
- int quirks;
+ u32 fifo_lvl_mask[MAX_SPI_PORTS];
+ u8 rx_lvl_offset;
+ u8 tx_st_done;
+ u8 quirks;
bool high_speed;
bool clk_from_cmu;
};
--
2.8.1
next prev parent reply other threads:[~2016-06-28 2:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 2:41 [PATCH v2 0/5] s3c64xx: consider the case of a disconnected CS line and some code rework Andi Shyti
2016-06-28 2:41 ` [PATCH v2 1/5] spi: s3c64xx: group the CS signalling writes in a single function Andi Shyti
2016-06-28 2:41 ` [PATCH v2 2/5] spi: s3c64xx: consider the case when the CS line is not connected Andi Shyti
2016-06-30 12:15 ` Applied "spi: s3c64xx: consider the case when the CS line is not connected" to the spi tree Mark Brown
2016-06-28 2:41 ` [PATCH v2 3/5] spi: s3c64xx: do not configure the device twice Andi Shyti
2016-06-28 2:41 ` [PATCH v2 4/5] spi: s3c64xx: simplify if statement in prepare_transfer function Andi Shyti
2016-06-28 2:41 ` Andi Shyti [this message]
2016-07-05 14:55 ` [PATCH v2 5/5] spi: s3c64xx: use unsigned type for fifo handling variables Mark Brown
2016-07-05 15:01 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467081676-8442-6-git-send-email-andi.shyti@samsung.com \
--to=andi.shyti@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox