linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/92] clocksource/drivers/rockchip: Add support for the rk3399 SoC
Date: Tue, 28 Jun 2016 12:30:26 +0200	[thread overview]
Message-ID: <1467109911-11060-7-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1467109911-11060-1-git-send-email-daniel.lezcano@linaro.org>

From: "Huang, Tao" <huangtao@rock-chips.com>

The only difference between the rk3399 SoC and the other ones is the control
register offset which is different.

Add a new field to store the control register address depending on the SoC
and use it instead of the <base> + <control offset>.

Signed-off-by: Huang Tao <huangtao@rock-chips.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Heiko Stuebner <heiko@sntech.de>
Tested-by: Jianqun Xu <jay.xu@rock-chips.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/rockchip_timer.c | 31 ++++++++++++++++++++++++++-----
 1 file changed, 26 insertions(+), 5 deletions(-)

diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
index b510863..a3f22b0 100644
--- a/drivers/clocksource/rockchip_timer.c
+++ b/drivers/clocksource/rockchip_timer.c
@@ -19,7 +19,8 @@
 
 #define TIMER_LOAD_COUNT0	0x00
 #define TIMER_LOAD_COUNT1	0x04
-#define TIMER_CONTROL_REG	0x10
+#define TIMER_CONTROL_REG3288	0x10
+#define TIMER_CONTROL_REG3399	0x1c
 #define TIMER_INT_STATUS	0x18
 
 #define TIMER_DISABLE		0x0
@@ -31,6 +32,7 @@
 struct bc_timer {
 	struct clock_event_device ce;
 	void __iomem *base;
+	void __iomem *ctrl;
 	u32 freq;
 };
 
@@ -46,15 +48,20 @@ static inline void __iomem *rk_base(struct clock_event_device *ce)
 	return rk_timer(ce)->base;
 }
 
+static inline void __iomem *rk_ctrl(struct clock_event_device *ce)
+{
+	return rk_timer(ce)->ctrl;
+}
+
 static inline void rk_timer_disable(struct clock_event_device *ce)
 {
-	writel_relaxed(TIMER_DISABLE, rk_base(ce) + TIMER_CONTROL_REG);
+	writel_relaxed(TIMER_DISABLE, rk_ctrl(ce));
 }
 
 static inline void rk_timer_enable(struct clock_event_device *ce, u32 flags)
 {
 	writel_relaxed(TIMER_ENABLE | TIMER_INT_UNMASK | flags,
-		       rk_base(ce) + TIMER_CONTROL_REG);
+		       rk_ctrl(ce));
 }
 
 static void rk_timer_update_counter(unsigned long cycles,
@@ -106,7 +113,7 @@ static irqreturn_t rk_timer_interrupt(int irq, void *dev_id)
 	return IRQ_HANDLED;
 }
 
-static void __init rk_timer_init(struct device_node *np)
+static void __init rk_timer_init(struct device_node *np, u32 ctrl_reg)
 {
 	struct clock_event_device *ce = &bc_timer.ce;
 	struct clk *timer_clk;
@@ -118,6 +125,7 @@ static void __init rk_timer_init(struct device_node *np)
 		pr_err("Failed to get base address for '%s'\n", TIMER_NAME);
 		return;
 	}
+	bc_timer.ctrl = bc_timer.base + ctrl_reg;
 
 	pclk = of_clk_get_by_name(np, "pclk");
 	if (IS_ERR(pclk)) {
@@ -180,4 +188,17 @@ out_unmap:
 	iounmap(bc_timer.base);
 }
 
-CLOCKSOURCE_OF_DECLARE(rk_timer, "rockchip,rk3288-timer", rk_timer_init);
+static void __init rk3288_timer_init(struct device_node *np)
+{
+	rk_timer_init(np, TIMER_CONTROL_REG3288);
+}
+
+static void __init rk3399_timer_init(struct device_node *np)
+{
+	rk_timer_init(np, TIMER_CONTROL_REG3399);
+}
+
+CLOCKSOURCE_OF_DECLARE(rk3288_timer, "rockchip,rk3288-timer",
+		       rk3288_timer_init);
+CLOCKSOURCE_OF_DECLARE(rk3399_timer, "rockchip,rk3399-timer",
+		       rk3399_timer_init);
-- 
1.9.1

  parent reply	other threads:[~2016-06-28 10:30 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <577251A4.7030508@linaro.org>
     [not found] ` <1467109911-11060-1-git-send-email-daniel.lezcano@linaro.org>
2016-06-28 10:30   ` [PATCH 02/92] clocksource/drivers/digicolor: Fix warning of non-static function Daniel Lezcano
2016-06-28 10:30   ` [PATCH 05/92] dt-bindings: Document rk3399 rk-timer bindings Daniel Lezcano
2016-06-28 10:30   ` [PATCH 06/92] clocksource/drivers/rockchip: Add the dynamic irq flag to the timer Daniel Lezcano
2016-06-28 10:30   ` Daniel Lezcano [this message]
2016-06-28 10:30   ` [PATCH 08/92] arm64: dts: rockchip: Add rktimer device node for rk3399 Daniel Lezcano
2016-06-28 10:30   ` [PATCH 09/92] clocksource/drivers/oxnas-rps: Add Oxford Semiconductor RPS Dual Timer Daniel Lezcano
2016-06-28 10:30   ` [PATCH 13/92] clocksource/drivers/rockchip_timer: Convert init function to return error Daniel Lezcano
2016-06-28 10:30   ` [PATCH 14/92] clocksource/drivers/mtk_timer: " Daniel Lezcano
2016-06-28 10:30   ` [PATCH 15/92] clocksource/drivers/exynos_mct: " Daniel Lezcano
2016-06-28 10:30   ` [PATCH 17/92] clocksource/drivers/cadence_ttc: " Daniel Lezcano
2016-06-28 10:30   ` [PATCH 18/92] clocksource/drivers/st_lpc: " Daniel Lezcano
2016-06-28 10:30   ` [PATCH 20/92] clocksource/drivers/clps711x: " Daniel Lezcano
2016-06-28 10:30   ` [PATCH 21/92] clocksource/drivers/digicolor: " Daniel Lezcano
2016-06-28 10:30   ` [PATCH 22/92] clocksource/drivers/armv7m_systick: " Daniel Lezcano
2016-06-28 10:30   ` [PATCH 23/92] clocksource/drivers/bcm2835_timer: " Daniel Lezcano
2016-06-28 10:30   ` [PATCH 25/92] clocksource/drivers/clksrc-dbx500: " Daniel Lezcano
2016-06-28 10:30   ` [PATCH 28/92] clocksource/drivers/arm_global_timer: " Daniel Lezcano
2016-06-28 10:30   ` [PATCH 32/92] clocksource/drivers/meson6_timer.c: " Daniel Lezcano
2016-06-28 10:30   ` [PATCH 35/92] clocksource/drivers/mps2-timer: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 41/92] clocksource/drivers/sun4i: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 45/92] clocksource/drivers/time-efm32: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 46/92] clocksource/drivers/time-lpc32xx: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 49/92] clocksource/drivers/atlas7: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 52/92] clocksource/drivers/prima2: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 55/92] clocksource/drivers/keystone: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 57/92] clocksource/drivers/stm32: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 58/92] clocksource/drivers/sun5i: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 60/92] clocksource/drivers/u300: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 61/92] clocksource/drivers/versatile: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 63/92] clocksource/drivers/vt8500: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 68/92] clocksource/drivers/smp_twd: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 71/92] clocksource/drivers/oxnas-rps: " Daniel Lezcano
2016-06-28 10:31   ` [PATCH 72/92] clocksources: Switch back to the clksrc table Daniel Lezcano
2016-06-28 10:31   ` [PATCH 75/92] clocksource/drivers/bcm2835: Add the COMPILE_TEST option Daniel Lezcano
2016-06-28 10:51 ` [PATCH 76/92] clocksource/drivers/armv7m_systick: " Daniel Lezcano
2016-06-28 10:51   ` [PATCH 77/92] clocksource/drivers/bcm_kona: " Daniel Lezcano
2016-06-28 10:51   ` [PATCH 78/92] clocksource/drivers/clps_711x: " Daniel Lezcano
2016-06-28 10:51   ` [PATCH 79/92] clocksource/drivers/atlas7: " Daniel Lezcano
2016-06-28 10:51   ` [PATCH 80/92] clocksource/drivers/moxart: " Daniel Lezcano
2016-06-28 10:51   ` [PATCH 82/92] clocksource/drivers/mxs: " Daniel Lezcano
2016-06-28 10:51   ` [PATCH 83/92] clocksource/drivers/prima2: Remove useless header <asm/mach/time.h> Daniel Lezcano
2016-06-28 10:51   ` [PATCH 84/92] clocksource/drivers/prima2: Add the COMPILE_TEST option Daniel Lezcano
2016-06-28 10:51   ` [PATCH 85/92] clocksource/drivers/u300: " Daniel Lezcano
2016-06-28 10:51   ` [PATCH 86/92] clocksource/drivers/nspire: " Daniel Lezcano
2016-06-28 10:51   ` [PATCH 87/92] clocksource/drivers/keystone: " Daniel Lezcano
2016-06-28 10:51   ` [PATCH 88/92] clocksource/drivers/integrator-ap: " Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467109911-11060-7-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).