From: peter.chen@nxp.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] arm: mach-u300: regulator: add missing of_node_put after calling of_parse_phandle
Date: Fri, 1 Jul 2016 17:41:57 +0800 [thread overview]
Message-ID: <1467366121-14120-4-git-send-email-peter.chen@nxp.com> (raw)
In-Reply-To: <1467366121-14120-1-git-send-email-peter.chen@nxp.com>
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
arch/arm/mach-u300/regulator.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-u300/regulator.c b/arch/arm/mach-u300/regulator.c
index 595b574..509643e 100644
--- a/arch/arm/mach-u300/regulator.c
+++ b/arch/arm/mach-u300/regulator.c
@@ -71,19 +71,21 @@ static int __init __u300_init_boardpower(struct platform_device *pdev)
regmap = syscon_node_to_regmap(syscon_np);
if (IS_ERR(regmap)) {
pr_crit("U300: could not locate syscon regmap\n");
- return PTR_ERR(regmap);
+ err = PTR_ERR(regmap);
+ goto error;
}
main_power_15 = regulator_get(&pdev->dev, "vana15");
if (IS_ERR(main_power_15)) {
pr_err("could not get vana15");
- return PTR_ERR(main_power_15);
+ err = PTR_ERR(main_power_15);
+ goto error;
}
err = regulator_enable(main_power_15);
if (err) {
pr_err("could not enable vana15\n");
- return err;
+ goto error;
}
/*
@@ -99,8 +101,12 @@ static int __init __u300_init_boardpower(struct platform_device *pdev)
/* Register globally exported PM poweroff hook */
pm_power_off = u300_pm_poweroff;
+ of_node_put(syscon_np);
return 0;
+error:
+ of_node_put(syscon_np);
+ return err;
}
static int __init s365_board_probe(struct platform_device *pdev)
--
1.9.1
next prev parent reply other threads:[~2016-07-01 9:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 9:41 [PATCH 0/7] add missing of_node_put after calling of_parse_phandle (1st) Peter Chen
2016-07-01 9:41 ` [PATCH 1/7] extcon: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-02 4:46 ` Chanwoo Choi
2016-07-01 9:41 ` [PATCH 2/7] arm: mach-shmobile: pm-rmobile: " Peter Chen
2016-07-01 12:31 ` Geert Uytterhoeven
2016-07-04 2:10 ` Peter Chen
2016-07-01 9:41 ` Peter Chen [this message]
2016-07-05 21:24 ` [PATCH 3/7] arm: mach-u300: regulator: " Linus Walleij
2016-07-01 9:41 ` [PATCH 4/7] bus: arm-cci: " Peter Chen
2016-07-01 10:29 ` Suzuki K Poulose
2016-07-01 10:33 ` Will Deacon
2016-07-04 2:48 ` Peter Chen
2016-07-04 9:19 ` Will Deacon
2016-07-01 9:41 ` [PATCH 5/7] bus: vexpress-config: " Peter Chen
2016-07-11 9:02 ` Liviu Dudau
2016-07-01 9:42 ` [PATCH 6/7] devfreq: " Peter Chen
2016-07-01 9:42 ` [PATCH 7/7] devfreq: exynos-bus: " Peter Chen
2016-07-02 4:53 ` Chanwoo Choi
[not found] ` <CGME20160701094923epcas1p164cc8773ec44a00dfc506a6192df3409@epcas1p1.samsung.com>
2016-07-06 2:38 ` [PATCH 6/7] devfreq: " MyungJoo Ham
[not found] ` <CGME20160701094927epcas1p43f956ee3465f96e2f9c99b44c0f5b49d@epcas1p4.samsung.com>
2016-07-06 2:47 ` [PATCH 7/7] devfreq: exynos-bus: " MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467366121-14120-4-git-send-email-peter.chen@nxp.com \
--to=peter.chen@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).