From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] efi: arm64: abort boot on pending SError
Date: Fri, 1 Jul 2016 17:01:30 +0200 [thread overview]
Message-ID: <1467385291-9880-1-git-send-email-ard.biesheuvel@linaro.org> (raw)
It is the firmware's job to clear any pending SErrors before entering
the kernel. On UEFI, we can fail gracefully rather than panic during
early boot, so check for this condition in the stub.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
drivers/firmware/efi/libstub/arm64-stub.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/libstub/arm64-stub.c b/drivers/firmware/efi/libstub/arm64-stub.c
index eae693eb3e91..c7e7396de876 100644
--- a/drivers/firmware/efi/libstub/arm64-stub.c
+++ b/drivers/firmware/efi/libstub/arm64-stub.c
@@ -20,7 +20,14 @@ extern bool __nokaslr;
efi_status_t check_platform_features(efi_system_table_t *sys_table_arg)
{
- u64 tg;
+ u64 tg, isr;
+
+ /* check for a pending SError */
+ asm ("mrs %0, isr_el1" : "=r"(isr));
+ if (isr & BIT(8)) {
+ pr_efi_err(sys_table_arg, "Pending SError detected -- aborting\n");
+ return EFI_LOAD_ERROR;
+ }
/* UEFI mandates support for 4 KB granularity, no need to check */
if (IS_ENABLED(CONFIG_ARM64_4K_PAGES))
--
2.7.4
next reply other threads:[~2016-07-01 15:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 15:01 Ard Biesheuvel [this message]
2016-07-01 15:01 ` [PATCH 2/2] arm64: document that pending SErrors are not allowed at kernel entry Ard Biesheuvel
2016-07-01 15:25 ` Mark Rutland
2016-07-01 15:34 ` Ard Biesheuvel
2016-07-01 15:22 ` [PATCH 1/2] efi: arm64: abort boot on pending SError Mark Rutland
2016-07-01 15:31 ` Ard Biesheuvel
2016-07-01 15:46 ` Mark Rutland
2016-07-02 10:14 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467385291-9880-1-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).