From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 871F9C35657 for ; Fri, 21 Feb 2020 17:43:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A63F206E2 for ; Fri, 21 Feb 2020 17:43:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hyjRaRBG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zq5loLRM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A63F206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SCTUZUgQpG6l8tOHP6wlTwKDnzOSyApjxKfR8eSGsyA=; b=hyjRaRBGq+xcY8 YS0yKq8/Gib9FBFIJ+9mi0Pww6bb9e+NepDwOZIWxl4X52Y2Bc0ez5jCna6oBtu3pnmBpoPwPBHMl x0ttHh2SruMao5uFPk/QSdfO2JUrWFKa42v+jnIuzNv0KwiHqBzRvUvAr0KG7PSSSsCR+K0Q1V1cl TTV6Mq62/3cT6ySucEBE7mDGSX3afgC/rB+H4NoSZlvjlnw7TEmoQk2ub5D29oU/43N0E4IgPU9yQ 0XPQ/IfYa5gg2nROIG6S7X1KsNthsJ9dTjjdpAG0yOec8wIfrTaTQewwntT8UwwZcVDqDvHzo6nzm RYa+Pk+YgS/kkFCcN0Pw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j5CL3-0005sk-7C; Fri, 21 Feb 2020 17:43:45 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j5CL0-0005s6-C0 for linux-arm-kernel@lists.infradead.org; Fri, 21 Feb 2020 17:43:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582307019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DRklp/EGbzKFbnLcWYfCTJYwspK96XjQokoDYirC2jo=; b=Zq5loLRMhapr8Z6ukvadvkVrSgGgxRg5TF6t/38e/eFh+59MoFCMjjk48tjoRLAOxbIW1Q WG6cigCAPc0m6yp9g303rQXWg2OnjDD5cDEtdkMcouYkd7Yj/gHrUWQXfmv2a9P6bePCXs AL0aGnkBqvWhrgExa98bYL4qkmerXEk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-NT-ODW41PRyQUhHlOlN94g-1; Fri, 21 Feb 2020 12:43:38 -0500 X-MC-Unique: NT-ODW41PRyQUhHlOlN94g-1 Received: by mail-wr1-f72.google.com with SMTP id o6so1327797wrp.8 for ; Fri, 21 Feb 2020 09:43:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DRklp/EGbzKFbnLcWYfCTJYwspK96XjQokoDYirC2jo=; b=JtkD4OtEvWCUdLV8LRngshdKlx2PcmAc8ed8XbUjJRrmWy0aBkvEpR2YI8ydxhRzzr si6jpPrXF/wwiq6hWGnNK6Ty7EOFMCG5VKItY3ET6XYd3lQcohHz34TQXD8bHEobhIRI hm6d9BS1ktb9xQX/ffjfcZTVr1wmnSiBzaDidCLjHtVMkhb2InEUAglxhRjM+7zBEpLF GdXhYVi75q9h6hPBWGFrYhr5Fj5qJgnOgymPTQigMJfs6y6XuL8K2Qsm7sv7qr+2jJSV 12uritmwXyD/NcuTOJImvFLyzSG+aQSrACt83Hva6DtBNeulww8uJnJczZXzHUTi6ts+ JLpw== X-Gm-Message-State: APjAAAX2XVjSCyctnsokyMHi5YaLprCQJDxjdbATe24+kn74nHU9P61A CSBaug74EE55/KOBw0TipwpfcnSABEwev8914mjvkKMbBP52gNQU1qqe6gT/4QXsgpTvm4L7O/C LMTrVmz+qBHMgr/U7frjZNqg8BrCWsdfNZvI= X-Received: by 2002:a5d:4289:: with SMTP id k9mr51196989wrq.280.1582307017029; Fri, 21 Feb 2020 09:43:37 -0800 (PST) X-Google-Smtp-Source: APXvYqx2hj716qxeeRUnhWk7oLWJU5fIlTs2+zZOl+uuyj1LRQkzfullhSLke4OG8g9MBweopRblWg== X-Received: by 2002:a5d:4289:: with SMTP id k9mr51196974wrq.280.1582307016828; Fri, 21 Feb 2020 09:43:36 -0800 (PST) Received: from [192.168.178.40] ([151.20.135.128]) by smtp.gmail.com with ESMTPSA id l131sm4908318wmf.31.2020.02.21.09.43.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Feb 2020 09:43:36 -0800 (PST) Subject: Re: [PATCH v6 14/22] KVM: Clean up local variable usage in __kvm_set_memory_region() To: Sean Christopherson References: <20200218210736.16432-1-sean.j.christopherson@intel.com> <20200218210736.16432-15-sean.j.christopherson@intel.com> From: Paolo Bonzini Message-ID: <1467b8cd-3631-b5da-b285-dbdf31b75af7@redhat.com> Date: Fri, 21 Feb 2020 18:43:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20200218210736.16432-15-sean.j.christopherson@intel.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200221_094342_487918_D6B0F677 X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , Peter Xu , linux-mips@vger.kernel.org, Paul Mackerras , kvmarm@lists.cs.columbia.edu, Janosch Frank , Marc Zyngier , Joerg Roedel , Christian Borntraeger , Julien Thierry , Suzuki K Poulose , kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jim Mattson , Cornelia Huck , Christoffer Dall , linux-kernel@vger.kernel.org, James Morse , Vitaly Kuznetsov , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/02/20 22:07, Sean Christopherson wrote: > -sorted by update_memslots(), and the old > * memslot needs to be referenced after calling update_memslots(), e.g. > - * to free its resources and for arch specific behavior. > + * to free its resources and for arch specific behavior. Kill @tmp > + * after making a copy to deter potentially dangerous usage. > */ > - old = *slot; > + tmp = id_to_memslot(__kvm_memslots(kvm, as_id), id); > + old = *tmp; > + tmp = NULL; > + Also: old = *id_to_memslot(...). Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel