From mboxrd@z Thu Jan 1 00:00:00 1970 From: van.freenix@gmail.com (Peng Fan) Date: Tue, 12 Jul 2016 09:33:44 +0800 Subject: [PATCH] iommu: arm-smmu: drop devm_free_irq when driver detach Message-ID: <1468287224-12036-1-git-send-email-van.freenix@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org There is no need to call devm_free_irq when driver detach. devres_release_all which is called after 'drv->remove' will release all managed resources. Signed-off-by: Peng Fan Cc: Will Deacon Cc: Robin Murphy --- drivers/iommu/arm-smmu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index 860652e..5837391c 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c @@ -2045,9 +2045,6 @@ static int arm_smmu_device_remove(struct platform_device *pdev) if (!bitmap_empty(smmu->context_map, ARM_SMMU_MAX_CBS)) dev_err(dev, "removing device with active domains!\n"); - for (i = 0; i < smmu->num_global_irqs; ++i) - devm_free_irq(smmu->dev, smmu->irqs[i], smmu); - /* Turn the thing off */ writel(sCR0_CLIENTPD, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sCR0); return 0; -- 2.6.2