From: ck.hu@mediatek.com (CK Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] drm/mediatek: set mt8173 dithering function
Date: Thu, 21 Jul 2016 11:58:12 +0800 [thread overview]
Message-ID: <1469073492.11841.63.camel@mtksdaap41> (raw)
In-Reply-To: <1469071288.26205.9.camel@mtksdaap41>
Hi, Bibby:
On Thu, 2016-07-21 at 11:21 +0800, Bibby Hsieh wrote:
> Hi, CK
>
> I'm appreciate your comments.
>
>
[snip...]
> > >
> > > @@ -469,7 +484,7 @@ void mtk_crtc_ddp_irq(struct drm_crtc *crtc, struct mtk_ddp_comp *ovl)
> > > if (state->pending_config) {
> > > mtk_ddp_comp_config(ovl, state->pending_width,
> > > state->pending_height,
> > > - state->pending_vrefresh);
> > > + state->pending_vrefresh, 0);
> >
> > Why set bpc as 0 here? Maybe you have a assumption that OVL don't care
> > the bpc parameter. If one day OVL care it and we do not review here, the
> > bugs happen.
> >
> Pass 0 means don't care, I will modify mtk_od_config() and
> mtk_gamma_config() to filter this condition.
Using 0 as 'don't care' looks tricky. Please add comments to describe
this.
> > >
> > > state->pending_config = false;
> > > }
Regards,
CK
prev parent reply other threads:[~2016-07-21 3:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 7:37 [PATCH v3 0/2] drm/mediatek: MT8173 gamma & dither support Bibby Hsieh
2016-07-07 7:37 ` [PATCH v3 1/2] drm/mediatek: Add gamma correction Bibby Hsieh
2016-07-15 9:11 ` CK Hu
2016-07-21 3:23 ` Bibby Hsieh
2016-07-07 7:37 ` [PATCH v3 2/2] drm/mediatek: set mt8173 dithering function Bibby Hsieh
2016-07-18 2:33 ` CK Hu
2016-07-21 3:21 ` Bibby Hsieh
2016-07-21 3:58 ` CK Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469073492.11841.63.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox