public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Kconfig: select ALPINE_MSI only if PCI is selected
Date: Fri, 22 Jul 2016 15:42:07 +0100	[thread overview]
Message-ID: <1469198527-12525-1-git-send-email-sudeep.holla@arm.com> (raw)

Even when PCI is disabled, ARCH_ALPINE selects ALPINE_MSI triggerring
the following config warning:

warning: (ARCH_ALPINE) selects ALPINE_MSI which has unmet direct dependencies (PCI)

This patch makes selection of ALPINE_MSI conditional on PCI.

Cc: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 arch/arm64/Kconfig.platforms | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Arnd,

I happened to end up with a config without PCI when switching between
DT and ACPI and saw the config warnings. This is against today's next,
not sure if you have some fix already queued. Also I am not sure if
ALPINE_MSI is must for this platform to boot in which case it needs to
select PCI.

Regards,
Sudeep

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index bb2616b16157..fd3ee3a392be 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -8,7 +8,7 @@ config ARCH_SUNXI

 config ARCH_ALPINE
 	bool "Annapurna Labs Alpine platform"
-	select ALPINE_MSI
+	select ALPINE_MSI if PCI
 	help
 	  This enables support for the Annapurna Labs Alpine
 	  Soc family.
--
2.7.4

             reply	other threads:[~2016-07-22 14:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-22 14:42 Sudeep Holla [this message]
2016-07-22 15:27 ` [PATCH] arm64: Kconfig: select ALPINE_MSI only if PCI is selected Antoine Tenart
2016-07-22 15:36   ` Sudeep Holla
2016-07-22 16:03     ` Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469198527-12525-1-git-send-email-sudeep.holla@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox