From: bibby.hsieh@mediatek.com (Bibby Hsieh)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] arm64: dts: mt8173: add mmsel clocks for 4K support
Date: Thu, 28 Jul 2016 10:47:17 +0800 [thread overview]
Message-ID: <1469674037.29230.0.camel@mtksdaap41> (raw)
In-Reply-To: <1469611556.11841.77.camel@mtksdaap41>
Hi, CK,
Thanks for your comments.
On Wed, 2016-07-27 at 17:25 +0800, CK Hu wrote:
> Hi, Bibby:
>
> On Wed, 2016-07-27 at 16:25 +0800, Bibby Hsieh wrote:
> > If MT8173 can support HDMI 4K resoultion, the
> > VENCPLL should be configured to 800MHZ.
> > We didn't set VENCPLL directly, we set the
> > mm_sel to 400MHz statically in the board device tree.
>
> You may rewrite the description as below:
>
> 'To support HDMI 4K resolution, mmsys need clock mm_sel to be 400MHz.'
>
> You need not to mention VENCPLL because it's controlled by clock driver.
>
Ok, I will modify that.
> >
> > Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> > ---
> > Changes since v2:
> > - Align the clocks of dpi0 node.
> >
> > Changes since v1:
> > - Do not set the VENCPLL by clk_set_rate
> > at display driver.
> > - Configure the mm_sel to 400MHz statically
> > in the board device tree.
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 78529e4..9c22204 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -690,7 +690,9 @@
> > compatible = "mediatek,mt8173-mmsys", "syscon";
> > reg = <0 0x14000000 0 0x1000>;
> > power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> > + clocks = <&topckgen CLK_TOP_MM_SEL>;
> > #clock-cells = <1>;
> > + clock-frequency = <400000000>;
> > };
> >
> > ovl0: ovl at 1400c000 {
>
> Regards,
> CK
>
Bibby
next prev parent reply other threads:[~2016-07-28 2:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 8:25 [PATCH v3] arm64: dts: mt8173: add mmsel clocks for 4K support Bibby Hsieh
2016-07-27 9:25 ` CK Hu
2016-07-28 2:47 ` Bibby Hsieh [this message]
2016-07-27 9:32 ` Philipp Zabel
2016-07-28 2:49 ` Bibby Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469674037.29230.0.camel@mtksdaap41 \
--to=bibby.hsieh@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).