* [PATCH -next] dmaengine: at_xdmac: fix to pass correct device identity to free_irq()
@ 2016-08-10 3:17 Wei Yongjun
2016-08-10 14:19 ` Ludovic Desroches
2016-08-22 6:23 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2016-08-10 3:17 UTC (permalink / raw)
To: linux-arm-kernel
free_irq() expects the same device identity that was passed to
corresponding request_irq(), otherwise the IRQ is not freed.
Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel
eXtended DMA Controller driver")
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/dma/at_xdmac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index 2badc57..b7d7f2d 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -2067,7 +2067,7 @@ err_dma_unregister:
err_clk_disable:
clk_disable_unprepare(atxdmac->clk);
err_free_irq:
- free_irq(atxdmac->irq, atxdmac->dma.dev);
+ free_irq(atxdmac->irq, atxdmac);
return ret;
}
@@ -2081,7 +2081,7 @@ static int at_xdmac_remove(struct platform_device *pdev)
dma_async_device_unregister(&atxdmac->dma);
clk_disable_unprepare(atxdmac->clk);
- free_irq(atxdmac->irq, atxdmac->dma.dev);
+ free_irq(atxdmac->irq, atxdmac);
for (i = 0; i < atxdmac->dma.chancnt; i++) {
struct at_xdmac_chan *atchan = &atxdmac->chan[i];
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH -next] dmaengine: at_xdmac: fix to pass correct device identity to free_irq()
2016-08-10 3:17 [PATCH -next] dmaengine: at_xdmac: fix to pass correct device identity to free_irq() Wei Yongjun
@ 2016-08-10 14:19 ` Ludovic Desroches
2016-08-22 6:23 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Desroches @ 2016-08-10 14:19 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 10, 2016 at 03:17:09AM +0000, Wei Yongjun wrote:
> free_irq() expects the same device identity that was passed to
> corresponding request_irq(), otherwise the IRQ is not freed.
>
> Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel
> eXtended DMA Controller driver")
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Thanks
> ---
> drivers/dma/at_xdmac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 2badc57..b7d7f2d 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -2067,7 +2067,7 @@ err_dma_unregister:
> err_clk_disable:
> clk_disable_unprepare(atxdmac->clk);
> err_free_irq:
> - free_irq(atxdmac->irq, atxdmac->dma.dev);
> + free_irq(atxdmac->irq, atxdmac);
> return ret;
> }
>
> @@ -2081,7 +2081,7 @@ static int at_xdmac_remove(struct platform_device *pdev)
> dma_async_device_unregister(&atxdmac->dma);
> clk_disable_unprepare(atxdmac->clk);
>
> - free_irq(atxdmac->irq, atxdmac->dma.dev);
> + free_irq(atxdmac->irq, atxdmac);
>
> for (i = 0; i < atxdmac->dma.chancnt; i++) {
> struct at_xdmac_chan *atchan = &atxdmac->chan[i];
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH -next] dmaengine: at_xdmac: fix to pass correct device identity to free_irq()
2016-08-10 3:17 [PATCH -next] dmaengine: at_xdmac: fix to pass correct device identity to free_irq() Wei Yongjun
2016-08-10 14:19 ` Ludovic Desroches
@ 2016-08-22 6:23 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2016-08-22 6:23 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 10, 2016 at 03:17:09AM +0000, Wei Yongjun wrote:
> free_irq() expects the same device identity that was passed to
> corresponding request_irq(), otherwise the IRQ is not freed.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-22 6:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-10 3:17 [PATCH -next] dmaengine: at_xdmac: fix to pass correct device identity to free_irq() Wei Yongjun
2016-08-10 14:19 ` Ludovic Desroches
2016-08-22 6:23 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).