From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Wed, 10 Aug 2016 11:51:26 +0100 Subject: [PATCH] arm64: qcom: dts: Fix broken interrupt trigger settings Message-ID: <1470826286-19913-1-git-send-email-marc.zyngier@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org When a device uses the GIC as its interrupt controller and generates SPIs, only the values 1 (edge rising) and 4 (level high) are legal. Anything else is just plain wrong (can't be programmed into the HW), and leads to aborted driver probes (USB doesn't work with 4.8-rc1 on a Dragonboard 410C). Signed-off-by: Marc Zyngier --- I've guessed the trigger settings, so someone please verify them. arch/arm64/boot/dts/qcom/msm8916.dtsi | 8 ++++---- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 11bdc24..45427834 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi @@ -483,7 +483,7 @@ compatible = "qcom,ci-hdrc"; reg = <0x78d9000 0x400>; dr_mode = "peripheral"; - interrupts = ; + interrupts = ; usb-phy = <&usb_otg>; status = "disabled"; }; @@ -491,7 +491,7 @@ usb_host: ehci at 78d9000 { compatible = "qcom,ehci-host"; reg = <0x78d9000 0x400>; - interrupts = ; + interrupts = ; usb-phy = <&usb_otg>; status = "disabled"; }; @@ -499,7 +499,7 @@ usb_otg: phy at 78d9000 { compatible = "qcom,usb-otg-snps"; reg = <0x78d9000 0x400>; - interrupts = , + interrupts = , ; qcom,vdd-levels = <500000 1000000 1320000>; @@ -594,7 +594,7 @@ <0x200a000 0x002100>; reg-names = "core", "chnls", "obsrvr", "intr", "cnfg"; interrupt-names = "periph_irq"; - interrupts = ; + interrupts = ; qcom,ee = <0>; qcom,channel = <0>; #address-cells = <2>; diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 55ec3e8..69ed6e1 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -339,7 +339,7 @@ <0x400a000 0x002100>; reg-names = "core", "chnls", "obsrvr", "intr", "cnfg"; interrupt-names = "periph_irq"; - interrupts = ; + interrupts = ; qcom,ee = <0>; qcom,channel = <0>; #address-cells = <2>; -- 2.1.4