linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jonathanh@nvidia.com (Jon Hunter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/10] PM / Domains: Store the provider in the PM domain structure
Date: Tue, 16 Aug 2016 10:49:35 +0100	[thread overview]
Message-ID: <1471340976-5379-10-git-send-email-jonathanh@nvidia.com> (raw)
In-Reply-To: <1471340976-5379-1-git-send-email-jonathanh@nvidia.com>

It is possible that a device has more than one provider of PM domains
and to support the removal of a PM domain by provider, it is necessary
to store a reference to the provider in the PM domain structure.
Therefore, store a reference to the firmware node handle in the PM
domain structure and populate it when providers (only device-tree based
providers are currently supported by PM domains) are registered.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 drivers/base/power/domain.c | 18 ++++++++++++++----
 include/linux/pm_domain.h   |  1 +
 2 files changed, 15 insertions(+), 4 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index 72b973539205..0bc145e8e902 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1539,6 +1539,8 @@ int of_genpd_add_provider_simple(struct device_node *np,
 		return -EINVAL;
 	}
 
+	genpd->provider = &np->fwnode;
+
 	ret = genpd_add_provider(np, genpd_xlate_simple, genpd);
 
 	mutex_unlock(&gpd_list_lock);
@@ -1564,10 +1566,10 @@ int of_genpd_add_provider_onecell(struct device_node *np,
 	mutex_lock(&gpd_list_lock);
 
 	for (i = 0; i < data->num_domains; i++) {
-		if (!pm_genpd_present(data->domains[i])) {
-			mutex_unlock(&gpd_list_lock);
-			return -EINVAL;
-		}
+		if (!pm_genpd_present(data->domains[i]))
+			goto error;
+
+		data->domains[i]->provider = &np->fwnode;
 	}
 
 	ret = genpd_add_provider(np, genpd_xlate_onecell, data);
@@ -1575,6 +1577,14 @@ int of_genpd_add_provider_onecell(struct device_node *np,
 	mutex_unlock(&gpd_list_lock);
 
 	return ret;
+
+error:
+	while (i--)
+		data->domains[i]->provider = NULL;
+
+	mutex_unlock(&gpd_list_lock);
+
+	return -EINVAL;
 }
 EXPORT_SYMBOL_GPL(of_genpd_add_provider_onecell);
 
diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
index fbdc5c4588ef..4aa285e44eb0 100644
--- a/include/linux/pm_domain.h
+++ b/include/linux/pm_domain.h
@@ -51,6 +51,7 @@ struct generic_pm_domain {
 	struct mutex lock;
 	struct dev_power_governor *gov;
 	struct work_struct power_off_work;
+	struct fwnode_handle *provider;	/* Identity of the domain provider */
 	const char *name;
 	atomic_t sd_count;	/* Number of subdomains with power "on" */
 	enum gpd_status status;	/* Current state of the domain */
-- 
2.1.4

  parent reply	other threads:[~2016-08-16  9:49 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16  9:49 [PATCH 00/10] PM / Domains: Add support for removing PM domains Jon Hunter
2016-08-16  9:49 ` [PATCH 01/10] PM / Domains: Add new helper functions for device-tree Jon Hunter
2016-09-08 11:34   ` Ulf Hansson
2016-08-16  9:49 ` [PATCH 02/10] ARM: EXYNOS: Remove calls to of_genpd_get_from_provider() Jon Hunter
2016-08-16 19:26   ` Krzysztof Kozlowski
2016-09-08 11:35   ` Ulf Hansson
2016-08-16  9:49 ` [PATCH 03/10] staging: board: " Jon Hunter
2016-09-08 11:35   ` Ulf Hansson
2016-08-16  9:49 ` [PATCH 04/10] PM / Domains: Don't expose generic_pm_domain structure to clients Jon Hunter
2016-09-08 11:35   ` Ulf Hansson
2016-08-16  9:49 ` [PATCH 05/10] PM / Domains: Don't expose xlate and provider helper functions Jon Hunter
2016-09-08 11:36   ` Ulf Hansson
2016-08-16  9:49 ` [PATCH 06/10] PM / Domains: Verify the PM domain is present when adding a provider Jon Hunter
2016-09-08 11:39   ` Ulf Hansson
2016-09-09  9:41     ` Jon Hunter
2016-08-16  9:49 ` [PATCH 07/10] PM / Domains: Prepare for adding support to remove PM domains Jon Hunter
2016-09-08 11:41   ` Ulf Hansson
2016-08-16  9:49 ` [PATCH 08/10] PM / Domains: Add support for removing " Jon Hunter
2016-09-08 11:49   ` Ulf Hansson
2016-09-09 13:54     ` Jon Hunter
2016-09-09 15:17       ` Jon Hunter
2016-09-12  7:21         ` Ulf Hansson
2016-09-12  7:26           ` Jon Hunter
2016-08-16  9:49 ` Jon Hunter [this message]
2016-09-08 11:56   ` [PATCH 09/10] PM / Domains: Store the provider in the PM domain structure Ulf Hansson
2016-09-09 13:57     ` Jon Hunter
2016-09-09 14:25       ` Ulf Hansson
2016-08-16  9:49 ` [PATCH 10/10] PM / Domains: Add support for removing nested PM domains by provider Jon Hunter
2016-09-08 12:30   ` Ulf Hansson
2016-09-09 14:04     ` Jon Hunter
2016-09-09 14:21       ` Ulf Hansson
2016-08-26 13:12 ` [PATCH 00/10] PM / Domains: Add support for removing PM domains Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471340976-5379-10-git-send-email-jonathanh@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).