From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: irq_work: Do not attempt to IPI on non IPI-capable HW
Date: Tue, 16 Aug 2016 16:26:50 +0100 [thread overview]
Message-ID: <1471361210-29914-1-git-send-email-marc.zyngier@arm.com> (raw)
Not all of the ARM HW is IPI capable (i.e. most of the non-SMP
systems). Unfortunately, some systems do advertise being SMP
capable, even if they have a single core and do not define
a cross call method. In this case, irq_work_queue dies
as arch_irq_work_has_interrupt() fails to detect this
particular case.
Let's redefine arch_irq_work_has_interrupt() to actually check
if we're IPI capable instead of simply being SMP. This sidesteps
the issue entierely.
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
arch/arm/include/asm/irq_work.h | 6 +++++-
arch/arm/include/asm/smp_plat.h | 2 ++
arch/arm/kernel/smp.c | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/arm/include/asm/irq_work.h b/arch/arm/include/asm/irq_work.h
index 712d03e..3ba3583 100644
--- a/arch/arm/include/asm/irq_work.h
+++ b/arch/arm/include/asm/irq_work.h
@@ -5,7 +5,11 @@
static inline bool arch_irq_work_has_interrupt(void)
{
- return is_smp();
+#ifdef CONFIG_SMP
+ return !!__smp_cross_call;
+#else
+ return false;
+#endif
}
#endif /* _ASM_ARM_IRQ_WORK_H */
diff --git a/arch/arm/include/asm/smp_plat.h b/arch/arm/include/asm/smp_plat.h
index f908071..ffee073 100644
--- a/arch/arm/include/asm/smp_plat.h
+++ b/arch/arm/include/asm/smp_plat.h
@@ -26,6 +26,8 @@ static inline bool is_smp(void)
#endif
}
+extern void (*__smp_cross_call)(const struct cpumask *, unsigned int);
+
/**
* smp_cpuid_part() - return part id for a given cpu
* @cpu: logical cpu id.
diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 8615216..f9d771f 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -465,7 +465,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
}
}
-static void (*__smp_cross_call)(const struct cpumask *, unsigned int);
+void (*__smp_cross_call)(const struct cpumask *, unsigned int);
void __init set_smp_cross_call(void (*fn)(const struct cpumask *, unsigned int))
{
--
2.1.4
next reply other threads:[~2016-08-16 15:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 15:26 Marc Zyngier [this message]
2016-08-16 15:52 ` [PATCH] ARM: irq_work: Do not attempt to IPI on non IPI-capable HW Fabio Estevam
2016-08-16 16:03 ` Marc Zyngier
2016-08-17 3:15 ` Peter Chen
2016-08-17 7:41 ` Marc Zyngier
2016-08-17 7:58 ` Peter Chen
2016-08-17 8:08 ` Marc Zyngier
2016-08-17 8:28 ` Peter Chen
2016-08-17 9:19 ` Marc Zyngier
2016-08-17 11:27 ` Peter Chen
2016-08-17 12:57 ` Marc Zyngier
2016-08-17 13:28 ` Fabio Estevam
2016-08-30 17:03 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471361210-29914-1-git-send-email-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).