* [PATCH V3 1/5] ARM: dts: bcm283x: Add missing USB clock
2016-08-21 15:09 [PATCH V3 0/5] ARM: dts: bcm2835: Add Raspberry Pi Zero Stefan Wahren
@ 2016-08-21 15:09 ` Stefan Wahren
2016-08-21 15:10 ` [PATCH V3 2/5] ARM: dts: bcm283x: Add dtsi for USB host mode Stefan Wahren
` (5 subsequent siblings)
6 siblings, 0 replies; 19+ messages in thread
From: Stefan Wahren @ 2016-08-21 15:09 UTC (permalink / raw)
To: linux-arm-kernel
According to the DWC2 binding an appropriate clock is required.
This clock isn't handled by bcm2835 clock driver, so add a fixed
clock to the bcm283x DT.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
---
arch/arm/boot/dts/bcm283x.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
index 445624a..46d46d8 100644
--- a/arch/arm/boot/dts/bcm283x.dtsi
+++ b/arch/arm/boot/dts/bcm283x.dtsi
@@ -290,6 +290,8 @@
interrupts = <1 9>;
#address-cells = <1>;
#size-cells = <0>;
+ clocks = <&clk_usb>;
+ clock-names = "otg";
};
v3d: v3d at 7ec00000 {
@@ -317,5 +319,12 @@
clock-frequency = <19200000>;
};
+ clk_usb: clock at 4 {
+ compatible = "fixed-clock";
+ reg = <4>;
+ #clock-cells = <0>;
+ clock-output-names = "otg";
+ clock-frequency = <480000000>;
+ };
};
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH V3 2/5] ARM: dts: bcm283x: Add dtsi for USB host mode
2016-08-21 15:09 [PATCH V3 0/5] ARM: dts: bcm2835: Add Raspberry Pi Zero Stefan Wahren
2016-08-21 15:09 ` [PATCH V3 1/5] ARM: dts: bcm283x: Add missing USB clock Stefan Wahren
@ 2016-08-21 15:10 ` Stefan Wahren
2016-08-22 17:57 ` Eric Anholt
2016-08-21 15:10 ` [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use " Stefan Wahren
` (4 subsequent siblings)
6 siblings, 1 reply; 19+ messages in thread
From: Stefan Wahren @ 2016-08-21 15:10 UTC (permalink / raw)
To: linux-arm-kernel
In case dr_mode isn't passed via DT, the dwc2 defaults to OTG mode.
But all Raspberry Pi boards here are designed only for host mode.
So fix this issue by providing a dtsi file which set the dr_mode
to host.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
arch/arm/boot/dts/bcm2835-rpi-a-plus.dts | 1 +
arch/arm/boot/dts/bcm2835-rpi-a.dts | 1 +
arch/arm/boot/dts/bcm2835-rpi-b-plus.dts | 1 +
arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 1 +
arch/arm/boot/dts/bcm2835-rpi-b.dts | 1 +
arch/arm/boot/dts/bcm2836-rpi-2-b.dts | 1 +
arch/arm/boot/dts/bcm283x-rpi-usb-host.dtsi | 3 +++
7 files changed, 9 insertions(+)
create mode 100644 arch/arm/boot/dts/bcm283x-rpi-usb-host.dtsi
diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
index 35ff4e7..f7f9db3 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
@@ -1,6 +1,7 @@
/dts-v1/;
#include "bcm2835.dtsi"
#include "bcm2835-rpi.dtsi"
+#include "bcm283x-rpi-usb-host.dtsi"
/ {
compatible = "raspberrypi,model-a-plus", "brcm,bcm2835";
diff --git a/arch/arm/boot/dts/bcm2835-rpi-a.dts b/arch/arm/boot/dts/bcm2835-rpi-a.dts
index 306a84e..8be102f 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-a.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-a.dts
@@ -1,6 +1,7 @@
/dts-v1/;
#include "bcm2835.dtsi"
#include "bcm2835-rpi.dtsi"
+#include "bcm283x-rpi-usb-host.dtsi"
/ {
compatible = "raspberrypi,model-a", "brcm,bcm2835";
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
index d5fdb8e..35cde65 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
@@ -2,6 +2,7 @@
#include "bcm2835.dtsi"
#include "bcm2835-rpi.dtsi"
#include "bcm283x-rpi-smsc9514.dtsi"
+#include "bcm283x-rpi-usb-host.dtsi"
/ {
compatible = "raspberrypi,model-b-plus", "brcm,bcm2835";
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
index bfc4bd9..84df85e 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
@@ -2,6 +2,7 @@
#include "bcm2835.dtsi"
#include "bcm2835-rpi.dtsi"
#include "bcm283x-rpi-smsc9512.dtsi"
+#include "bcm283x-rpi-usb-host.dtsi"
/ {
compatible = "raspberrypi,model-b-rev2", "brcm,bcm2835";
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b.dts b/arch/arm/boot/dts/bcm2835-rpi-b.dts
index 0371bb7..8e626a8 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b.dts
@@ -2,6 +2,7 @@
#include "bcm2835.dtsi"
#include "bcm2835-rpi.dtsi"
#include "bcm283x-rpi-smsc9512.dtsi"
+#include "bcm283x-rpi-usb-host.dtsi"
/ {
compatible = "raspberrypi,model-b", "brcm,bcm2835";
diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
index 29e1cfe..39dccf6 100644
--- a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
+++ b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
@@ -2,6 +2,7 @@
#include "bcm2836.dtsi"
#include "bcm2835-rpi.dtsi"
#include "bcm283x-rpi-smsc9514.dtsi"
+#include "bcm283x-rpi-usb-host.dtsi"
/ {
compatible = "raspberrypi,2-model-b", "brcm,bcm2836";
diff --git a/arch/arm/boot/dts/bcm283x-rpi-usb-host.dtsi b/arch/arm/boot/dts/bcm283x-rpi-usb-host.dtsi
new file mode 100644
index 0000000..73f4ece
--- /dev/null
+++ b/arch/arm/boot/dts/bcm283x-rpi-usb-host.dtsi
@@ -0,0 +1,3 @@
+&usb {
+ dr_mode = "host";
+};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use dtsi for USB host mode
2016-08-21 15:09 [PATCH V3 0/5] ARM: dts: bcm2835: Add Raspberry Pi Zero Stefan Wahren
2016-08-21 15:09 ` [PATCH V3 1/5] ARM: dts: bcm283x: Add missing USB clock Stefan Wahren
2016-08-21 15:10 ` [PATCH V3 2/5] ARM: dts: bcm283x: Add dtsi for USB host mode Stefan Wahren
@ 2016-08-21 15:10 ` Stefan Wahren
2016-08-31 7:59 ` Stefan Wahren
2016-10-17 17:29 ` Eric Anholt
2016-08-21 15:10 ` [PATCH V3 4/5] DT: bindings: bcm: Add Raspberry Pi Zero Stefan Wahren
` (3 subsequent siblings)
6 siblings, 2 replies; 19+ messages in thread
From: Stefan Wahren @ 2016-08-21 15:10 UTC (permalink / raw)
To: linux-arm-kernel
In case dr_mode isn't passed via DT, the dwc2 driver defaults
to OTG mode. But the Raspberry Pi 3 is designed only for host mode.
So fix this issue by linking to the dtsi file which set the dr_mode
to host.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts | 1 +
.../boot/dts/broadcom/bcm283x-rpi-usb-host.dtsi | 1 +
2 files changed, 2 insertions(+)
create mode 120000 arch/arm64/boot/dts/broadcom/bcm283x-rpi-usb-host.dtsi
diff --git a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts
index 7841b72..7625e57 100644
--- a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts
+++ b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts
@@ -2,6 +2,7 @@
#include "bcm2837.dtsi"
#include "bcm2835-rpi.dtsi"
#include "bcm283x-rpi-smsc9514.dtsi"
+#include "bcm283x-rpi-usb-host.dtsi"
/ {
compatible = "raspberrypi,3-model-b", "brcm,bcm2837";
diff --git a/arch/arm64/boot/dts/broadcom/bcm283x-rpi-usb-host.dtsi b/arch/arm64/boot/dts/broadcom/bcm283x-rpi-usb-host.dtsi
new file mode 120000
index 0000000..cbeebe3
--- /dev/null
+++ b/arch/arm64/boot/dts/broadcom/bcm283x-rpi-usb-host.dtsi
@@ -0,0 +1 @@
+../../../../arm/boot/dts/bcm283x-rpi-usb-host.dtsi
\ No newline at end of file
--
1.7.9.5
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use dtsi for USB host mode
2016-08-21 15:10 ` [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use " Stefan Wahren
@ 2016-08-31 7:59 ` Stefan Wahren
2016-09-07 10:59 ` Gerd Hoffmann
2016-10-17 17:29 ` Eric Anholt
1 sibling, 1 reply; 19+ messages in thread
From: Stefan Wahren @ 2016-08-31 7:59 UTC (permalink / raw)
To: linux-arm-kernel
Hi Gerd,
Am 21.08.2016 um 17:10 schrieb Stefan Wahren:
> In case dr_mode isn't passed via DT, the dwc2 driver defaults
> to OTG mode. But the Raspberry Pi 3 is designed only for host mode.
> So fix this issue by linking to the dtsi file which set the dr_mode
> to host.
this patch is pending and the rest has been merged. Since i don't have a
RPi 3 it's only compile tested.
Could you please test it (requires patch 1 and 2 of this series) on your
RPi 3?
Regards
Stefan
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts | 1 +
> .../boot/dts/broadcom/bcm283x-rpi-usb-host.dtsi | 1 +
> 2 files changed, 2 insertions(+)
> create mode 120000 arch/arm64/boot/dts/broadcom/bcm283x-rpi-usb-host.dtsi
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts
> index 7841b72..7625e57 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm2837-rpi-3-b.dts
> @@ -2,6 +2,7 @@
> #include "bcm2837.dtsi"
> #include "bcm2835-rpi.dtsi"
> #include "bcm283x-rpi-smsc9514.dtsi"
> +#include "bcm283x-rpi-usb-host.dtsi"
>
> / {
> compatible = "raspberrypi,3-model-b", "brcm,bcm2837";
> diff --git a/arch/arm64/boot/dts/broadcom/bcm283x-rpi-usb-host.dtsi b/arch/arm64/boot/dts/broadcom/bcm283x-rpi-usb-host.dtsi
> new file mode 120000
> index 0000000..cbeebe3
> --- /dev/null
> +++ b/arch/arm64/boot/dts/broadcom/bcm283x-rpi-usb-host.dtsi
> @@ -0,0 +1 @@
> +../../../../arm/boot/dts/bcm283x-rpi-usb-host.dtsi
> \ No newline at end of file
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use dtsi for USB host mode
2016-08-31 7:59 ` Stefan Wahren
@ 2016-09-07 10:59 ` Gerd Hoffmann
2016-09-07 12:02 ` Stefan Wahren
0 siblings, 1 reply; 19+ messages in thread
From: Gerd Hoffmann @ 2016-09-07 10:59 UTC (permalink / raw)
To: linux-arm-kernel
On Mi, 2016-08-31 at 09:59 +0200, Stefan Wahren wrote:
> Hi Gerd,
>
> Am 21.08.2016 um 17:10 schrieb Stefan Wahren:
> > In case dr_mode isn't passed via DT, the dwc2 driver defaults
> > to OTG mode. But the Raspberry Pi 3 is designed only for host mode.
> > So fix this issue by linking to the dtsi file which set the dr_mode
> > to host.
>
> this patch is pending and the rest has been merged. Since i don't have a
> RPi 3 it's only compile tested.
>
> Could you please test it (requires patch 1 and 2 of this series) on your
> RPi 3?
Have a git tree to test? Patch doesn't apply cleanly (using 4.8-rc5
with eric's for-next branch which already has 1+2), seems to depend on
more device tree changes.
Also usb is working fine for me on the rpi3 even without this, so why is
this needed? Is dwc2 defaulting to otg mode a recent change?
cheers,
Gerd
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use dtsi for USB host mode
2016-09-07 10:59 ` Gerd Hoffmann
@ 2016-09-07 12:02 ` Stefan Wahren
2016-09-07 14:17 ` Gerd Hoffmann
0 siblings, 1 reply; 19+ messages in thread
From: Stefan Wahren @ 2016-09-07 12:02 UTC (permalink / raw)
To: linux-arm-kernel
Hi Gerd,
Am 07.09.2016 um 12:59 schrieb Gerd Hoffmann:
> On Mi, 2016-08-31 at 09:59 +0200, Stefan Wahren wrote:
>> Hi Gerd,
>>
>> Am 21.08.2016 um 17:10 schrieb Stefan Wahren:
>>> In case dr_mode isn't passed via DT, the dwc2 driver defaults
>>> to OTG mode. But the Raspberry Pi 3 is designed only for host mode.
>>> So fix this issue by linking to the dtsi file which set the dr_mode
>>> to host.
>> this patch is pending and the rest has been merged. Since i don't have a
>> RPi 3 it's only compile tested.
>>
>> Could you please test it (requires patch 1 and 2 of this series) on your
>> RPi 3?
> Have a git tree to test? Patch doesn't apply cleanly (using 4.8-rc5
> with eric's for-next branch which already has 1+2), seems to depend on
> more device tree changes.
as i wrote in the changelog the patch series based on Ian Campbell's patches
ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi
ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm
Unfortunately i don't have a repo well prepared with this patch series.
My development repo doesn't contain the final series V3 [1], but the
master already has the necessary DT patches above.
> Also usb is working fine for me on the rpi3 even without this, so why is
> this needed?
In case of a multiplatform config with following settings the driver
isn't able to "detect" the role:
CONFIG_USB=y
CONFIG_USB_OTG=y
CONFIG_USB_DWC2=y
CONFIG_USB_DWC2_DUAL_ROLE=y
CONFIG_USB_PHY=y
CONFIG_NOP_USB_XCEIV=y
CONFIG_USB_GADGET=y
CONFIG_USB_ZERO=y
Also please refer to my answer here [2] and this bug [3].
> Is dwc2 defaulting to otg mode a recent change?
No, it's a default for all OTG host controller in case no dr_mode is
defined.
Regards
Stefan
[1] - https://github.com/lategoodbye/rpi-zero
[2] -
http://lists.infradead.org/pipermail/linux-rpi-kernel/2016-August/004242.html
[3] - http://marc.info/?l=linux-usb&m=147169822213074&w=2
>
> cheers,
> Gerd
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use dtsi for USB host mode
2016-09-07 12:02 ` Stefan Wahren
@ 2016-09-07 14:17 ` Gerd Hoffmann
2016-09-23 7:33 ` Stefan Wahren
0 siblings, 1 reply; 19+ messages in thread
From: Gerd Hoffmann @ 2016-09-07 14:17 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
> ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi
> ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm
Picked them up.
> In case of a multiplatform config with following settings the driver
> isn't able to "detect" the role:
>
> CONFIG_USB=y
> CONFIG_USB_OTG=y
> CONFIG_USB_DWC2=y
> CONFIG_USB_DWC2_DUAL_ROLE=y
> CONFIG_USB_PHY=y
> CONFIG_NOP_USB_XCEIV=y
> CONFIG_USB_GADGET=y
> CONFIG_USB_ZERO=y
Configured my kernel that way so the test actually tests something ;)
And ... everything looks fine. usb ethernet works, and so does the usb
keyboard. /proc/device-tree/soc/usb at 7e980000/dr_mode exists and
contains "host".
Tested-by: Gerd Hoffmann <kraxel@redhat.com>
cheers,
Gerd
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use dtsi for USB host mode
2016-09-07 14:17 ` Gerd Hoffmann
@ 2016-09-23 7:33 ` Stefan Wahren
2016-09-23 8:15 ` Eric Anholt
0 siblings, 1 reply; 19+ messages in thread
From: Stefan Wahren @ 2016-09-23 7:33 UTC (permalink / raw)
To: linux-arm-kernel
Am 07.09.2016 um 16:17 schrieb Gerd Hoffmann:
> Hi,
>
>> ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi
>> ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm
> Picked them up.
>
>> In case of a multiplatform config with following settings the driver
>> isn't able to "detect" the role:
>>
>> CONFIG_USB=y
>> CONFIG_USB_OTG=y
>> CONFIG_USB_DWC2=y
>> CONFIG_USB_DWC2_DUAL_ROLE=y
>> CONFIG_USB_PHY=y
>> CONFIG_NOP_USB_XCEIV=y
>> CONFIG_USB_GADGET=y
>> CONFIG_USB_ZERO=y
> Configured my kernel that way so the test actually tests something ;)
>
> And ... everything looks fine. usb ethernet works, and so does the usb
> keyboard. /proc/device-tree/soc/usb at 7e980000/dr_mode exists and
> contains "host".
>
> Tested-by: Gerd Hoffmann <kraxel@redhat.com>
>
This patch hasn't been merged yet. Is there something wrong?
Stefan
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use dtsi for USB host mode
2016-09-23 7:33 ` Stefan Wahren
@ 2016-09-23 8:15 ` Eric Anholt
2016-09-23 8:23 ` Stefan Wahren
0 siblings, 1 reply; 19+ messages in thread
From: Eric Anholt @ 2016-09-23 8:15 UTC (permalink / raw)
To: linux-arm-kernel
Stefan Wahren <stefan.wahren@i2se.com> writes:
> Am 07.09.2016 um 16:17 schrieb Gerd Hoffmann:
>> Hi,
>>
>>> ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi
>>> ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm
>> Picked them up.
>>
>>> In case of a multiplatform config with following settings the driver
>>> isn't able to "detect" the role:
>>>
>>> CONFIG_USB=y
>>> CONFIG_USB_OTG=y
>>> CONFIG_USB_DWC2=y
>>> CONFIG_USB_DWC2_DUAL_ROLE=y
>>> CONFIG_USB_PHY=y
>>> CONFIG_NOP_USB_XCEIV=y
>>> CONFIG_USB_GADGET=y
>>> CONFIG_USB_ZERO=y
>> Configured my kernel that way so the test actually tests something ;)
>>
>> And ... everything looks fine. usb ethernet works, and so does the usb
>> keyboard. /proc/device-tree/soc/usb at 7e980000/dr_mode exists and
>> contains "host".
>>
>> Tested-by: Gerd Hoffmann <kraxel@redhat.com>
>>
>
> This patch hasn't been merged yet. Is there something wrong?
I hadn't bumped it back to todo from RFT. Also, is this a priority
patch, since submitting merges is a pain? Does USB break in some way
without it?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160923/c5dd2a13/attachment.sig>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use dtsi for USB host mode
2016-09-23 8:15 ` Eric Anholt
@ 2016-09-23 8:23 ` Stefan Wahren
2016-09-23 11:55 ` Eric Anholt
0 siblings, 1 reply; 19+ messages in thread
From: Stefan Wahren @ 2016-09-23 8:23 UTC (permalink / raw)
To: linux-arm-kernel
Am 23.09.2016 um 10:15 schrieb Eric Anholt:
> Stefan Wahren <stefan.wahren@i2se.com> writes:
>
>> Am 07.09.2016 um 16:17 schrieb Gerd Hoffmann:
>>> Hi,
>>>
>>>> ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi
>>>> ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm
>>> Picked them up.
>>>
>>>> In case of a multiplatform config with following settings the driver
>>>> isn't able to "detect" the role:
>>>>
>>>> CONFIG_USB=y
>>>> CONFIG_USB_OTG=y
>>>> CONFIG_USB_DWC2=y
>>>> CONFIG_USB_DWC2_DUAL_ROLE=y
>>>> CONFIG_USB_PHY=y
>>>> CONFIG_NOP_USB_XCEIV=y
>>>> CONFIG_USB_GADGET=y
>>>> CONFIG_USB_ZERO=y
>>> Configured my kernel that way so the test actually tests something ;)
>>>
>>> And ... everything looks fine. usb ethernet works, and so does the usb
>>> keyboard. /proc/device-tree/soc/usb at 7e980000/dr_mode exists and
>>> contains "host".
>>>
>>> Tested-by: Gerd Hoffmann <kraxel@redhat.com>
>>>
>> This patch hasn't been merged yet. Is there something wrong?
> I hadn't bumped it back to todo from RFT. Also, is this a priority
> patch, since submitting merges is a pain?
No
> Does USB break in some way
> without it?
No. I only want know if this is still in queue and does someone care
about this patch.
Thanks
Stefan
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use dtsi for USB host mode
2016-09-23 8:23 ` Stefan Wahren
@ 2016-09-23 11:55 ` Eric Anholt
0 siblings, 0 replies; 19+ messages in thread
From: Eric Anholt @ 2016-09-23 11:55 UTC (permalink / raw)
To: linux-arm-kernel
Stefan Wahren <stefan.wahren@i2se.com> writes:
> Am 23.09.2016 um 10:15 schrieb Eric Anholt:
>> Stefan Wahren <stefan.wahren@i2se.com> writes:
>>
>>> Am 07.09.2016 um 16:17 schrieb Gerd Hoffmann:
>>>> Hi,
>>>>
>>>>> ARM: dts: Remove use of skeleton.dtsi from bcm283x.dtsi
>>>>> ARM64: dts: bcm: Use a symlink to R-Pi dtsi files from arch=arm
>>>> Picked them up.
>>>>
>>>>> In case of a multiplatform config with following settings the driver
>>>>> isn't able to "detect" the role:
>>>>>
>>>>> CONFIG_USB=y
>>>>> CONFIG_USB_OTG=y
>>>>> CONFIG_USB_DWC2=y
>>>>> CONFIG_USB_DWC2_DUAL_ROLE=y
>>>>> CONFIG_USB_PHY=y
>>>>> CONFIG_NOP_USB_XCEIV=y
>>>>> CONFIG_USB_GADGET=y
>>>>> CONFIG_USB_ZERO=y
>>>> Configured my kernel that way so the test actually tests something ;)
>>>>
>>>> And ... everything looks fine. usb ethernet works, and so does the usb
>>>> keyboard. /proc/device-tree/soc/usb at 7e980000/dr_mode exists and
>>>> contains "host".
>>>>
>>>> Tested-by: Gerd Hoffmann <kraxel@redhat.com>
>>>>
>>> This patch hasn't been merged yet. Is there something wrong?
>> I hadn't bumped it back to todo from RFT. Also, is this a priority
>> patch, since submitting merges is a pain?
> No
>> Does USB break in some way
>> without it?
>
> No. I only want know if this is still in queue and does someone care
> about this patch.
It's in my queue now. Sorry for missing it!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160923/03281913/attachment.sig>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use dtsi for USB host mode
2016-08-21 15:10 ` [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use " Stefan Wahren
2016-08-31 7:59 ` Stefan Wahren
@ 2016-10-17 17:29 ` Eric Anholt
1 sibling, 0 replies; 19+ messages in thread
From: Eric Anholt @ 2016-10-17 17:29 UTC (permalink / raw)
To: linux-arm-kernel
Stefan Wahren <stefan.wahren@i2se.com> writes:
> In case dr_mode isn't passed via DT, the dwc2 driver defaults
> to OTG mode. But the Raspberry Pi 3 is designed only for host mode.
> So fix this issue by linking to the dtsi file which set the dr_mode
> to host.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Applied Gerd's Tested-by and merged to bcm2835-dt-64-next.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161017/1eb7a5d5/attachment.sig>
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH V3 4/5] DT: bindings: bcm: Add Raspberry Pi Zero
2016-08-21 15:09 [PATCH V3 0/5] ARM: dts: bcm2835: Add Raspberry Pi Zero Stefan Wahren
` (2 preceding siblings ...)
2016-08-21 15:10 ` [PATCH V3 RFT 3/5] ARM64: dts: bcm283x: Use " Stefan Wahren
@ 2016-08-21 15:10 ` Stefan Wahren
2016-08-21 15:10 ` [PATCH V3 5/5] ARM: dts: bcm2835: " Stefan Wahren
` (2 subsequent siblings)
6 siblings, 0 replies; 19+ messages in thread
From: Stefan Wahren @ 2016-08-21 15:10 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/arm/bcm/brcm,bcm2835.txt | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt
index 6ffe087..9c97de2 100644
--- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm2835.txt
@@ -38,6 +38,10 @@ Raspberry Pi Compute Module
Required root node properties:
compatible = "raspberrypi,compute-module", "brcm,bcm2835";
+Raspberry Pi Zero
+Required root node properties:
+compatible = "raspberrypi,model-zero", "brcm,bcm2835";
+
Generic BCM2835 board
Required root node properties:
compatible = "brcm,bcm2835";
--
1.7.9.5
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH V3 5/5] ARM: dts: bcm2835: Add Raspberry Pi Zero
2016-08-21 15:09 [PATCH V3 0/5] ARM: dts: bcm2835: Add Raspberry Pi Zero Stefan Wahren
` (3 preceding siblings ...)
2016-08-21 15:10 ` [PATCH V3 4/5] DT: bindings: bcm: Add Raspberry Pi Zero Stefan Wahren
@ 2016-08-21 15:10 ` Stefan Wahren
2016-08-22 16:21 ` [PATCH V3 0/5] " Stephen Warren
2016-08-25 22:45 ` Eric Anholt
6 siblings, 0 replies; 19+ messages in thread
From: Stefan Wahren @ 2016-08-21 15:10 UTC (permalink / raw)
To: linux-arm-kernel
The Raspberry Pi Zero is a minified version of model A+. It's
notable there is no PWR LED and the ACT LED is inverted.
Additionally the Pi Zero is capable of the USB peripheral mode.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
arch/arm/boot/dts/Makefile | 3 ++-
arch/arm/boot/dts/bcm2835-rpi-zero.dts | 40 ++++++++++++++++++++++++++++++++
2 files changed, 42 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/boot/dts/bcm2835-rpi-zero.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index e38e7c9..cafa3b1 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -69,7 +69,8 @@ dtb-$(CONFIG_ARCH_BCM2835) += \
bcm2835-rpi-b-rev2.dtb \
bcm2835-rpi-b-plus.dtb \
bcm2835-rpi-a-plus.dtb \
- bcm2836-rpi-2-b.dtb
+ bcm2836-rpi-2-b.dtb \
+ bcm2835-rpi-zero.dtb
dtb-$(CONFIG_ARCH_BCM_5301X) += \
bcm4708-asus-rt-ac56u.dtb \
bcm4708-asus-rt-ac68u.dtb \
diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero.dts b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
new file mode 100644
index 0000000..60e359f
--- /dev/null
+++ b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
@@ -0,0 +1,40 @@
+/*
+ * Copyright (C) 2016 Stefan Wahren <stefan.wahren@i2se.com>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include "bcm2835.dtsi"
+#include "bcm2835-rpi.dtsi"
+#include "bcm283x-rpi-usb-host.dtsi"
+
+/ {
+ compatible = "raspberrypi,model-zero", "brcm,bcm2835";
+ model = "Raspberry Pi Zero";
+
+ leds {
+ act {
+ gpios = <&gpio 47 GPIO_ACTIVE_HIGH>;
+ };
+ };
+};
+
+&gpio {
+ pinctrl-0 = <&gpioout &alt0 &i2s_alt0 &alt3>;
+
+ /* I2S interface */
+ i2s_alt0: i2s_alt0 {
+ brcm,pins = <18 19 20 21>;
+ brcm,function = <BCM2835_FSEL_ALT0>;
+ };
+};
+
+&hdmi {
+ hpd-gpios = <&gpio 46 GPIO_ACTIVE_LOW>;
+};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH V3 0/5] ARM: dts: bcm2835: Add Raspberry Pi Zero
2016-08-21 15:09 [PATCH V3 0/5] ARM: dts: bcm2835: Add Raspberry Pi Zero Stefan Wahren
` (4 preceding siblings ...)
2016-08-21 15:10 ` [PATCH V3 5/5] ARM: dts: bcm2835: " Stefan Wahren
@ 2016-08-22 16:21 ` Stephen Warren
2016-08-25 22:45 ` Eric Anholt
6 siblings, 0 replies; 19+ messages in thread
From: Stephen Warren @ 2016-08-22 16:21 UTC (permalink / raw)
To: linux-arm-kernel
On 08/21/2016 09:09 AM, Stefan Wahren wrote:
> This patch series add support for Raspberry Pi Zero with USB host mode. It's
> based on the patch "ARM64: dts: bcm: Use a symlink to R-Pi dtsi files
> from arch=arm" from Ian Campbell. Currently there is a bug [1] which needs
> to fixed before because after applying these patch series the bug isn't
> reproducible anymore but not fixed.
>
> The patches 1-3 fixes the USB DT settings for bcm283x. Patch 3 is only compile
> tested, so it would be nice if someone with a RPi 3 could test it.
> The last patch based on the work of Lubomir Rintel [2] and Noralf Tr?nnes [3].
>
> Note: Patch 3 can't be cherry-picked because it depends on Patch 2.
All looks reasonable to me at a quick glance. I didn't validate any of
the GPIO values etc.
The series,
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH V3 0/5] ARM: dts: bcm2835: Add Raspberry Pi Zero
2016-08-21 15:09 [PATCH V3 0/5] ARM: dts: bcm2835: Add Raspberry Pi Zero Stefan Wahren
` (5 preceding siblings ...)
2016-08-22 16:21 ` [PATCH V3 0/5] " Stephen Warren
@ 2016-08-25 22:45 ` Eric Anholt
6 siblings, 0 replies; 19+ messages in thread
From: Eric Anholt @ 2016-08-25 22:45 UTC (permalink / raw)
To: linux-arm-kernel
Stefan Wahren <stefan.wahren@i2se.com> writes:
> This patch series add support for Raspberry Pi Zero with USB host mode. It's
> based on the patch "ARM64: dts: bcm: Use a symlink to R-Pi dtsi files
> from arch=arm" from Ian Campbell. Currently there is a bug [1] which needs
> to fixed before because after applying these patch series the bug isn't
> reproducible anymore but not fixed.
>
> The patches 1-3 fixes the USB DT settings for bcm283x. Patch 3 is only compile
> tested, so it would be nice if someone with a RPi 3 could test it.
> The last patch based on the work of Lubomir Rintel [2] and Noralf Tr?nnes [3].
>
> Note: Patch 3 can't be cherry-picked because it depends on Patch 2.
Pulled this series minus the arm64 patch to bcm2835-dt-next. My Pi3
setup is down currently so I wasn't able to test it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160825/7609b790/attachment.sig>
^ permalink raw reply [flat|nested] 19+ messages in thread