Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/8] clk: rockchip: add new pll-type for rk3036 and similar socs
Date: Sat, 24 Oct 2015 13:10:05 +0200	[thread overview]
Message-ID: <1474048.ydSsx6D3zg@diego> (raw)
In-Reply-To: <1445682629-21632-5-git-send-email-zhengxing@rock-chips.com>

Hi,

Am Samstag, 24. Oktober 2015, 18:30:25 schrieb Xing Zheng:
> The rk3036's pll and clock are different with base on the rk3066(rk3188,
> rk3288, rk3368 use it), there are different adjust foctors and control
> registers, so these should be independent and separate from the series
> of rk3066s.
> 
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> 

> +static void rockchip_rk3036_pll_init(struct clk_hw *hw)
> +{

In the previous version, Stephen requested that we don't use regular clock
APIs in the init-callback. I did a modification for the already present pll-
type in [0], which got already accepted. So you should probably also modify
your pll-type in this fashion :-) .

Oh and I guess patches 3 and 4 should switch places ... adding the pll-type
before the code in the clock-controller using it.


Heiko


[0] https://git.kernel.org/cgit/linux/kernel/git/clk/linux.git/commit/?h=clk-next&id=8334c0e7b983fb27e0d8788901e9621d1946ba93

  reply	other threads:[~2015-10-24 11:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-24 10:30 [PATCH v4 0/8] Build and support rk3036 SoC platform Xing Zheng
2015-10-24 10:30 ` [PATCH v4 1/8] dt-bindings: add documentation of rk3036 clock controller Xing Zheng
2015-10-24 10:30 ` [PATCH v4 3/8] clk: rockchip: add clock controller for rk3036 Xing Zheng
2015-10-24 10:30 ` [PATCH v4 4/8] clk: rockchip: add new pll-type for rk3036 and similar socs Xing Zheng
2015-10-24 11:10   ` Heiko Stübner [this message]
2015-10-24 10:40 ` [PATCH v4 5/8] ARM: dts: rockchip: add core rk3036 dts Xing Zheng
2015-10-24 10:46 ` [PATCH v4 6/8] ARM: rockchip: add support smp for rk3036 Xing Zheng
2015-10-24 10:49 ` [PATCH v4 7/8] ARM: dts: enable " Xing Zheng
2015-10-24 10:51 ` [PATCH v4 8/8] rockchip: make sure timer5 is enabled on rk3036 platforms Xing Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474048.ydSsx6D3zg@diego \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox