public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: adam@baker-net.org.uk (Adam Baker)
To: linux-arm-kernel@lists.infradead.org
Subject: Kernel 3.4 on Dreamplug: no serial console
Date: Sun, 03 Jun 2012 17:59:04 +0100	[thread overview]
Message-ID: <1475115.7BtuQWbDGm@gromit> (raw)
In-Reply-To: <loom.20120603T172511-816@post.gmane.org>

On Sunday 03 Jun 2012 15:26:14 Hans Kr?ner wrote:
> Hi again,
> 
> Many thanks to the both of you. CONFIG_SERIAL_OF_PLATFORM was exactly what
> I was missing in my .config
> 

As there are now two of us who have been tripped up by this does anyone think 
the untested patch below is

a) worthwhile
b) likely to be acceptable
c) likely to work

It feels wrong to be putting something arch specific in such general code but 
setting it as a default is cleaner than trying to select it from 
ARCH_KIRKWOOD_DT because default respects depends lines.

--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1021,6 +1021,7 @@ config SERIAL_OF_PLATFORM
        tristate "Serial port on Open Firmware platform bus"
        depends on OF
        depends on SERIAL_8250 || SERIAL_OF_PLATFORM_NWPSERIAL
+        default y if ARCH_KIRKWOOD_DT
        help
          If you have a PowerPC based system that has serial ports
          on a platform specific bus, you should enable this option.

  reply	other threads:[~2012-06-03 16:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-02 12:20 Kernel 3.4 on Dreamplug: no serial console Hans Kröner
2012-06-02 15:18 ` Adam Baker
2012-06-03 15:26 ` Hans Kröner
2012-06-03 16:59   ` Adam Baker [this message]
2012-06-03 17:12     ` Arnd Bergmann
2012-06-03 18:40       ` Jason Cooper
2012-06-03 19:09         ` Andrew Lunn
2012-06-04  8:29         ` Florian Fainelli
2012-06-04 14:30           ` Arnd Bergmann
  -- strict thread matches above, loose matches on Subject: below --
2012-06-02 18:57 Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475115.7BtuQWbDGm@gromit \
    --to=adam@baker-net.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox