linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6sx: Fix LCDIF interrupt type
Date: Mon, 10 Oct 2016 15:35:56 +0200	[thread overview]
Message-ID: <1476106556.2376.12.camel@pengutronix.de> (raw)
In-Reply-To: <20161002164435.5812-1-marex@denx.de>

Am Sonntag, den 02.10.2016, 18:44 +0200 schrieb Marek Vasut:
> The LCDIF interrupt should be triggered by the rising edge of the
> IRQ line because we only want the interrupt to trigger once per each
> frame. It seems the LCDIF IRQ line cannot be explicitly de-asserted
> by software, so the previous behavior before this patch, where the
> interrupt was triggered by level-high status of the IRQ line, caused
> the interrupt to fire again immediatelly after it was handled, which
> caused the system to lock up due to the high rate of interrupts.
> 
If there is no way to ack the IRQ how is the line going low again? Some
hardware state machine?

> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 1a473e8..9526c38 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -1143,7 +1143,7 @@
>  				lcdif1: lcdif at 02220000 {
>  					compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
>  					reg = <0x02220000 0x4000>;
> -					interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
> +					interrupts = <GIC_SPI 5 IRQ_TYPE_EDGE_RISING>;
>  					clocks = <&clks IMX6SX_CLK_LCDIF1_PIX>,
>  						 <&clks IMX6SX_CLK_LCDIF_APB>,
>  						 <&clks IMX6SX_CLK_DISPLAY_AXI>;
> @@ -1154,7 +1154,7 @@
>  				lcdif2: lcdif at 02224000 {
>  					compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif";
>  					reg = <0x02224000 0x4000>;
> -					interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
> +					interrupts = <GIC_SPI 6 IRQ_TYPE_EDGE_RISING>;
>  					clocks = <&clks IMX6SX_CLK_LCDIF2_PIX>,
>  						 <&clks IMX6SX_CLK_LCDIF_APB>,
>  						 <&clks IMX6SX_CLK_DISPLAY_AXI>;

  parent reply	other threads:[~2016-10-10 13:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-02 16:44 [PATCH] ARM: dts: imx6sx: Fix LCDIF interrupt type Marek Vasut
2016-10-02 17:43 ` Fabio Estevam
2016-10-02 18:29   ` Marek Vasut
2016-10-10 13:35 ` Lucas Stach [this message]
2016-10-10 14:42   ` Marek Vasut
2016-10-23 14:03 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476106556.2376.12.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).