* [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example
@ 2016-10-26 18:13 Stefan Wahren
2016-10-26 18:14 ` [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address Stefan Wahren
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Stefan Wahren @ 2016-10-26 18:13 UTC (permalink / raw)
To: linux-arm-kernel
The address of the mailbox node in the example has a typo.
So fix it accordingly.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Fixes: d4b5c782b9f4 ("dt/bindings: Add binding for the BCM2835 mailbox driver")
---
.../bindings/mailbox/brcm,bcm2835-mbox.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt b/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt
index e893615..b48d7d3 100644
--- a/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt
+++ b/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt
@@ -12,7 +12,7 @@ Required properties:
Example:
-mailbox: mailbox at 7e00b800 {
+mailbox: mailbox at 7e00b880 {
compatible = "brcm,bcm2835-mbox";
reg = <0x7e00b880 0x40>;
interrupts = <0 1>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address
2016-10-26 18:13 [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example Stefan Wahren
@ 2016-10-26 18:14 ` Stefan Wahren
2016-10-27 18:00 ` Eric Anholt
2016-10-30 15:34 ` Andreas Färber
2016-10-30 15:26 ` [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example Andreas Färber
2016-10-31 4:31 ` Rob Herring
2 siblings, 2 replies; 8+ messages in thread
From: Stefan Wahren @ 2016-10-26 18:14 UTC (permalink / raw)
To: linux-arm-kernel
The address of the mailbox node in the bcm283x.dts has also a typo.
So fix it accordingly.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Fixes: 05b682b7a3b2 ("ARM: bcm2835: dt: Add the mailbox to the device tree")
---
arch/arm/boot/dts/bcm283x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
index 46d46d8..74dd21b 100644
--- a/arch/arm/boot/dts/bcm283x.dtsi
+++ b/arch/arm/boot/dts/bcm283x.dtsi
@@ -104,7 +104,7 @@
reg = <0x7e104000 0x10>;
};
- mailbox: mailbox at 7e00b800 {
+ mailbox: mailbox at 7e00b880 {
compatible = "brcm,bcm2835-mbox";
reg = <0x7e00b880 0x40>;
interrupts = <0 1>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address
2016-10-26 18:14 ` [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address Stefan Wahren
@ 2016-10-27 18:00 ` Eric Anholt
2016-10-30 15:34 ` Andreas Färber
1 sibling, 0 replies; 8+ messages in thread
From: Eric Anholt @ 2016-10-27 18:00 UTC (permalink / raw)
To: linux-arm-kernel
Stefan Wahren <stefan.wahren@i2se.com> writes:
> The address of the mailbox node in the bcm283x.dts has also a typo.
> So fix it accordingly.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 05b682b7a3b2 ("ARM: bcm2835: dt: Add the mailbox to the device tree")
I've marked these to be applied once Rob acks the docs change.
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address
2016-10-26 18:14 ` [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address Stefan Wahren
2016-10-27 18:00 ` Eric Anholt
@ 2016-10-30 15:34 ` Andreas Färber
2016-10-30 17:22 ` [PATCH V2 " Stefan Wahren
1 sibling, 1 reply; 8+ messages in thread
From: Andreas Färber @ 2016-10-30 15:34 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
Am 26.10.2016 um 20:14 schrieb Stefan Wahren:
> The address of the mailbox node in the bcm283x.dts has also a typo.
.dts -> .dtsi
"also has" or maybe "has the same typo as in the binding example"?
> So fix it accordingly.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: 05b682b7a3b2 ("ARM: bcm2835: dt: Add the mailbox to the device tree")
> ---
> arch/arm/boot/dts/bcm283x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
> index 46d46d8..74dd21b 100644
> --- a/arch/arm/boot/dts/bcm283x.dtsi
> +++ b/arch/arm/boot/dts/bcm283x.dtsi
> @@ -104,7 +104,7 @@
> reg = <0x7e104000 0x10>;
> };
>
> - mailbox: mailbox at 7e00b800 {
> + mailbox: mailbox at 7e00b880 {
> compatible = "brcm,bcm2835-mbox";
> reg = <0x7e00b880 0x40>;
> interrupts = <0 1>;
Otherwise,
Reviewed-by: Andreas F?rber <afaerber@suse.de>
At one point in time dtc did complain about such mismatches...
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH V2 2/2] ARM: dts: bcm283x: fix typo in mailbox address
2016-10-30 15:34 ` Andreas Färber
@ 2016-10-30 17:22 ` Stefan Wahren
2016-10-31 18:06 ` Eric Anholt
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Wahren @ 2016-10-30 17:22 UTC (permalink / raw)
To: linux-arm-kernel
The address of the mailbox node in the bcm283x.dtsi also has a typo.
So fix it accordingly.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Andreas F?rber <afaerber@suse.de>
Fixes: 05b682b7a3b2 ("ARM: bcm2835: dt: Add the mailbox to the device tree")
---
Changes in V2:
* fixed commit message as reported by Andreas
arch/arm/boot/dts/bcm283x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
index 46d46d8..74dd21b 100644
--- a/arch/arm/boot/dts/bcm283x.dtsi
+++ b/arch/arm/boot/dts/bcm283x.dtsi
@@ -104,7 +104,7 @@
reg = <0x7e104000 0x10>;
};
- mailbox: mailbox at 7e00b800 {
+ mailbox: mailbox at 7e00b880 {
compatible = "brcm,bcm2835-mbox";
reg = <0x7e00b880 0x40>;
interrupts = <0 1>;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example
2016-10-26 18:13 [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example Stefan Wahren
2016-10-26 18:14 ` [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address Stefan Wahren
@ 2016-10-30 15:26 ` Andreas Färber
2016-10-31 4:31 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Andreas Färber @ 2016-10-30 15:26 UTC (permalink / raw)
To: linux-arm-kernel
Am 26.10.2016 um 20:13 schrieb Stefan Wahren:
> The address of the mailbox node in the example has a typo.
> So fix it accordingly.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: d4b5c782b9f4 ("dt/bindings: Add binding for the BCM2835 mailbox driver")
> ---
> .../bindings/mailbox/brcm,bcm2835-mbox.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andreas F?rber <afaerber@suse.de>
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example
2016-10-26 18:13 [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example Stefan Wahren
2016-10-26 18:14 ` [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address Stefan Wahren
2016-10-30 15:26 ` [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example Andreas Färber
@ 2016-10-31 4:31 ` Rob Herring
2 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2016-10-31 4:31 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Oct 26, 2016 at 06:13:59PM +0000, Stefan Wahren wrote:
> The address of the mailbox node in the example has a typo.
> So fix it accordingly.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Fixes: d4b5c782b9f4 ("dt/bindings: Add binding for the BCM2835 mailbox driver")
> ---
> .../bindings/mailbox/brcm,bcm2835-mbox.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-10-31 18:06 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-26 18:13 [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example Stefan Wahren
2016-10-26 18:14 ` [PATCH 2/2] ARM: dts: bcm283x: fix typo in mailbox address Stefan Wahren
2016-10-27 18:00 ` Eric Anholt
2016-10-30 15:34 ` Andreas Färber
2016-10-30 17:22 ` [PATCH V2 " Stefan Wahren
2016-10-31 18:06 ` Eric Anholt
2016-10-30 15:26 ` [PATCH 1/2] DT: binding: bcm2835-mbox: fix address typo in example Andreas Färber
2016-10-31 4:31 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).