From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 08/11] arm64: smp: prepare for smp_processor_id() rework
Date: Thu, 3 Nov 2016 20:23:10 +0000 [thread overview]
Message-ID: <1478204593-29145-9-git-send-email-mark.rutland@arm.com> (raw)
In-Reply-To: <1478204593-29145-1-git-send-email-mark.rutland@arm.com>
Subsequent patches will make smp_processor_id() use a percpu variable.
This will make smp_processor_id() dependent on the percpu offset, and
thus we cannot use smp_processor_id() to figure out what to initialise
the offset to.
Prepare for this by initialising the percpu offset based on
current::cpu, which will work regardless of how smp_processor_id() is
implemented. Also, make this relationship obvious by placing this code
together at the start of secondary_start_kernel().
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Laura Abbott <labbott@redhat.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
---
arch/arm64/kernel/smp.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 8507703..f64401f 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -208,7 +208,10 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
asmlinkage void secondary_start_kernel(void)
{
struct mm_struct *mm = &init_mm;
- unsigned int cpu = smp_processor_id();
+ unsigned int cpu;
+
+ cpu = task_cpu(current);
+ set_my_cpu_offset(per_cpu_offset(cpu));
/*
* All kernel threads share the same mm context; grab a
@@ -217,8 +220,6 @@ asmlinkage void secondary_start_kernel(void)
atomic_inc(&mm->mm_count);
current->active_mm = mm;
- set_my_cpu_offset(per_cpu_offset(smp_processor_id()));
-
/*
* TTBR0 is only used for the identity mapping at this stage. Make it
* point to zero page to avoid speculatively fetching new entries.
--
2.7.4
next prev parent reply other threads:[~2016-11-03 20:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 20:23 [PATCHv2 00/11] arm64: move thread_info off of the task stack Mark Rutland
2016-11-03 20:23 ` [PATCHv2 01/11] arm64: thread_info remove stale items Mark Rutland
2016-11-03 20:23 ` [PATCHv2 02/11] arm64: asm-offsets: remove unused definitions Mark Rutland
2016-11-03 20:23 ` [PATCHv2 03/11] arm64: factor out current_stack_pointer Mark Rutland
2016-11-03 20:23 ` [PATCHv2 04/11] arm64: traps: simplify die() and __die() Mark Rutland
2016-11-03 20:23 ` [PATCHv2 05/11] arm64: unexport walk_stackframe Mark Rutland
2016-11-03 20:23 ` [PATCHv2 06/11] arm64: prep stack walkers for THREAD_INFO_IN_TASK Mark Rutland
2016-11-03 20:23 ` [PATCHv2 07/11] arm64: move sp_el0 and tpidr_el1 into cpu_suspend_ctx Mark Rutland
2016-11-03 20:23 ` Mark Rutland [this message]
2016-11-03 20:23 ` [PATCHv2 09/11] arm64: make cpu number a percpu variable Mark Rutland
2016-11-03 20:23 ` [PATCHv2 10/11] arm64: assembler: introduce ldr_this_cpu Mark Rutland
2016-11-03 20:23 ` [PATCHv2 11/11] arm64: split thread_info from task stack Mark Rutland
2016-11-14 17:50 ` [PATCHv2 00/11] arm64: move thread_info off of the " Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478204593-29145-9-git-send-email-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).