* [PATCH] arm64: dts: rockchip: add gmac needed clk for rk3399 pd
@ 2016-11-14 4:36 Caesar Wang
2016-11-14 14:42 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Caesar Wang @ 2016-11-14 4:36 UTC (permalink / raw)
To: linux-arm-kernel
From: Jeffy Chen <jeffy.chen@rock-chips.com>
This patch fixes that sometimes hang at start-up time of the system.
As the below log:
...
[ 11.136543] calling pm_genpd_debug_init+0x0/0x60 @ 1
[ 11.141602] initcall pm_genpd_debug_init+0x0/0x60 returned 0 after 11 usecs
[ 11.148558] calling genpd_poweroff_unused+0x0/0x84 @ 1
<hang>
In some cases, the rk3399 should turn off the gmac power domain to save
power if some boards didn't register the gmac device node for rk3399.
Then, rk3399 need to make sure the gmac's pclk enabled if we need
operate the gmac power domain. (Due to the NOC had enabled always)
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Caesar Wang <wxt@rock-chips.com>
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 172e7ed..e8b9df9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -825,7 +825,8 @@
/* These power domains are grouped by VD_LOGIC */
pd_gmac at RK3399_PD_GMAC {
reg = <RK3399_PD_GMAC>;
- clocks = <&cru ACLK_GMAC>;
+ clocks = <&cru ACLK_GMAC>,
+ <&cru PCLK_GMAC>;
pm_qos = <&qos_gmac>;
};
pd_vio at RK3399_PD_VIO {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] arm64: dts: rockchip: add gmac needed clk for rk3399 pd
2016-11-14 4:36 [PATCH] arm64: dts: rockchip: add gmac needed clk for rk3399 pd Caesar Wang
@ 2016-11-14 14:42 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2016-11-14 14:42 UTC (permalink / raw)
To: linux-arm-kernel
Am Montag, 14. November 2016, 12:36:39 CET schrieb Caesar Wang:
> From: Jeffy Chen <jeffy.chen@rock-chips.com>
>
> This patch fixes that sometimes hang at start-up time of the system.
> As the below log:
> ...
> [ 11.136543] calling pm_genpd_debug_init+0x0/0x60 @ 1
> [ 11.141602] initcall pm_genpd_debug_init+0x0/0x60 returned 0 after 11
> usecs [ 11.148558] calling genpd_poweroff_unused+0x0/0x84 @ 1
> <hang>
>
> In some cases, the rk3399 should turn off the gmac power domain to save
> power if some boards didn't register the gmac device node for rk3399.
> Then, rk3399 need to make sure the gmac's pclk enabled if we need
> operate the gmac power domain. (Due to the NOC had enabled always)
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
applied to my dts64 branch
Thanks
Heiko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-14 14:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-14 4:36 [PATCH] arm64: dts: rockchip: add gmac needed clk for rk3399 pd Caesar Wang
2016-11-14 14:42 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).