From: tomas.hlavacek@nic.cz (tomas.hlavacek at nic.cz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] ARM: dts: add support for Turris Omnia
Date: Tue, 22 Nov 2016 22:59:51 +0100 [thread overview]
Message-ID: <1479851991.26813.2@smtp.gmail.com> (raw)
In-Reply-To: <20161120203037.pd5mhqyjeotileve@perseus.defre.kleine-koenig.org>
Hi Uwe!
On Sun, Nov 20, 2016 at 9:30 PM, Uwe Kleine-K?nig
<uwe@kleine-koenig.org> wrote:
> Hello Tomas,
>
> On Sat, Nov 19, 2016 at 09:09:07PM +0100, tomas.hlavacek at nic.cz wrote:
>> On Mon, Nov 14, 2016 at 9:28 PM, Andrew Lunn <andrew@lunn.ch> wrote:
>> > Interrupts don't seem to work very well with the nxp,pca9538.
>> Which
>> > is probably why it is disabled by default.
>>
>> I was thinking about this issue and I can remember that there was
>> an earlier
>> prototype that had a shared interrupt line from PHY (88E1514) and
>> from the
>> PCA9538. In this case we needed to specifically disable the
>> interrupt of the
>> PHY to release the interrupt line (which needed a hack into PHY
>> driver
>> code). The IRQ from PHY is connected as an ordinary input to
>> PCA9538 in
>> later board prototype. And the same holds for the production
>> version.
>
> That would explain why I see an "irq but nobody cared" message when
> booting the original system.
>
> This isn't the problem I meant though. When adding interrupt-parent =
> <&pcawan>; interrupts = <7 IRQ_TYPE_LEVEL_LOW>; to the phy node I get
> an
> error saying that there is no irq domain associated with this device.
>
>> Do you have CZ11NIC13 or older board revision?
>
> CZ11NIC12 is indicated on my board.
:-( Well, this board version has wrongly matched length of some
differential pairs, IRQ from 88E1514 is connected differently, there
are slight differences in power supplies and (if I am not mistaken)
something changed in RTC support circuitry. It looks like a huge
mistake on our side.
Anyway I took your patch and tried few things:
- clean up comments
- add pca9538 interrupt-controller
- remove rtc disable (WFM with CZ11NIC13, which is the production board)
- add MBUS mem regions for CESA
- add IRQ for 88E1514 PHY - and there is a problem:
It seems that libphy is probed before pca9538 and we end up with:
[ 4.217550] libphy: orion_mdio_bus: probed
[ 4.221777] irq: no irq domain found for
/soc/internal-regs/i2c at 11000/i2cmux at 70/i2c at 7/gpio at 71 !
Any clue where to look in order to defer probing libphy or at least
orion_mdio_bus?
I'll post my version of the patch without the PHY IRQ (therefore
polling will kick in).
Thanks,
Tomas
next prev parent reply other threads:[~2016-11-22 21:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-05 20:38 [PATCH RFC] ARM: dts: add support for Turris Omnia Uwe Kleine-König
2016-11-05 21:04 ` Andrew Lunn
2016-11-05 22:08 ` Uwe Kleine-König
2016-11-06 10:19 ` Andrew Lunn
2016-11-05 21:23 ` Andrew Lunn
2016-11-05 21:27 ` Uwe Kleine-König
2016-11-05 21:37 ` Andrew Lunn
[not found] ` <20161106104534.lsdyppz5qcnjcqe4@perseus.defre.kleine-koenig.org>
[not found] ` <20161106111109.GD9617@lunn.ch>
[not found] ` <20161106141716.fwgje74rhhixnixq@perseus.defre.kleine-koenig.org>
[not found] ` <20161106162809.GA14042@lunn.ch>
2016-11-06 19:32 ` Uwe Kleine-König
2016-11-07 7:41 ` Martin Strbačka
2016-11-14 12:23 ` tomas.hlavacek at nic.cz
2016-11-14 13:10 ` Andrew Lunn
2016-11-14 14:59 ` tomas.hlavacek at nic.cz
2016-11-14 20:16 ` Uwe Kleine-König
2016-11-14 20:28 ` Andrew Lunn
2016-11-19 20:09 ` tomas.hlavacek at nic.cz
2016-11-20 20:30 ` Uwe Kleine-König
2016-11-22 21:59 ` tomas.hlavacek at nic.cz [this message]
2016-11-23 0:09 ` [RFC PATCH] ARM: dts: Add " Tomas Hlavacek
2016-11-23 0:35 ` Andrew Lunn
2016-11-24 8:37 ` Uwe Kleine-König
2016-11-24 15:07 ` Andrew Lunn
2016-11-25 12:49 ` Tomas Hlavacek
2016-11-25 14:34 ` Uwe Kleine-König
2016-12-10 8:16 ` Pavel Machek
2016-11-23 8:19 ` Uwe Kleine-König
2016-11-23 0:27 ` [PATCH RFC] ARM: dts: add " tomas.hlavacek at nic.cz
2016-11-23 1:39 ` Andrew Lunn
2016-11-23 14:59 ` Andrew Lunn
2016-11-23 18:36 ` Uwe Kleine-König
2016-11-23 22:45 ` tomas.hlavacek at nic.cz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479851991.26813.2@smtp.gmail.com \
--to=tomas.hlavacek@nic.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).