* [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support @ 2016-11-23 12:14 Chris Paterson 2016-11-23 13:18 ` Marc Kleine-Budde 2016-11-24 16:13 ` [PATCH v2 " Chris Paterson 0 siblings, 2 replies; 15+ messages in thread From: Chris Paterson @ 2016-11-23 12:14 UTC (permalink / raw) To: linux-arm-kernel This patch series adds CAN and CAN FD support to the r8a7796. Based on renesas-devel-20161122-v4.9-rc6. Chris Paterson (3): arm64: dts: r8a7796: Add CAN external clock support arm64: dts: r8a7796: Add CAN support arm64: dts: r8a7796: Add CAN FD support .../devicetree/bindings/net/can/rcar_can.txt | 12 +++-- .../devicetree/bindings/net/can/rcar_canfd.txt | 12 +++-- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 61 ++++++++++++++++++++++ 3 files changed, 75 insertions(+), 10 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support 2016-11-23 12:14 [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support Chris Paterson @ 2016-11-23 13:18 ` Marc Kleine-Budde 2016-11-23 14:29 ` Simon Horman 2016-11-24 16:13 ` [PATCH v2 " Chris Paterson 1 sibling, 1 reply; 15+ messages in thread From: Marc Kleine-Budde @ 2016-11-23 13:18 UTC (permalink / raw) To: linux-arm-kernel On 11/23/2016 01:14 PM, Chris Paterson wrote: > This patch series adds CAN and CAN FD support to the r8a7796. > > Based on renesas-devel-20161122-v4.9-rc6. > > Chris Paterson (3): > arm64: dts: r8a7796: Add CAN external clock support > arm64: dts: r8a7796: Add CAN support > arm64: dts: r8a7796: Add CAN FD support > > .../devicetree/bindings/net/can/rcar_can.txt | 12 +++-- > .../devicetree/bindings/net/can/rcar_canfd.txt | 12 +++-- > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 61 ++++++++++++++++++++++ > 3 files changed, 75 insertions(+), 10 deletions(-) For all three: Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> Who takes this series? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161123/1a4068ca/attachment.sig> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support 2016-11-23 13:18 ` Marc Kleine-Budde @ 2016-11-23 14:29 ` Simon Horman 2016-11-23 14:31 ` Marc Kleine-Budde 2016-11-24 10:05 ` Chris Paterson 0 siblings, 2 replies; 15+ messages in thread From: Simon Horman @ 2016-11-23 14:29 UTC (permalink / raw) To: linux-arm-kernel On Wed, Nov 23, 2016 at 02:18:13PM +0100, Marc Kleine-Budde wrote: > On 11/23/2016 01:14 PM, Chris Paterson wrote: > > This patch series adds CAN and CAN FD support to the r8a7796. > > > > Based on renesas-devel-20161122-v4.9-rc6. > > > > Chris Paterson (3): > > arm64: dts: r8a7796: Add CAN external clock support > > arm64: dts: r8a7796: Add CAN support > > arm64: dts: r8a7796: Add CAN FD support > > > > .../devicetree/bindings/net/can/rcar_can.txt | 12 +++-- > > .../devicetree/bindings/net/can/rcar_canfd.txt | 12 +++-- > > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 61 ++++++++++++++++++++++ > > 3 files changed, 75 insertions(+), 10 deletions(-) > > For all three: > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> > > Who takes this series? I would like to see these patches split up so that the .../devicetree/bindings/ portions can go through you whole the arch/arm64/boot/dts/renesas/ portions go thorugh my renesas tree. Regarding the arch/arm64/boot/dts/renesas/ portion, I would like some consideration given to what effect enabling memory above 4Gb (64bit addressing) would have. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support 2016-11-23 14:29 ` Simon Horman @ 2016-11-23 14:31 ` Marc Kleine-Budde 2016-11-24 10:05 ` Chris Paterson 1 sibling, 0 replies; 15+ messages in thread From: Marc Kleine-Budde @ 2016-11-23 14:31 UTC (permalink / raw) To: linux-arm-kernel On 11/23/2016 03:29 PM, Simon Horman wrote: > On Wed, Nov 23, 2016 at 02:18:13PM +0100, Marc Kleine-Budde wrote: >> On 11/23/2016 01:14 PM, Chris Paterson wrote: >>> This patch series adds CAN and CAN FD support to the r8a7796. >>> >>> Based on renesas-devel-20161122-v4.9-rc6. >>> >>> Chris Paterson (3): >>> arm64: dts: r8a7796: Add CAN external clock support >>> arm64: dts: r8a7796: Add CAN support >>> arm64: dts: r8a7796: Add CAN FD support >>> >>> .../devicetree/bindings/net/can/rcar_can.txt | 12 +++-- >>> .../devicetree/bindings/net/can/rcar_canfd.txt | 12 +++-- >>> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 61 ++++++++++++++++++++++ >>> 3 files changed, 75 insertions(+), 10 deletions(-) >> >> For all three: >> >> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> >> >> Who takes this series? > > I would like to see these patches split up so that the > .../devicetree/bindings/ portions can go through you whole > the arch/arm64/boot/dts/renesas/ portions go thorugh my renesas tree. Ok > Regarding the arch/arm64/boot/dts/renesas/ portion, I would like > some consideration given to what effect enabling memory above 4Gb > (64bit addressing) would have. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161123/803507ec/attachment.sig> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support 2016-11-23 14:29 ` Simon Horman 2016-11-23 14:31 ` Marc Kleine-Budde @ 2016-11-24 10:05 ` Chris Paterson 2016-11-24 10:17 ` Simon Horman 1 sibling, 1 reply; 15+ messages in thread From: Chris Paterson @ 2016-11-24 10:05 UTC (permalink / raw) To: linux-arm-kernel Hello Simon, From: Simon Horman [mailto:horms at verge.net.au] Sent: 23 November 2016 14:30 > On Wed, Nov 23, 2016 at 02:18:13PM +0100, Marc Kleine-Budde wrote: > > On 11/23/2016 01:14 PM, Chris Paterson wrote: > > > This patch series adds CAN and CAN FD support to the r8a7796. > > > > > > Based on renesas-devel-20161122-v4.9-rc6. > > > > > > Chris Paterson (3): > > > arm64: dts: r8a7796: Add CAN external clock support > > > arm64: dts: r8a7796: Add CAN support > > > arm64: dts: r8a7796: Add CAN FD support > > > > > > .../devicetree/bindings/net/can/rcar_can.txt | 12 +++-- > > > .../devicetree/bindings/net/can/rcar_canfd.txt | 12 +++-- > > > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 61 > ++++++++++++++++++++++ > > > 3 files changed, 75 insertions(+), 10 deletions(-) > > > > For all three: > > > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> > > > > Who takes this series? > > I would like to see these patches split up so that the .../devicetree/bindings/ > portions can go through you whole the arch/arm64/boot/dts/renesas/ > portions go thorugh my renesas tree. Okay, will do. > > Regarding the arch/arm64/boot/dts/renesas/ portion, I would like some > consideration given to what effect enabling memory above 4Gb (64bit > addressing) would have. Can you give me some guidance here? I'm not sure what you're referring to. As far as I know the DT reg definition here is 64-bit, or are you referring to DMA usage? If the later, neither CAN driver uses DMA. Kind regards, Chris ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support 2016-11-24 10:05 ` Chris Paterson @ 2016-11-24 10:17 ` Simon Horman 2016-11-24 14:25 ` Chris Paterson 0 siblings, 1 reply; 15+ messages in thread From: Simon Horman @ 2016-11-24 10:17 UTC (permalink / raw) To: linux-arm-kernel Hi Chris, On Thu, Nov 24, 2016 at 10:05:08AM +0000, Chris Paterson wrote: > Hello Simon, > > From: Simon Horman [mailto:horms at verge.net.au] > Sent: 23 November 2016 14:30 > > On Wed, Nov 23, 2016 at 02:18:13PM +0100, Marc Kleine-Budde wrote: > > > On 11/23/2016 01:14 PM, Chris Paterson wrote: > > > > This patch series adds CAN and CAN FD support to the r8a7796. > > > > > > > > Based on renesas-devel-20161122-v4.9-rc6. > > > > > > > > Chris Paterson (3): > > > > arm64: dts: r8a7796: Add CAN external clock support > > > > arm64: dts: r8a7796: Add CAN support > > > > arm64: dts: r8a7796: Add CAN FD support > > > > > > > > .../devicetree/bindings/net/can/rcar_can.txt | 12 +++-- > > > > .../devicetree/bindings/net/can/rcar_canfd.txt | 12 +++-- > > > > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 61 > > ++++++++++++++++++++++ > > > > 3 files changed, 75 insertions(+), 10 deletions(-) > > > > > > For all three: > > > > > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> > > > > > > Who takes this series? > > > > I would like to see these patches split up so that the .../devicetree/bindings/ > > portions can go through you whole the arch/arm64/boot/dts/renesas/ > > portions go thorugh my renesas tree. > > Okay, will do. Thanks. > > Regarding the arch/arm64/boot/dts/renesas/ portion, I would like some > > consideration given to what effect enabling memory above 4Gb (64bit > > addressing) would have. > > Can you give me some guidance here? I'm not sure what you're referring > to. As far as I know the DT reg definition here is 64-bit, or are you > referring to DMA usage? If the later, neither CAN driver uses DMA. Sorry for not being clearer. What I would like to know is if there are any problems in the CAN driver or hardware that would prevent it from functioning with memory that requires 64bit addressing present. If the CAN hardware cannot use DMA then DMA doesn't need to be taken into account. But if it DMA could be enabled in future for CAN, for example after some driver enhancements, then it would be good to know if 64bit memory can be supported - if not it would imply DMA cannot be enabled. As for non-DMA mode, will this function if memory above 4G is present? If not then in theory such memory couldn't be enabled if the CAN driver is enabled. This is my main concern. Does the above help? ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support 2016-11-24 10:17 ` Simon Horman @ 2016-11-24 14:25 ` Chris Paterson 2016-11-24 14:32 ` Simon Horman 2016-11-24 16:41 ` Geert Uytterhoeven 0 siblings, 2 replies; 15+ messages in thread From: Chris Paterson @ 2016-11-24 14:25 UTC (permalink / raw) To: linux-arm-kernel Hello Simon, From: Simon Horman [mailto:horms at verge.net.au] Sent: 24 November 2016 10:18 > Hi Chris, > > On Thu, Nov 24, 2016 at 10:05:08AM +0000, Chris Paterson wrote: > > Hello Simon, > > > > From: Simon Horman [mailto:horms at verge.net.au] > > Sent: 23 November 2016 14:30 > > > On Wed, Nov 23, 2016 at 02:18:13PM +0100, Marc Kleine-Budde wrote: > > > > On 11/23/2016 01:14 PM, Chris Paterson wrote: > > > > > This patch series adds CAN and CAN FD support to the r8a7796. > > > > > > > > > > Based on renesas-devel-20161122-v4.9-rc6. > > > > > > > > > > Chris Paterson (3): > > > > > arm64: dts: r8a7796: Add CAN external clock support > > > > > arm64: dts: r8a7796: Add CAN support > > > > > arm64: dts: r8a7796: Add CAN FD support > > > > > > > > > > .../devicetree/bindings/net/can/rcar_can.txt | 12 +++-- > > > > > .../devicetree/bindings/net/can/rcar_canfd.txt | 12 +++-- > > > > > arch/arm64/boot/dts/renesas/r8a7796.dtsi | 61 > > > ++++++++++++++++++++++ > > > > > 3 files changed, 75 insertions(+), 10 deletions(-) > > > > > > > > For all three: > > > > > > > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> > > > > > > > > Who takes this series? > > > > > > I would like to see these patches split up so that the > > > .../devicetree/bindings/ portions can go through you whole the > > > arch/arm64/boot/dts/renesas/ portions go thorugh my renesas tree. > > > > Okay, will do. > > Thanks. > > > > Regarding the arch/arm64/boot/dts/renesas/ portion, I would like > > > some consideration given to what effect enabling memory above 4Gb > > > (64bit > > > addressing) would have. > > > > Can you give me some guidance here? I'm not sure what you're referring > > to. As far as I know the DT reg definition here is 64-bit, or are you > > referring to DMA usage? If the later, neither CAN driver uses DMA. > > Sorry for not being clearer. > > What I would like to know is if there are any problems in the CAN driver or > hardware that would prevent it from functioning with memory that requires > 64bit addressing present. > > If the CAN hardware cannot use DMA then DMA doesn't need to be taken > into account. But if it DMA could be enabled in future for CAN, for example > after some driver enhancements, then it would be good to know if 64bit > memory can be supported - if not it would imply DMA cannot be enabled. Thank you for the clarification. The CAN interface for r8a7795/6 does not support DMA. With CAN FD there is currently a H/W issue that means DMA is unusable. Potentially this issue could be fixed in the future and DMA support could be added to the driver. If this happens I can see no reason why the CAN FD IP wouldn't be able to handle DMA transfers when using 64bit addressing. > > As for non-DMA mode, will this function if memory above 4G is present? > If not then in theory such memory couldn't be enabled if the CAN driver is > enabled. This is my main concern. Yes, it functions fine. We have already tested this with the Renesas v3.3.2 BSP with >4Gb memory. If this is explanation okay for you, I'll proceed with a v2 splitting off the DT bindings documentation. Kind regards, Chris > > Does the above help? ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support 2016-11-24 14:25 ` Chris Paterson @ 2016-11-24 14:32 ` Simon Horman 2016-11-24 16:41 ` Geert Uytterhoeven 1 sibling, 0 replies; 15+ messages in thread From: Simon Horman @ 2016-11-24 14:32 UTC (permalink / raw) To: linux-arm-kernel Hi Chris, On Thu, Nov 24, 2016 at 02:25:06PM +0000, Chris Paterson wrote: > Hello Simon, > > From: Simon Horman [mailto:horms at verge.net.au] > Sent: 24 November 2016 10:18 > > Hi Chris, > > > > On Thu, Nov 24, 2016 at 10:05:08AM +0000, Chris Paterson wrote: > > > Hello Simon, > > > > > > From: Simon Horman [mailto:horms at verge.net.au] > > > Sent: 23 November 2016 14:30 > > > > On Wed, Nov 23, 2016 at 02:18:13PM +0100, Marc Kleine-Budde wrote: > > > > > On 11/23/2016 01:14 PM, Chris Paterson wrote: ... > > > > Regarding the arch/arm64/boot/dts/renesas/ portion, I would like > > > > some consideration given to what effect enabling memory above 4Gb > > > > (64bit > > > > addressing) would have. > > > > > > Can you give me some guidance here? I'm not sure what you're referring > > > to. As far as I know the DT reg definition here is 64-bit, or are you > > > referring to DMA usage? If the later, neither CAN driver uses DMA. > > > > Sorry for not being clearer. > > > > What I would like to know is if there are any problems in the CAN driver or > > hardware that would prevent it from functioning with memory that requires > > 64bit addressing present. > > > > If the CAN hardware cannot use DMA then DMA doesn't need to be taken > > into account. But if it DMA could be enabled in future for CAN, for example > > after some driver enhancements, then it would be good to know if 64bit > > memory can be supported - if not it would imply DMA cannot be enabled. > > Thank you for the clarification. > > The CAN interface for r8a7795/6 does not support DMA. > > With CAN FD there is currently a H/W issue that means DMA is unusable. > Potentially this issue could be fixed in the future and DMA support could > be added to the driver. If this happens I can see no reason why the CAN > FD IP wouldn't be able to handle DMA transfers when using 64bit > addressing. > > > > > As for non-DMA mode, will this function if memory above 4G is present? > > If not then in theory such memory couldn't be enabled if the CAN driver > > is enabled. This is my main concern. > > Yes, it functions fine. We have already tested this with the Renesas > v3.3.2 BSP with >4Gb memory. > > If this is explanation okay for you, I'll proceed with a v2 splitting off > the DT bindings documentation. Thanks for the explanation. I think it would be good to proceed with a v2. ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support 2016-11-24 14:25 ` Chris Paterson 2016-11-24 14:32 ` Simon Horman @ 2016-11-24 16:41 ` Geert Uytterhoeven 2016-11-24 17:12 ` Chris Paterson 1 sibling, 1 reply; 15+ messages in thread From: Geert Uytterhoeven @ 2016-11-24 16:41 UTC (permalink / raw) To: linux-arm-kernel Hi Chris, On Thu, Nov 24, 2016 at 3:25 PM, Chris Paterson <Chris.Paterson2@renesas.com> wrote: > From: Simon Horman [mailto:horms at verge.net.au] > Sent: 24 November 2016 10:18 >> On Thu, Nov 24, 2016 at 10:05:08AM +0000, Chris Paterson wrote: >> > From: Simon Horman [mailto:horms at verge.net.au] >> > > Regarding the arch/arm64/boot/dts/renesas/ portion, I would like >> > > some consideration given to what effect enabling memory above 4Gb >> > > (64bit >> > > addressing) would have. >> > >> > Can you give me some guidance here? I'm not sure what you're referring >> > to. As far as I know the DT reg definition here is 64-bit, or are you >> > referring to DMA usage? If the later, neither CAN driver uses DMA. >> >> Sorry for not being clearer. >> >> What I would like to know is if there are any problems in the CAN driver or >> hardware that would prevent it from functioning with memory that requires >> 64bit addressing present. >> >> If the CAN hardware cannot use DMA then DMA doesn't need to be taken >> into account. But if it DMA could be enabled in future for CAN, for example >> after some driver enhancements, then it would be good to know if 64bit >> memory can be supported - if not it would imply DMA cannot be enabled. > > Thank you for the clarification. > > The CAN interface for r8a7795/6 does not support DMA. > > With CAN FD there is currently a H/W issue that means DMA is unusable. Is that issue present on R-Car M3-W, or only on R-Car H3 ES1.x? > Potentially this issue could be fixed in the future and DMA support could > be added to the driver. If this happens I can see no reason why the CAN FD > IP wouldn't be able to handle DMA transfers when using 64bit addressing. Yep, AFAIK it uses SYS-DMAC, which supports 64-bit addressing. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support 2016-11-24 16:41 ` Geert Uytterhoeven @ 2016-11-24 17:12 ` Chris Paterson 0 siblings, 0 replies; 15+ messages in thread From: Chris Paterson @ 2016-11-24 17:12 UTC (permalink / raw) To: linux-arm-kernel Hello Geert, From: geert.uytterhoeven@gmail.com Sent: 24 November 2016 16:42 > Hi Chris, > > On Thu, Nov 24, 2016 at 3:25 PM, Chris Paterson > <Chris.Paterson2@renesas.com> wrote: > > From: Simon Horman [mailto:horms at verge.net.au] > > Sent: 24 November 2016 10:18 > >> On Thu, Nov 24, 2016 at 10:05:08AM +0000, Chris Paterson wrote: > >> > From: Simon Horman [mailto:horms at verge.net.au] > >> > > Regarding the arch/arm64/boot/dts/renesas/ portion, I would like > >> > > some consideration given to what effect enabling memory above 4Gb > >> > > (64bit > >> > > addressing) would have. > >> > > >> > Can you give me some guidance here? I'm not sure what you're > >> > referring to. As far as I know the DT reg definition here is > >> > 64-bit, or are you referring to DMA usage? If the later, neither CAN > driver uses DMA. > >> > >> Sorry for not being clearer. > >> > >> What I would like to know is if there are any problems in the CAN > >> driver or hardware that would prevent it from functioning with memory > >> that requires 64bit addressing present. > >> > >> If the CAN hardware cannot use DMA then DMA doesn't need to be > taken > >> into account. But if it DMA could be enabled in future for CAN, for > >> example after some driver enhancements, then it would be good to know > >> if 64bit memory can be supported - if not it would imply DMA cannot be > enabled. > > > > Thank you for the clarification. > > > > The CAN interface for r8a7795/6 does not support DMA. > > > > With CAN FD there is currently a H/W issue that means DMA is unusable. > > Is that issue present on R-Car M3-W, or only on R-Car H3 ES1.x? Both > > > Potentially this issue could be fixed in the future and DMA support > > could be added to the driver. If this happens I can see no reason why > > the CAN FD IP wouldn't be able to handle DMA transfers when using 64bit > addressing. > > Yep, AFAIK it uses SYS-DMAC, which supports 64-bit addressing. Yep > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support 2016-11-23 12:14 [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support Chris Paterson 2016-11-23 13:18 ` Marc Kleine-Budde @ 2016-11-24 16:13 ` Chris Paterson 2016-11-24 16:13 ` [PATCH v2 1/3] arm64: dts: r8a7796: Add CAN external clock support Chris Paterson ` (3 more replies) 1 sibling, 4 replies; 15+ messages in thread From: Chris Paterson @ 2016-11-24 16:13 UTC (permalink / raw) To: linux-arm-kernel This series adds CAN and CAN FD support to the r8a7796. Changes since v1: - Split device tree changes from bindings documentation. - Rebased on renesas-devel-20161123v2-v4.9-rc6. Chris Paterson (3): arm64: dts: r8a7796: Add CAN external clock support arm64: dts: r8a7796: Add CAN support arm64: dts: r8a7796: Add CAN FD support arch/arm64/boot/dts/renesas/r8a7796.dtsi | 61 ++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) -- 1.9.1 ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH v2 1/3] arm64: dts: r8a7796: Add CAN external clock support 2016-11-24 16:13 ` [PATCH v2 " Chris Paterson @ 2016-11-24 16:13 ` Chris Paterson 2016-11-24 16:13 ` [PATCH v2 2/3] arm64: dts: r8a7796: Add CAN support Chris Paterson ` (2 subsequent siblings) 3 siblings, 0 replies; 15+ messages in thread From: Chris Paterson @ 2016-11-24 16:13 UTC (permalink / raw) To: linux-arm-kernel Adds external CAN clock node for r8a7796. This clock can be used as fCAN clock of CAN and CAN FD controller. Based on a patch for r8a7795 by Ramesh Shanmugasundaram. Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index c34c684..61d165b 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi @@ -69,6 +69,13 @@ clock-frequency = <0>; }; + /* External CAN clock - to be overridden by boards that provide it */ + can_clk: can { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <0>; + }; + /* External SCIF clock - to be overridden by boards that provide it */ scif_clk: scif { compatible = "fixed-clock"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 2/3] arm64: dts: r8a7796: Add CAN support 2016-11-24 16:13 ` [PATCH v2 " Chris Paterson 2016-11-24 16:13 ` [PATCH v2 1/3] arm64: dts: r8a7796: Add CAN external clock support Chris Paterson @ 2016-11-24 16:13 ` Chris Paterson 2016-11-24 16:13 ` [PATCH v2 3/3] arm64: dts: r8a7796: Add CAN FD support Chris Paterson 2016-11-25 7:48 ` [PATCH v2 0/3] arm64: dts: r8a7796: Add CAN/CAN " Simon Horman 3 siblings, 0 replies; 15+ messages in thread From: Chris Paterson @ 2016-11-24 16:13 UTC (permalink / raw) To: linux-arm-kernel Adds CAN controller nodes for r8a7796. Based on a patch for r8a7795 by Ramesh Shanmugasundaram. Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index 61d165b..47fa29c 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi @@ -362,6 +362,36 @@ status = "disabled"; }; + can0: can at e6c30000 { + compatible = "renesas,can-r8a7796", + "renesas,rcar-gen3-can"; + reg = <0 0xe6c30000 0 0x1000>; + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 916>, + <&cpg CPG_CORE R8A7796_CLK_CANFD>, + <&can_clk>; + clock-names = "clkp1", "clkp2", "can_clk"; + assigned-clocks = <&cpg CPG_CORE R8A7796_CLK_CANFD>; + assigned-clock-rates = <40000000>; + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; + status = "disabled"; + }; + + can1: can at e6c38000 { + compatible = "renesas,can-r8a7796", + "renesas,rcar-gen3-can"; + reg = <0 0xe6c38000 0 0x1000>; + interrupts = <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 915>, + <&cpg CPG_CORE R8A7796_CLK_CANFD>, + <&can_clk>; + clock-names = "clkp1", "clkp2", "can_clk"; + assigned-clocks = <&cpg CPG_CORE R8A7796_CLK_CANFD>; + assigned-clock-rates = <40000000>; + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; + status = "disabled"; + }; + scif2: serial at e6e88000 { compatible = "renesas,scif-r8a7796", "renesas,rcar-gen3-scif", "renesas,scif"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 3/3] arm64: dts: r8a7796: Add CAN FD support 2016-11-24 16:13 ` [PATCH v2 " Chris Paterson 2016-11-24 16:13 ` [PATCH v2 1/3] arm64: dts: r8a7796: Add CAN external clock support Chris Paterson 2016-11-24 16:13 ` [PATCH v2 2/3] arm64: dts: r8a7796: Add CAN support Chris Paterson @ 2016-11-24 16:13 ` Chris Paterson 2016-11-25 7:48 ` [PATCH v2 0/3] arm64: dts: r8a7796: Add CAN/CAN " Simon Horman 3 siblings, 0 replies; 15+ messages in thread From: Chris Paterson @ 2016-11-24 16:13 UTC (permalink / raw) To: linux-arm-kernel Adds CAN FD controller node for r8a7796. Based on a patch for r8a7795 by Ramesh Shanmugasundaram. Signed-off-by: Chris Paterson <chris.paterson2@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> --- arch/arm64/boot/dts/renesas/r8a7796.dtsi | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi index 47fa29c..1ed1886 100644 --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi @@ -392,6 +392,30 @@ status = "disabled"; }; + canfd: can at e66c0000 { + compatible = "renesas,r8a7796-canfd", + "renesas,rcar-gen3-canfd"; + reg = <0 0xe66c0000 0 0x8000>; + interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 914>, + <&cpg CPG_CORE R8A7796_CLK_CANFD>, + <&can_clk>; + clock-names = "fck", "canfd", "can_clk"; + assigned-clocks = <&cpg CPG_CORE R8A7796_CLK_CANFD>; + assigned-clock-rates = <40000000>; + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>; + status = "disabled"; + + channel0 { + status = "disabled"; + }; + + channel1 { + status = "disabled"; + }; + }; + scif2: serial at e6e88000 { compatible = "renesas,scif-r8a7796", "renesas,rcar-gen3-scif", "renesas,scif"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH v2 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support 2016-11-24 16:13 ` [PATCH v2 " Chris Paterson ` (2 preceding siblings ...) 2016-11-24 16:13 ` [PATCH v2 3/3] arm64: dts: r8a7796: Add CAN FD support Chris Paterson @ 2016-11-25 7:48 ` Simon Horman 3 siblings, 0 replies; 15+ messages in thread From: Simon Horman @ 2016-11-25 7:48 UTC (permalink / raw) To: linux-arm-kernel On Thu, Nov 24, 2016 at 04:13:38PM +0000, Chris Paterson wrote: > This series adds CAN and CAN FD support to the r8a7796. > > Changes since v1: > - Split device tree changes from bindings documentation. > - Rebased on renesas-devel-20161123v2-v4.9-rc6. > > > Chris Paterson (3): > arm64: dts: r8a7796: Add CAN external clock support > arm64: dts: r8a7796: Add CAN support > arm64: dts: r8a7796: Add CAN FD support Thanks Chris, I have queued these up for v4.11 in the devel branch of the renesas tree. ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2016-11-25 7:48 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-11-23 12:14 [PATCH 0/3] arm64: dts: r8a7796: Add CAN/CAN FD support Chris Paterson 2016-11-23 13:18 ` Marc Kleine-Budde 2016-11-23 14:29 ` Simon Horman 2016-11-23 14:31 ` Marc Kleine-Budde 2016-11-24 10:05 ` Chris Paterson 2016-11-24 10:17 ` Simon Horman 2016-11-24 14:25 ` Chris Paterson 2016-11-24 14:32 ` Simon Horman 2016-11-24 16:41 ` Geert Uytterhoeven 2016-11-24 17:12 ` Chris Paterson 2016-11-24 16:13 ` [PATCH v2 " Chris Paterson 2016-11-24 16:13 ` [PATCH v2 1/3] arm64: dts: r8a7796: Add CAN external clock support Chris Paterson 2016-11-24 16:13 ` [PATCH v2 2/3] arm64: dts: r8a7796: Add CAN support Chris Paterson 2016-11-24 16:13 ` [PATCH v2 3/3] arm64: dts: r8a7796: Add CAN FD support Chris Paterson 2016-11-25 7:48 ` [PATCH v2 0/3] arm64: dts: r8a7796: Add CAN/CAN " Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).