public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: ck.hu@mediatek.com (CK Hu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 10/13] drm/mediatek: add dsi ulp mode control
Date: Thu, 1 Dec 2016 09:10:40 +0800	[thread overview]
Message-ID: <1480554640.25380.4.camel@mtksdaap41> (raw)
In-Reply-To: <1480070076-6196-11-git-send-email-yt.shen@mediatek.com>

Hi, YT:

On Fri, 2016-11-25 at 18:34 +0800, YT Shen wrote:
> modify dsi enter ultra low power mode method
> 

This looks like a power-saving patch. I think without this, MT2701 could
still work correctly. The commit message is too simple, please describe
why this patch is related to MT2701. If it is not related to MT2701,
move this patch out of MT2701 series and send it independently.

Regards,
CK

> Signed-off-by: shaoming chen <shaoming.chen@mediatek.com>
> Signed-off-by: YT Shen <yt.shen@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index d03a0f1..01df829 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -289,7 +289,7 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi)
>  static void mtk_dsi_clk_ulp_mode_enter(struct mtk_dsi *dsi)
>  {
>  	mtk_dsi_mask(dsi, DSI_PHY_LCCON, LC_HS_TX_EN, 0);
> -	mtk_dsi_mask(dsi, DSI_PHY_LCCON, LC_ULPM_EN, 0);
> +	mtk_dsi_mask(dsi, DSI_PHY_LCCON, LC_ULPM_EN, LC_ULPM_EN);
>  }
>  
>  static void mtk_dsi_clk_ulp_mode_leave(struct mtk_dsi *dsi)
> @@ -302,7 +302,7 @@ static void mtk_dsi_clk_ulp_mode_leave(struct mtk_dsi *dsi)
>  static void mtk_dsi_lane0_ulp_mode_enter(struct mtk_dsi *dsi)
>  {
>  	mtk_dsi_mask(dsi, DSI_PHY_LD0CON, LD0_HS_TX_EN, 0);
> -	mtk_dsi_mask(dsi, DSI_PHY_LD0CON, LD0_ULPM_EN, 0);
> +	mtk_dsi_mask(dsi, DSI_PHY_LD0CON, LD0_ULPM_EN, LD0_ULPM_EN);
>  }
>  
>  static void mtk_dsi_lane0_ulp_mode_leave(struct mtk_dsi *dsi)

  reply	other threads:[~2016-12-01  1:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25 10:34 [PATCH v10 00/13] MT2701 DRM support YT Shen
2016-11-25 10:34 ` [PATCH v10 01/13] drm/mediatek: add helpers for coverting from the generic components YT Shen
2016-11-25 10:34 ` [PATCH v10 02/13] drm/mediatek: add *driver_data for different hardware settings YT Shen
2016-11-30  6:42   ` Daniel Kurtz
2016-12-05 12:50     ` YT Shen
2016-11-25 10:34 ` [PATCH v10 03/13] drm/mediatek: add shadow register support YT Shen
2016-11-25 10:34 ` [PATCH v10 04/13] drm/mediatek: add BLS component YT Shen
2016-11-25 10:34 ` [PATCH v10 05/13] drm/mediatek: update display module connections YT Shen
2016-11-25 10:34 ` [PATCH v10 06/13] drm/mediatek: cleaning up and refine YT Shen
2016-11-25 10:34 ` [PATCH v10 07/13] drm/mediatek: add dsi interrupt control YT Shen
2016-11-25 10:34 ` [PATCH v10 08/13] drm/mediatek: add dsi transfer function YT Shen
2016-11-25 10:34 ` [PATCH v10 09/13] drm/mediatek: add mipi_tx data rate check YT Shen
2016-11-30 11:05   ` CK Hu
2016-11-25 10:34 ` [PATCH v10 10/13] drm/mediatek: add dsi ulp mode control YT Shen
2016-12-01  1:10   ` CK Hu [this message]
2016-11-25 10:34 ` [PATCH v10 11/13] drm/mediatek: add dsi rxtx control YT Shen
2016-11-30 10:47   ` CK Hu
2016-11-25 10:34 ` [PATCH v10 12/13] drm/mediatek: update DSI sub driver flow for sending commands to panel YT Shen
2016-11-30  7:58   ` CK Hu
2016-12-05 12:43     ` YT Shen
2016-11-25 10:34 ` [PATCH v10 13/13] drm/mediatek: add support for Mediatek SoC MT2701 YT Shen
2016-11-30 14:03   ` Matthias Brugger
2016-12-05 13:01     ` YT Shen
2016-11-30  8:59 ` [PATCH v10 00/13] MT2701 DRM support CK Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480554640.25380.4.camel@mtksdaap41 \
    --to=ck.hu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox