From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Mon, 06 Jul 2015 21:07:49 +0200 Subject: [PATCH] thermal: consistently use int for temperatures In-Reply-To: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> References: <1436167189-29835-1-git-send-email-s.hauer@pengutronix.de> Message-ID: <14808775.AMIXvBTC8g@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Montag, 6. Juli 2015, 09:19:49 schrieb Sascha Hauer: > The thermal code uses int, long and unsigned long for temperatures > in different places. > > Using an unsigned type limits the thermal framework to positive > temperatures without need. Also several drivers currently will report > temperatures near UINT_MAX for temperatures below 0?C. This will probably > immediately shut the machine down due to overtemperature if started below > 0?C. > > 'long' is 64bit on several architectures. This is not needed since INT_MAX > ?mC is above the melting point of all known materials. > > Consistently use a plain 'int' for temperatures throughout the thermal code > and the drivers. This only changes the places in the drivers where the > temperature is passed around as pointer, when drivers internally use > another type this is not changed. > > Signed-off-by: Sascha Hauer > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: linux-pm at vger.kernel.org > Cc: linux-kernel at vger.kernel.org > Cc: Jean Delvare > Cc: Peter Feuerer > Cc: Heiko Stuebner > Cc: Lukasz Majewski > Cc: Stephen Warren > Cc: Thierry Reding > Cc: linux-acpi at vger.kernel.org > Cc: platform-driver-x86 at vger.kernel.org > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-omap at vger.kernel.org > Cc: linux-samsung-soc at vger.kernel.org > Cc: Guenter Roeck > Cc: Rafael J. Wysocki > Cc: Maxime Ripard > Cc: Darren Hart > Cc: lm-sensors at lm-sensors.org > --- For > drivers/thermal/rockchip_thermal.c | 10 ++++---- Reviewed-by: Heiko Stuebner