From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Stefan Hansson <newbyte@postmarketos.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, matti.lehtimaki@gmail.com
Subject: Re: [PATCH 2/3] dt-bindings: arm: qcom: Add MSM8926 and Samsung Galaxy Tab 4 10.1 LTE
Date: Mon, 23 Jan 2023 18:11:42 +0100 [thread overview]
Message-ID: <1481d44d-f84c-db12-d95d-75f367e973de@linaro.org> (raw)
In-Reply-To: <f67b23e8-a476-7f8c-b692-e85ebbe669f5@linaro.org>
On 23/01/2023 18:10, Krzysztof Kozlowski wrote:
> On 22/01/2023 15:47, Stefan Hansson wrote:
>> MSM8926 (also known as Snapdragon 400) is very similar to MSM8226 and
>> APQ8026 with the primary difference being that it features an LTE modem
>> unlike the former two which feature a 3G modem and a GPS-only modem,
>> respectively.
>>
>> This also documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte)
>> which is a tablet by Samsung based on the MSM8926 SoC.
>>
>> Signed-off-by: Stefan Hansson <newbyte@postmarketos.org>
>> ---
>> Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 47913a8e3eea..7a0b2088ead9 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -35,6 +35,7 @@ description: |
>> mdm9615
>> msm8226
>> msm8916
>> + msm8926
>> msm8953
>> msm8956
>> msm8974
>> @@ -219,6 +220,11 @@ properties:
>> - const: qcom,msm8916-v1-qrd/9-v1
>> - const: qcom,msm8916
>>
>> + - items:
>> + - enum:
>> + - samsung,matisselte
>
> 1. matisse is the code name, lte is version/suffix. I don't think they
> should be together, because then it looks like "matisselte" is a name.
> It actually sounds like one word.
Update: there is already matisse-wifi, so please follow the same naming
convention. Version suffix should be separated with hyphen.
>
> 2. You base on other SoC but you do not include its compatibles. Why? Is
> it intended? None of the properties applicable to other SoC will match
> here, thus I actually wonder if you run dtbs_check...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-01-23 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 14:47 [PATCH 0/3] Add samsung-matisselte and common matisse dtsi Stefan Hansson
2023-01-22 14:47 ` [PATCH 1/3] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree Stefan Hansson
2023-01-23 17:15 ` Krzysztof Kozlowski
2023-01-22 14:47 ` [PATCH 2/3] dt-bindings: arm: qcom: Add MSM8926 and Samsung Galaxy Tab 4 10.1 LTE Stefan Hansson
2023-01-23 17:10 ` Krzysztof Kozlowski
2023-01-23 17:11 ` Krzysztof Kozlowski [this message]
2023-01-23 17:41 ` Stefan Hansson
2023-01-23 18:08 ` Krzysztof Kozlowski
2023-01-28 21:43 ` Luca Weiss
2023-01-29 10:55 ` Krzysztof Kozlowski
2023-01-22 14:47 ` [PATCH 3/3] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE (SM-T535) Stefan Hansson
2023-01-23 16:48 ` Konrad Dybcio
2023-01-23 16:50 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481d44d-f84c-db12-d95d-75f367e973de@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.lehtimaki@gmail.com \
--cc=newbyte@postmarketos.org \
--cc=olof@lixom.net \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).