From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 253CFC05027 for ; Mon, 23 Jan 2023 17:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vABNsbVSC+EKDaChU0rBGCc3I1Rs6QSjMvj4jBeEYIc=; b=H4bVF/zPtqO1Gq V8yu2zqDxZJaaoMnCRywIIVwP3ssbw5o9F0BXC2h5uRiRXbxQ+cnAujsJAYD+NUt5HnpuLE4HIP43 z2yxd2Y7KSKi1qVheZ7AfA5zbb0Ka7LobBU1dSLlVsiiETunUhrrzuSjZFTj0t2MmyhjaDaqjR68p HCQ7ivi0lsxbo6LfYHpoo54y9GijujBBQPeCjZ58tdeHLRWZPgUQCbAV1u9pCjR7FpUWJgFaiXRm0 zdPBhFhjiHT1JnEAXtTUGCFS60iHePr9mVxas1z+ZOFeIJ66QCMtag5zlMZmlDaIOABnJ9fNFeluS uGQoMgOQ3G5EcznKiuNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pK0MJ-000mTQ-QO; Mon, 23 Jan 2023 17:11:51 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pK0MG-000mS0-GV for linux-arm-kernel@lists.infradead.org; Mon, 23 Jan 2023 17:11:49 +0000 Received: by mail-wm1-x335.google.com with SMTP id c10-20020a05600c0a4a00b003db0636ff84so9132094wmq.0 for ; Mon, 23 Jan 2023 09:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=w/1n6Rnx67kZYArlthTKZLtXubhv3HxF61v2sHJZdtI=; b=D6mCK+sNgyqI8k7P3xFY+QAzdy/QUXCsgKTvL9iznmaCEiA8KTzPZ2mFBeVub9/7Q6 a7EDMeXOn8It3e3nKAuHDlTRpXllRzGRE9CN1T8MqH5ig1cE4lEukqZgSIrYzq7Sue9P P+iYYOAmc7TdAMF4plYPtU91tT+ZzVXkJKlxdOh/9t9/QU+5GTtOCDTuNgultTH2OUFp q6QVQ1cSNcSW2lmIzKW4BE96j6q5j2qTgpp8g2D2c2mnllwMBA3fCFB+7ZKl4/FykDC9 OjApyeqiDR6rvBTdmkmCDFDbdsYEL/ll4bBjkrQqQYskcjbtrj7PDLdsmYy3U7h1iHnm AkOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w/1n6Rnx67kZYArlthTKZLtXubhv3HxF61v2sHJZdtI=; b=ohtZAbl13s3C0KVXRyAbUrXevahcAPEzdTcfgzQrfUHis44J94Mvm6bBJGjb3h2NZq jMghH9Vt/gKWHddoBzcfaDkPXyJjB8049OL2wWc7JVlC0QJ1OjW0Rq+BWMyPz9Zx1V9T iE4nXwM4ukdm3XT8kSrDYzV62aKXAM6bfxcIFekNAogPsVxGEi3DskxJK1HYmtSZL+yK QudnvWMeIUW6CcoU6wlFP13jN/pT2SD4WbMjzuuFxSWQm4V+JK3V3xg6j+o7d6WnnQ88 xVyDHz2ca89MgZFyrvNUjlHfy9BEgLFFpV9SAgKzpsWXAtJaf8mBnbbn1K55aeT3lG8y HlVg== X-Gm-Message-State: AFqh2kq861hWqwhdzqfcX/6csVPjjoaMeC08VGT4DkRWVS4g7rJ+ZUdp EC0/7wGgrtwWL/n3GYMkBHpTnA== X-Google-Smtp-Source: AMrXdXtGdUeLHbnaS4hmtb2SyIomWK0GV8Cd02EvA/qIDnUsl5zN96cLh5XItAyRcUDAWCzJAsB44Q== X-Received: by 2002:a1c:7312:0:b0:3d2:3eda:dd1 with SMTP id d18-20020a1c7312000000b003d23eda0dd1mr23603852wmb.17.1674493904926; Mon, 23 Jan 2023 09:11:44 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h11-20020a05600c314b00b003db2e3f2c7csm15249768wmo.0.2023.01.23.09.11.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 09:11:44 -0800 (PST) Message-ID: <1481d44d-f84c-db12-d95d-75f367e973de@linaro.org> Date: Mon, 23 Jan 2023 18:11:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 2/3] dt-bindings: arm: qcom: Add MSM8926 and Samsung Galaxy Tab 4 10.1 LTE Content-Language: en-US From: Krzysztof Kozlowski To: Stefan Hansson , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, matti.lehtimaki@gmail.com References: <20230122144749.87597-1-newbyte@postmarketos.org> <20230122144749.87597-3-newbyte@postmarketos.org> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230123_091148_578381_2102072A X-CRM114-Status: GOOD ( 17.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/01/2023 18:10, Krzysztof Kozlowski wrote: > On 22/01/2023 15:47, Stefan Hansson wrote: >> MSM8926 (also known as Snapdragon 400) is very similar to MSM8226 and >> APQ8026 with the primary difference being that it features an LTE modem >> unlike the former two which feature a 3G modem and a GPS-only modem, >> respectively. >> >> This also documents Samsung Galaxy Tab 4 10.1 LTE (samsung,matisselte) >> which is a tablet by Samsung based on the MSM8926 SoC. >> >> Signed-off-by: Stefan Hansson >> --- >> Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml >> index 47913a8e3eea..7a0b2088ead9 100644 >> --- a/Documentation/devicetree/bindings/arm/qcom.yaml >> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml >> @@ -35,6 +35,7 @@ description: | >> mdm9615 >> msm8226 >> msm8916 >> + msm8926 >> msm8953 >> msm8956 >> msm8974 >> @@ -219,6 +220,11 @@ properties: >> - const: qcom,msm8916-v1-qrd/9-v1 >> - const: qcom,msm8916 >> >> + - items: >> + - enum: >> + - samsung,matisselte > > 1. matisse is the code name, lte is version/suffix. I don't think they > should be together, because then it looks like "matisselte" is a name. > It actually sounds like one word. Update: there is already matisse-wifi, so please follow the same naming convention. Version suffix should be separated with hyphen. > > 2. You base on other SoC but you do not include its compatibles. Why? Is > it intended? None of the properties applicable to other SoC will match > here, thus I actually wonder if you run dtbs_check... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel