From: lilja.magnus@gmail.com (Magnus Lilja)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mfd: mc13xxx: Pass the IRQF_TRIGGER_HIGH flag.
Date: Mon, 19 Dec 2016 22:28:54 +0100 [thread overview]
Message-ID: <1482182934-18559-3-git-send-email-lilja.magnus@gmail.com> (raw)
In-Reply-To: <1482182934-18559-1-git-send-email-lilja.magnus@gmail.com>
All supported mc13xxx devices have active high interrupt outputs. Make sure
to configure the interrupt as active high by passing the IRQF_TRIGGER_HIGH
flag. This is required at least on the i.MX31 PDK board.
Signed-off-by: Magnus Lilja <lilja.magnus@gmail.com>
---
drivers/mfd/mc13xxx-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
index d7f54e4..4cbe6b7 100644
--- a/drivers/mfd/mc13xxx-core.c
+++ b/drivers/mfd/mc13xxx-core.c
@@ -440,7 +440,7 @@ int mc13xxx_common_init(struct device *dev)
mc13xxx->irq_chip.irqs = mc13xxx->irqs;
mc13xxx->irq_chip.num_irqs = ARRAY_SIZE(mc13xxx->irqs);
- ret = regmap_add_irq_chip(mc13xxx->regmap, mc13xxx->irq, IRQF_ONESHOT,
+ ret = regmap_add_irq_chip(mc13xxx->regmap, mc13xxx->irq, IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
0, &mc13xxx->irq_chip, &mc13xxx->irq_data);
if (ret)
return ret;
--
2.7.4
next prev parent reply other threads:[~2016-12-19 21:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 21:28 [PATCH 0/2] Patches to make i.MX31 PDK board boot again Magnus Lilja
2016-12-19 21:28 ` [PATCH 1/2] i.MX31: ipu: Make sure the interrupt routine checks all interrupts Magnus Lilja
2016-12-21 20:08 ` Fabio Estevam
2016-12-21 20:19 ` Magnus Lilja
2016-12-19 21:28 ` Magnus Lilja [this message]
2016-12-20 5:20 ` [PATCH 2/2] mfd: mc13xxx: Pass the IRQF_TRIGGER_HIGH flag Alexander Shiyan
2016-12-20 19:35 ` Magnus Lilja
2016-12-21 6:00 ` Alexander Shiyan
2016-12-21 19:41 ` Magnus Lilja
2016-12-21 20:24 ` Vladimir Zapolskiy
2016-12-21 20:28 ` Fabio Estevam
2016-12-22 1:08 ` Vladimir Zapolskiy
2016-12-22 20:16 ` Magnus Lilja
2016-12-24 13:21 ` Fabio Estevam
2017-05-27 16:25 ` Fabio Estevam
2016-12-21 20:10 ` Fabio Estevam
2016-12-21 20:20 ` Magnus Lilja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482182934-18559-3-git-send-email-lilja.magnus@gmail.com \
--to=lilja.magnus@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).