From: yong.wu@mediatek.com (Yong Wu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu: Drop the of_iommu_{set/get}_ops() interface
Date: Fri, 6 Jan 2017 14:46:04 +0800 [thread overview]
Message-ID: <1483685164.3334.3.camel@mhfsdcap03> (raw)
In-Reply-To: <c61db43c-82b1-b4c9-63cb-a8c78878cb39@arm.com>
On Wed, 2017-01-04 at 15:11 +0000, Robin Murphy wrote:
> [+Yong Wu for mtk_iommu]
>
> On 03/01/17 17:34, Lorenzo Pieralisi wrote:
> > With the introduction of the new iommu_{register/get}_instance()
> > interface in commit e4f10ffe4c9b ("iommu: Make of_iommu_set/get_ops() DT
> > agnostic") (based on struct fwnode_handle as look-up token, so firmware
> > agnostic) to register IOMMU instances with the core IOMMU layer there is
> > no reason to keep the old OF based interface around any longer.
> >
> > Convert all the IOMMU drivers (and OF IOMMU core code) that rely on the
> > of_iommu_{set/get}_ops() to the new kernel interface to register/retrieve
> > IOMMU instances and remove the of_iommu_{set/get}_ops() remaining glue
> > code in order to complete the interface rework.
>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
>
> Looking at before-and-after disassemblies, of_iommu.o is binary
> identical, and exynos-iommu.o differs only in the use of dev->fwnode
> rather than &dev->of_node->fwnode (and is binary identical if I hack it
> back to the latter). I'm not sure why the (GCC 6.2) codegen for
> mtk_iommu.o changes quite so much when merely replacing a callsite with
> the contents of its static inline callee, but it does :/
>
> Robin.
>
For MTK IOMMU,
Tested-by: Yong Wu <yong.wu@mediatek.com>
Thanks.
next prev parent reply other threads:[~2017-01-06 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170103173514epcas4p42d343054cc7117c7299ca7bfad0015af@epcas4p4.samsung.com>
2017-01-03 17:34 ` [PATCH] iommu: Drop the of_iommu_{set/get}_ops() interface Lorenzo Pieralisi
2017-01-04 8:00 ` Sricharan
2017-01-04 15:11 ` Robin Murphy
2017-01-06 6:46 ` Yong Wu [this message]
2017-01-04 15:19 ` Will Deacon
2017-01-09 8:11 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483685164.3334.3.camel@mhfsdcap03 \
--to=yong.wu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).