public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 08/13] pinctrl: samsung: Remove dead code
Date: Tue, 17 Jan 2017 13:44:39 +0100	[thread overview]
Message-ID: <1484657084-26227-9-git-send-email-m.szyprowski@samsung.com> (raw)
In-Reply-To: <1484657084-26227-1-git-send-email-m.szyprowski@samsung.com>

'enable' parameter has been removed a while ago, so all code for handling
it can be simply removed.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Tomasz Figa <tomasz.figa@gmail.com>
---
 drivers/pinctrl/samsung/pinctrl-samsung.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
index 10b3fd826231..2803ae57f373 100644
--- a/drivers/pinctrl/samsung/pinctrl-samsung.c
+++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
@@ -350,7 +350,7 @@ static void pin_to_reg_bank(struct samsung_pinctrl_drv_data *drvdata,
 
 /* enable or disable a pinmux function */
 static void samsung_pinmux_setup(struct pinctrl_dev *pctldev, unsigned selector,
-					unsigned group, bool enable)
+					unsigned group)
 {
 	struct samsung_pinctrl_drv_data *drvdata;
 	const struct samsung_pin_bank_type *type;
@@ -380,8 +380,7 @@ static void samsung_pinmux_setup(struct pinctrl_dev *pctldev, unsigned selector,
 
 	data = readl(reg + type->reg_offset[PINCFG_TYPE_FUNC]);
 	data &= ~(mask << shift);
-	if (enable)
-		data |= func->val << shift;
+	data |= func->val << shift;
 	writel(data, reg + type->reg_offset[PINCFG_TYPE_FUNC]);
 
 	spin_unlock_irqrestore(&bank->slock, flags);
@@ -392,7 +391,7 @@ static int samsung_pinmux_set_mux(struct pinctrl_dev *pctldev,
 				  unsigned selector,
 				  unsigned group)
 {
-	samsung_pinmux_setup(pctldev, selector, group, true);
+	samsung_pinmux_setup(pctldev, selector, group);
 	return 0;
 }
 
-- 
1.9.1

  parent reply	other threads:[~2017-01-17 12:44 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170117124453eucas1p1b812596939db4c4f3298b941555eb05a@eucas1p1.samsung.com>
2017-01-17 12:44 ` [PATCH v2 00/13] Move pad retention control to Exynos pin controller driver Marek Szyprowski
2017-01-17 12:44   ` [PATCH v2 01/13] soc: samsung: pmu: Provide global function to get PMU regmap Marek Szyprowski
2017-01-18  8:31     ` Tomasz Figa
2017-01-17 12:44   ` [PATCH v2 02/13] soc: samsung: pmu: Use of_device_get_match_data helper Marek Szyprowski
2017-01-17 12:44   ` [PATCH v2 03/13] soc: samsung: pmu: Remove messages for failed memory allocation Marek Szyprowski
2017-01-17 12:44   ` [PATCH v2 04/13] pinctrl: samsung: Document Exynos3250 SoC support Marek Szyprowski
2017-01-17 12:44   ` [PATCH v2 05/13] pinctrl: samsung: Remove messages for failed memory allocation Marek Szyprowski
2017-01-17 12:44   ` [PATCH v2 06/13] pinctrl: samsung: Fix samsung_pinctrl_create_functions return value Marek Szyprowski
2017-01-17 17:36     ` Krzysztof Kozlowski
2017-01-17 12:44   ` [PATCH v2 07/13] pinctrl: samsung: Add missing initconst annotation Marek Szyprowski
2017-01-17 12:44   ` Marek Szyprowski [this message]
2017-01-17 12:44   ` [PATCH v2 09/13] pinctrl: samsung: Use generic of_device_get_match_data helper Marek Szyprowski
2017-01-17 17:38     ` Krzysztof Kozlowski
2017-01-17 12:44   ` [PATCH v2 10/13] pinctrl: samsung: Add infrastructure for pin-bank retention control Marek Szyprowski
2017-01-18  8:36     ` Tomasz Figa
2017-01-17 12:44   ` [PATCH v2 11/13] pinctrl: samsung: Move retention control from mach-exynos to the pinctrl driver Marek Szyprowski
2017-01-17 17:48     ` Krzysztof Kozlowski
2017-01-17 12:44   ` [PATCH v2 12/13] pinctrl: samsung: Move retention control from mach-s5pv210 " Marek Szyprowski
2017-01-17 17:54     ` Krzysztof Kozlowski
2017-01-17 12:44   ` [PATCH v2 13/13] pinctrl: samsung: Replace syscore ops with standard platform device pm_ops Marek Szyprowski
2017-01-18  8:40   ` [PATCH v2 00/13] Move pad retention control to Exynos pin controller driver Tomasz Figa
2017-01-18 10:39   ` Linus Walleij
2017-01-18 12:06     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484657084-26227-9-git-send-email-m.szyprowski@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox