* [PATCH] ARM: DT: STiH407: Add RTS / CTS pinctrl definition for UARTs.
@ 2017-01-17 16:46 Peter Griffin
2017-01-18 9:23 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Peter Griffin @ 2017-01-17 16:46 UTC (permalink / raw)
To: linux-arm-kernel
The uart IP is capable of doing hardware flow control. Define
the RTS and CTS pins for STiH407 family Socs so we can use this
feature in the future if we wish to.
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
arch/arm/boot/dts/stih407-pinctrl.dtsi | 50 ++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
index daab16b..3bbb0c0 100644
--- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
@@ -149,6 +149,16 @@
rx = <&pio3 5 ALT1 IN>;
};
};
+ pinctrl_sbc_serial0_rts: sbc_serial0-0_rts {
+ st,pins {
+ rts = <&pio3 7 ALT1 OUT>;
+ };
+ };
+ pinctrl_sbc_serial0_cts: sbc_serial0-0_cts {
+ st,pins {
+ cts = <&pio3 6 ALT1 IN>;
+ };
+ };
};
/* SBC_ASC1 - UART11 */
sbc_serial1 {
@@ -158,6 +168,16 @@
rx = <&pio2 7 ALT3 IN>;
};
};
+ pinctrl_sbc_serial1_rts: sbc_serial1-0_rts {
+ st,pins {
+ rts = <&pio3 1 ALT3 OUT>;
+ };
+ };
+ pinctrl_sbc_serial1_cts: sbc_serial1-0_cts {
+ st,pins {
+ cts = <&pio3 0 ALT3 IN>;
+ };
+ };
};
i2c10 {
@@ -469,6 +489,16 @@
rx = <&pio17 1 ALT1 IN>;
};
};
+ pinctrl_serial0_rts: serial0-0_rts {
+ st,pins {
+ rts = <&pio17 3 ALT1 OUT>;
+ };
+ };
+ pinctrl_serial0_cts: serial0-0_cts {
+ st,pins {
+ cts = <&pio17 2 ALT1 IN>;
+ };
+ };
};
serial1 {
@@ -478,6 +508,16 @@
rx = <&pio16 1 ALT1 IN>;
};
};
+ pinctrl_serial1_rts: serial1-0_rts {
+ st,pins {
+ rts = <&pio16 3 ALT1 OUT>;
+ };
+ };
+ pinctrl_serial1_cts: serial1-0_cts {
+ st,pins {
+ cts = <&pio16 2 ALT1 IN>;
+ };
+ };
};
serial2 {
@@ -487,6 +527,16 @@
rx = <&pio15 1 ALT1 IN>;
};
};
+ pinctrl_serial2_rts: serial2-0_rts {
+ st,pins {
+ rts = <&pio15 3 ALT1 OUT>;
+ };
+ };
+ pinctrl_serial2_cts: serial2-0_cts {
+ st,pins {
+ cts = <&pio15 2 ALT1 IN>;
+ };
+ };
};
mmc1 {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: DT: STiH407: Add RTS / CTS pinctrl definition for UARTs.
2017-01-17 16:46 [PATCH] ARM: DT: STiH407: Add RTS / CTS pinctrl definition for UARTs Peter Griffin
@ 2017-01-18 9:23 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2017-01-18 9:23 UTC (permalink / raw)
To: linux-arm-kernel
Couple of nits and a question.
On Tue, 17 Jan 2017, Peter Griffin wrote:
> The uart IP is capable of doing hardware flow control. Define
UART
> the RTS and CTS pins for STiH407 family Socs so we can use this
SoCs
> feature in the future if we wish to.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> arch/arm/boot/dts/stih407-pinctrl.dtsi | 50 ++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index daab16b..3bbb0c0 100644
> --- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> @@ -149,6 +149,16 @@
> rx = <&pio3 5 ALT1 IN>;
> };
> };
> + pinctrl_sbc_serial0_rts: sbc_serial0-0_rts {
> + st,pins {
> + rts = <&pio3 7 ALT1 OUT>;
> + };
> + };
> + pinctrl_sbc_serial0_cts: sbc_serial0-0_cts {
> + st,pins {
> + cts = <&pio3 6 ALT1 IN>;
> + };
> + };
Basic premise looks good, but why have you separated the lines?
I believe they are used together when HW flow-control is enabled.
> };
> /* SBC_ASC1 - UART11 */
> sbc_serial1 {
> @@ -158,6 +168,16 @@
> rx = <&pio2 7 ALT3 IN>;
> };
> };
> + pinctrl_sbc_serial1_rts: sbc_serial1-0_rts {
> + st,pins {
> + rts = <&pio3 1 ALT3 OUT>;
> + };
> + };
> + pinctrl_sbc_serial1_cts: sbc_serial1-0_cts {
> + st,pins {
> + cts = <&pio3 0 ALT3 IN>;
> + };
> + };
> };
>
> i2c10 {
> @@ -469,6 +489,16 @@
> rx = <&pio17 1 ALT1 IN>;
> };
> };
> + pinctrl_serial0_rts: serial0-0_rts {
> + st,pins {
> + rts = <&pio17 3 ALT1 OUT>;
> + };
> + };
> + pinctrl_serial0_cts: serial0-0_cts {
> + st,pins {
> + cts = <&pio17 2 ALT1 IN>;
> + };
> + };
> };
>
> serial1 {
> @@ -478,6 +508,16 @@
> rx = <&pio16 1 ALT1 IN>;
> };
> };
> + pinctrl_serial1_rts: serial1-0_rts {
> + st,pins {
> + rts = <&pio16 3 ALT1 OUT>;
> + };
> + };
> + pinctrl_serial1_cts: serial1-0_cts {
> + st,pins {
> + cts = <&pio16 2 ALT1 IN>;
> + };
> + };
> };
>
> serial2 {
> @@ -487,6 +527,16 @@
> rx = <&pio15 1 ALT1 IN>;
> };
> };
> + pinctrl_serial2_rts: serial2-0_rts {
> + st,pins {
> + rts = <&pio15 3 ALT1 OUT>;
> + };
> + };
> + pinctrl_serial2_cts: serial2-0_cts {
> + st,pins {
> + cts = <&pio15 2 ALT1 IN>;
> + };
> + };
> };
>
> mmc1 {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-18 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-17 16:46 [PATCH] ARM: DT: STiH407: Add RTS / CTS pinctrl definition for UARTs Peter Griffin
2017-01-18 9:23 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).