linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: guohanjun@huawei.com (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 03/15] ACPI: IORT: minor cleanup for iort_match_node_callback()
Date: Wed, 18 Jan 2017 20:54:53 +0800	[thread overview]
Message-ID: <1484744105-53140-4-git-send-email-guohanjun@huawei.com> (raw)
In-Reply-To: <1484744105-53140-1-git-send-email-guohanjun@huawei.com>

From: Hanjun Guo <hanjun.guo@linaro.org>

Cleanup iort_match_node_callback() a little bit to reduce
some lines of code.

Signed-off-by: Hanjun Guo <hanjun.guo@linaro.org>
Tested-by: Ming Lei <ming.lei@canonical.com>
Tested-by: Wei Xu <xuwei5@hisilicon.com>
Tested-by: Sinan Kaya <okaya@codeaurora.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Tomasz Nowicki <tn@semihalf.com>
---
 drivers/acpi/arm64/iort.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
index 15f32bf..208eac9 100644
--- a/drivers/acpi/arm64/iort.c
+++ b/drivers/acpi/arm64/iort.c
@@ -253,17 +253,15 @@ static acpi_status iort_match_node_callback(struct acpi_iort_node *node,
 					    void *context)
 {
 	struct device *dev = context;
-	acpi_status status;
+	acpi_status status = AE_NOT_FOUND;
 
 	if (node->type == ACPI_IORT_NODE_NAMED_COMPONENT) {
 		struct acpi_buffer buf = { ACPI_ALLOCATE_BUFFER, NULL };
 		struct acpi_device *adev = to_acpi_device_node(dev->fwnode);
 		struct acpi_iort_named_component *ncomp;
 
-		if (!adev) {
-			status = AE_NOT_FOUND;
+		if (!adev)
 			goto out;
-		}
 
 		status = acpi_get_name(adev->handle, ACPI_FULL_PATHNAME, &buf);
 		if (ACPI_FAILURE(status)) {
@@ -289,8 +287,6 @@ static acpi_status iort_match_node_callback(struct acpi_iort_node *node,
 		 */
 		status = pci_rc->pci_segment_number == pci_domain_nr(bus) ?
 							AE_OK : AE_NOT_FOUND;
-	} else {
-		status = AE_NOT_FOUND;
 	}
 out:
 	return status;
-- 
1.7.12.4

  parent reply	other threads:[~2017-01-18 12:54 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 12:54 [PATCH v8 00/15] ACPI platform MSI support and its example mbigen Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 01/15] ACPI: IORT: fix the indentation in iort_scan_node() Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 02/15] ACPI: IORT: add missing comment for iort_dev_find_its_id() Hanjun Guo
2017-01-18 12:54 ` Hanjun Guo [this message]
2017-01-18 12:54 ` [PATCH v8 04/15] irqchip: gic-v3-its: keep the head file include in alphabetic order Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 05/15] irqchip: gicv3-its: platform-msi: refactor its_pmsi_prepare() Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 06/15] irqchip: gicv3-its: platform-msi: refactor its_pmsi_init() to prepare for ACPI Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 07/15] irqchip: gicv3-its: platform-msi: scan MADT to create platform msi domain Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 08/15] ACPI: IORT: rename iort_node_map_rid() to make it generic Hanjun Guo
2017-01-18 12:54 ` [PATCH v8 09/15] ACPI: IORT: introduce iort_node_map_platform_id() to retrieve dev id Hanjun Guo
2017-01-18 12:55 ` [PATCH v8 10/15] ACPI: platform-msi: retrieve dev id from IORT Hanjun Guo
2017-04-17 21:44   ` Sinan Kaya
2017-04-17 22:01     ` Sinan Kaya
2017-04-18  1:27       ` Hanjun Guo
2017-04-18  1:30         ` Sinan Kaya
2017-04-18  1:33           ` Hanjun Guo
2017-01-18 12:55 ` [PATCH v8 11/15] ACPI: platform: setup MSI domain for ACPI based platform device Hanjun Guo
2017-01-18 12:55 ` [PATCH v8 12/15] msi: platform: make platform_msi_create_device_domain() ACPI aware Hanjun Guo
2017-01-18 12:55 ` [PATCH v8 13/15] irqchip: mbigen: drop module owner Hanjun Guo
2017-01-18 12:55 ` [PATCH v8 14/15] irqchip: mbigen: introduce mbigen_of_create_domain() Hanjun Guo
2017-01-18 12:55 ` [PATCH v8 15/15] irqchip: mbigen: Add ACPI support Hanjun Guo
2017-02-03  2:27   ` Hanjun Guo
2017-02-03 14:50 ` [PATCH v8 00/15] ACPI platform MSI support and its example mbigen Sinan Kaya
2017-02-03 15:11   ` Marc Zyngier
2017-02-03 15:35     ` Sinan Kaya
2017-02-03 15:49       ` Marc Zyngier
2017-02-03 15:57         ` Sinan Kaya
2017-02-03 16:40           ` Lorenzo Pieralisi
2017-02-03 16:52             ` Sinan Kaya
2017-02-04  3:59   ` Hanjun Guo
2017-02-03 18:36 ` Lorenzo Pieralisi
2017-02-04  7:02   ` Hanjun Guo
2017-02-06 14:22     ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484744105-53140-4-git-send-email-guohanjun@huawei.com \
    --to=guohanjun@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).