linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: p.zabel@pengutronix.de (Philipp Zabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator
Date: Thu, 19 Jan 2017 15:41:17 +0100	[thread overview]
Message-ID: <1484836877.2989.21.camel@pengutronix.de> (raw)
In-Reply-To: <20170119142134.8572-1-l.stach@pengutronix.de>

On Thu, 2017-01-19 at 15:21 +0100, Lucas Stach wrote:
> The regulation bound of this regulator are 2.1V to 2.875V, the
> wrong DT values cause the driver to miscalculate the effective
> voltage.

As easily checked with

  $ grep vdd2p5 /sys/kernel/debug/regulator/regulator_summary
-  vdd2p5                           0    0      0  2400mV     0mA  2000mV  2750mV 
+  vdd2p5                           0    0      0  2500mV     0mA  2000mV  2750mV 

> This isn't really an issue right now, as nobody actively changes
> the regulator voltage, but better fix it now.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> index 53e6e63cbb02..9313b9af2da8 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -661,8 +661,8 @@
>  					anatop-vol-bit-shift = <8>;
>  					anatop-vol-bit-width = <5>;
>  					anatop-min-bit-val = <0>;
> -					anatop-min-voltage = <2000000>;
> -					anatop-max-voltage = <2750000>;
> +					anatop-min-voltage = <2100000>;
> +					anatop-max-voltage = <2875000>;
>  				};
>  
>  				reg_arm: regulator-vddcore {

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

  parent reply	other threads:[~2017-01-19 14:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19 14:21 [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator Lucas Stach
2017-01-19 14:21 ` [PATCH 2/2] ARM: imx6: fix regulator constraints on anatop 1p1 and 2p5 Lucas Stach
2017-01-19 14:42   ` Philipp Zabel
2017-01-19 14:41 ` Philipp Zabel [this message]
2017-01-24  6:43 ` [PATCH 1/2] ARM: imx6: fix min/max voltage of anatop 2p5 regulator Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484836877.2989.21.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).