From: eric.auger@redhat.com (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 17/18] vfio/type1: Check MSI remapping at irq domain level
Date: Thu, 19 Jan 2017 20:58:02 +0000 [thread overview]
Message-ID: <1484859483-2866-18-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1484859483-2866-1-git-send-email-eric.auger@redhat.com>
In case the IOMMU translates MSI transactions (typical case
on ARM), we check MSI remapping capability at IRQ domain
level. Otherwise it is checked at IOMMU level.
At this stage the arm-smmu-(v3) still advertise the
IOMMU_CAP_INTR_REMAP capability at IOMMU level. This will be
removed in subsequent patches.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Acked-by: Alex Williamson <alex.williamson@redhat.com>
Reviewed-by: Tomasz Nowicki <tomasz.nowicki@caviumnetworks.com>
Tested-by: Tomasz Nowicki <tomasz.nowicki@caviumnetworks.com>
Tested-by: Bharat Bhushan <bharat.bhushan@nxp.com>
---
v6: rewrite test
---
drivers/vfio/vfio_iommu_type1.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index 8deca9b..0f353f5 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -39,6 +39,7 @@
#include <linux/mdev.h>
#include <linux/notifier.h>
#include <linux/dma-iommu.h>
+#include <linux/irqdomain.h>
#define DRIVER_VERSION "0.2"
#define DRIVER_AUTHOR "Alex Williamson <alex.williamson@redhat.com>"
@@ -1210,7 +1211,7 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
struct vfio_domain *domain, *d;
struct bus_type *bus = NULL, *mdev_bus;
int ret;
- bool resv_msi;
+ bool resv_msi, msi_remap;
phys_addr_t resv_msi_base;
mutex_lock(&iommu->lock);
@@ -1286,8 +1287,10 @@ static int vfio_iommu_type1_attach_group(void *iommu_data,
INIT_LIST_HEAD(&domain->group_list);
list_add(&group->next, &domain->group_list);
- if (!allow_unsafe_interrupts &&
- !iommu_capable(bus, IOMMU_CAP_INTR_REMAP)) {
+ msi_remap = resv_msi ? irq_domain_check_msi_remap() :
+ iommu_capable(bus, IOMMU_CAP_INTR_REMAP);
+
+ if (!allow_unsafe_interrupts && !msi_remap) {
pr_warn("%s: No interrupt remapping support. Use the module param \"allow_unsafe_interrupts\" to enable VFIO IOMMU support on this platform\n",
__func__);
ret = -EPERM;
--
1.9.1
next prev parent reply other threads:[~2017-01-19 20:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 20:57 [PATCH v9 00/18] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Eric Auger
2017-01-19 20:57 ` [PATCH v9 01/18] iommu/dma: Allow MSI-only cookies Eric Auger
2017-01-19 20:57 ` [PATCH v9 02/18] iommu: Rename iommu_dm_regions into iommu_resv_regions Eric Auger
2017-01-19 20:57 ` [PATCH v9 03/18] iommu: Add a new type field in iommu_resv_region Eric Auger
2017-01-19 20:57 ` [PATCH v9 04/18] iommu: iommu_alloc_resv_region Eric Auger
2017-01-19 20:57 ` [PATCH v9 05/18] iommu: Only map direct mapped regions Eric Auger
2017-01-19 20:57 ` [PATCH v9 06/18] iommu: iommu_get_group_resv_regions Eric Auger
2017-01-19 20:57 ` [PATCH v9 07/18] iommu: Implement reserved_regions iommu-group sysfs file Eric Auger
2017-01-19 20:57 ` [PATCH v9 08/18] iommu/vt-d: Implement reserved region get/put callbacks Eric Auger
2017-01-23 11:46 ` Will Deacon
2017-01-23 11:57 ` Auger Eric
2017-01-19 20:57 ` [PATCH v9 09/18] iommu/amd: Declare MSI and HT regions as reserved IOVA regions Eric Auger
2017-01-19 20:57 ` [PATCH v9 10/18] iommu/arm-smmu: Implement reserved region get/put callbacks Eric Auger
2017-01-23 11:44 ` Will Deacon
2017-01-19 20:57 ` [PATCH v9 11/18] iommu/arm-smmu-v3: " Eric Auger
2017-01-19 20:57 ` [PATCH v9 12/18] irqdomain: Add irq domain MSI and MSI_REMAP flags Eric Auger
2017-01-19 20:57 ` [PATCH v9 13/18] genirq/msi: Set IRQ_DOMAIN_FLAG_MSI on MSI domain creation Eric Auger
2017-01-19 20:57 ` [PATCH v9 14/18] irqdomain: irq_domain_check_msi_remap Eric Auger
2017-01-19 20:58 ` [PATCH v9 15/18] irqchip/gicv3-its: Sets IRQ_DOMAIN_FLAG_MSI_REMAP Eric Auger
2017-01-19 20:58 ` [PATCH v9 16/18] vfio/type1: Allow transparent MSI IOVA allocation Eric Auger
2017-01-19 20:58 ` Eric Auger [this message]
2017-01-19 20:58 ` [PATCH v9 18/18] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP anymore Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484859483-2866-18-git-send-email-eric.auger@redhat.com \
--to=eric.auger@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).