From: magnus.damm@gmail.com (Magnus Damm)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC 1/2] arm64: mm: Silently allow devices lacking IOMMU group
Date: Mon, 23 Jan 2017 21:12:16 +0900 [thread overview]
Message-ID: <148517353630.18128.12799811817831597628.sendpatchset@little-apple> (raw)
In-Reply-To: <148517349585.18128.10696161017872202809.sendpatchset@little-apple>
From: Magnus Damm <damm+renesas@opensource.se>
Consider failure of iommu_get_domain_for_dev() as non-critical and
get rid of the warning printout. This allows IOMMU properties to be
included in the DTB even though the kernel is configured with
CONFIG_IOMMU_API=n or in case a particular IOMMU driver refuses to
enable IOMMU support for a certain slave device and returns error
from the ->add_device() callback.
This is only a cosmetic change that removes console warning printouts.
Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---
arch/arm64/mm/dma-mapping.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
--- 0001/arch/arm64/mm/dma-mapping.c
+++ work/arch/arm64/mm/dma-mapping.c 2017-01-23 20:54:40.060607110 +0900
@@ -827,11 +827,19 @@ static bool do_iommu_attach(struct devic
struct iommu_domain *domain = iommu_get_domain_for_dev(dev);
/*
+ * In case IOMMU support is excluded from the kernel or if the device
+ * is not hooked up to any IOMMU group then be silent and keep the
+ * old dma_ops.
+ */
+ if (!domain)
+ return false;
+
+ /*
* If the IOMMU driver has the DMA domain support that we require,
* then the IOMMU core will have already configured a group for this
* device, and allocated the default domain for that group.
*/
- if (!domain || iommu_dma_init_domain(domain, dma_base, size, dev)) {
+ if (iommu_dma_init_domain(domain, dma_base, size, dev)) {
pr_warn("Failed to set up IOMMU for device %s; retaining platform DMA ops\n",
dev_name(dev));
return false;
next prev parent reply other threads:[~2017-01-23 12:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 12:11 [PATCH/RFC 0/2] iommu/ipmmu-vmsa: IPMMU slave device whitelist Magnus Damm
2017-01-23 12:12 ` Magnus Damm [this message]
2017-01-23 12:34 ` [PATCH/RFC 1/2] arm64: mm: Silently allow devices lacking IOMMU group Robin Murphy
2017-01-24 8:19 ` Sricharan
2017-01-25 10:02 ` Magnus Damm
2017-01-23 12:12 ` [PATCH/RFC 2/2] iommu/ipmmu-vmsa: Opt-in slave devices based on ES version Magnus Damm
2017-01-23 12:50 ` Geert Uytterhoeven
2017-01-24 9:38 ` Magnus Damm
2017-01-24 10:32 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=148517353630.18128.12799811817831597628.sendpatchset@little-apple \
--to=magnus.damm@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox