From: jbrunet@baylibre.com (Jerome Brunet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: meson8b: fix clk81 register address
Date: Thu, 26 Jan 2017 15:27:01 +0100 [thread overview]
Message-ID: <1485440821.2442.8.camel@baylibre.com> (raw)
In-Reply-To: <1485341586-2929-1-git-send-email-jbrunet@baylibre.com>
On Wed, 2017-01-25 at 11:53 +0100, Jerome Brunet wrote:
> During meson8b clock probe, clk81 register address is fixed twice.
> First using the meson8b_clk_gates array, then by directly changing
> meson8b_clk81 register.
>
> As a result meson8b_clk81.reg = HHI_MPEG_CLK_CNTL + clk_base +
> clk_base.
>
> Fixed by just removing the second fixup.
>
> Fixes: e31a1900c1ff ("meson: clk: Add support for clock gates")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> ?Patch based on khilman/linux-amlogic.git master branch.
>
> ?I don't have a meson8b HW so this patch so this patch has not been
> ?tested on real HW.
I got my hands on an odroidc1 and I have been to test this.
With clk_base @ 0xf0965000:
* without the patch:
clk81.reg =?0xe12ca174
* with the patch:
clk81.reg = 0xf0965174 (expected result)
In the past, we probably did not see this because clk81 is the mother
of all the other clock gate around the SoC so it is very likely that u-
boot opened this gate for us.
>
> ?drivers/clk/meson/meson8b.c | 1 -
> ?1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/meson/meson8b.c
> b/drivers/clk/meson/meson8b.c
> index 3f1be46cbb33..888494d4fb8a 100644
> --- a/drivers/clk/meson/meson8b.c
> +++ b/drivers/clk/meson/meson8b.c
> @@ -607,7 +607,6 @@ static int meson8b_clkc_probe(struct
> platform_device *pdev)
> ? /* Populate the base address for the MPEG clks */
> ? meson8b_mpeg_clk_sel.reg = clk_base +
> (u32)meson8b_mpeg_clk_sel.reg;
> ? meson8b_mpeg_clk_div.reg = clk_base +
> (u32)meson8b_mpeg_clk_div.reg;
> - meson8b_clk81.reg = clk_base + (u32)meson8b_clk81.reg;
> ?
> ? /* Populate base address for gates */
> ? for (i = 0; i < ARRAY_SIZE(meson8b_clk_gates); i++)
next prev parent reply other threads:[~2017-01-26 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 10:53 [PATCH] clk: meson8b: fix clk81 register address Jerome Brunet
2017-01-26 14:27 ` Jerome Brunet [this message]
2017-01-26 23:57 ` Stephen Boyd
2017-01-27 8:43 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485440821.2442.8.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).