linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] i.MX: GPC: Use IRQCHIP_DECLARE_DRIVER
Date: Fri, 27 Jan 2017 10:54:00 +0100	[thread overview]
Message-ID: <1485510840.28751.26.camel@pengutronix.de> (raw)
In-Reply-To: <20170126220504.4796-3-andrew.smirnov@gmail.com>

Hi Andrey,

Am Donnerstag, den 26.01.2017, 14:05 -0800 schrieb Andrey Smirnov:
> Use IRQCHIP_DECLARE_DRIVER instead of Use IRQCHIP_DECLARE to allow
> 'imx_gpc_driver' to be probed in addition to irqchip initialized by
> imx_gpc_init().
> 
> Cc: yurovsky at gmail.com
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>  arch/arm/mach-imx/gpc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c
> index 1dc2a34..8f0d19b 100644
> --- a/arch/arm/mach-imx/gpc.c
> +++ b/arch/arm/mach-imx/gpc.c
> @@ -279,7 +279,7 @@ static int __init imx_gpc_init(struct device_node *node,
>  
>  	return 0;
>  }
> -IRQCHIP_DECLARE(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init);
> +IRQCHIP_DECLARE_DRIVER(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init);
>  
>  void __init imx_gpc_check_dt(void)
>  {

I don't see the other patches from the series on the list, so commenting
here: You might want to take a look at my GPC rework series, it has a
much nicer binding for the power domains, that you might want to use for
the GPCv2 also.

Additionally I think the power domain stuff doesn't belong into the
irqchip driver, but rather in a separate driver in drivers/soc like it
is done in my series.

I'll send out an updated version of this series today and you might
consider basing your GPCv2 on top of that.

Regards,
Lucas

  reply	other threads:[~2017-01-27  9:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170126220504.4796-1-andrew.smirnov@gmail.com>
2017-01-26 22:05 ` [PATCH 3/4] i.MX: GPC: Use IRQCHIP_DECLARE_DRIVER Andrey Smirnov
2017-01-27  9:54   ` Lucas Stach [this message]
2017-01-27 18:16     ` Andrey Smirnov
     [not found] <20170126215609.4272-1-andrew.smirnov@gmail.com>
2017-01-26 21:56 ` Andrey Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485510840.28751.26.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).