* [PATCH 0/2] media: dt-bindings: extend the vpif bindings @ 2017-02-16 18:03 Bartosz Golaszewski 2017-02-16 18:03 ` [PATCH 1/2] media: dt-bindings: vpif: fix whitespace errors Bartosz Golaszewski 2017-02-16 18:03 ` [PATCH 2/2] media: dt-bindings: vpif: extend the example with an output port Bartosz Golaszewski 0 siblings, 2 replies; 5+ messages in thread From: Bartosz Golaszewski @ 2017-02-16 18:03 UTC (permalink / raw) To: linux-arm-kernel The first patch just fixes a couple whitespace errors in the vpif bindings. The second extends the example with an output port since we want to support vpif display too. These patches were initially a part of a larger series. Resending separately with requested fixes i.e. removed the @0 from endpoint and unnecessary reg property. Bartosz Golaszewski (2): media: dt-bindings: vpif: fix whitespace errors media: dt-bindings: vpif: extend the example with an output port .../devicetree/bindings/media/ti,da850-vpif.txt | 46 ++++++++++++++++------ 1 file changed, 34 insertions(+), 12 deletions(-) -- 2.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] media: dt-bindings: vpif: fix whitespace errors 2017-02-16 18:03 [PATCH 0/2] media: dt-bindings: extend the vpif bindings Bartosz Golaszewski @ 2017-02-16 18:03 ` Bartosz Golaszewski 2017-02-16 18:03 ` [PATCH 2/2] media: dt-bindings: vpif: extend the example with an output port Bartosz Golaszewski 1 sibling, 0 replies; 5+ messages in thread From: Bartosz Golaszewski @ 2017-02-16 18:03 UTC (permalink / raw) To: linux-arm-kernel The examples have been copied from the DT with whitespace errors. Fix them. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> Acked-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/media/ti,da850-vpif.txt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt index 6d25d7f..9c7510b 100644 --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt @@ -30,15 +30,15 @@ I2C-connected TVP5147 decoder: port { vpif_ch0: endpoint at 0 { - reg = <0>; - bus-width = <8>; - remote-endpoint = <&composite>; + reg = <0>; + bus-width = <8>; + remote-endpoint = <&composite>; }; vpif_ch1: endpoint at 1 { - reg = <1>; - bus-width = <8>; - data-shift = <8>; + reg = <1>; + bus-width = <8>; + data-shift = <8>; }; }; }; -- 2.9.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] media: dt-bindings: vpif: extend the example with an output port 2017-02-16 18:03 [PATCH 0/2] media: dt-bindings: extend the vpif bindings Bartosz Golaszewski 2017-02-16 18:03 ` [PATCH 1/2] media: dt-bindings: vpif: fix whitespace errors Bartosz Golaszewski @ 2017-02-16 18:03 ` Bartosz Golaszewski 2017-02-21 14:57 ` Rob Herring 1 sibling, 1 reply; 5+ messages in thread From: Bartosz Golaszewski @ 2017-02-16 18:03 UTC (permalink / raw) To: linux-arm-kernel This makes the example more or less correspond with the da850-evm hardware setup. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- .../devicetree/bindings/media/ti,da850-vpif.txt | 36 +++++++++++++++++----- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt index 9c7510b..d6f93a1 100644 --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt @@ -16,7 +16,7 @@ Required properties: Video Capture: VPIF has a 16-bit parallel bus input, supporting 2 8-bit channels or a -single 16-bit channel. It should contain at least one port child node +single 16-bit channel. It should contain one or two port child nodes with child 'endpoint' node. Please refer to the bindings defined in Documentation/devicetree/bindings/media/video-interfaces.txt. @@ -28,19 +28,26 @@ I2C-connected TVP5147 decoder: reg = <0x217000 0x1000>; interrupts = <92>; - port { - vpif_ch0: endpoint at 0 { + port at 0 { + vpif_input_ch0: endpoint at 0 { reg = <0>; bus-width = <8>; - remote-endpoint = <&composite>; + remote-endpoint = <&composite_in>; }; - vpif_ch1: endpoint at 1 { + vpif_input_ch1: endpoint at 1 { reg = <1>; bus-width = <8>; data-shift = <8>; }; }; + + port at 1 { + vpif_output_ch0: endpoint { + bus-width = <8>; + remote-endpoint = <&composite_out>; + }; + }; }; [ ... ] @@ -53,13 +60,28 @@ I2C-connected TVP5147 decoder: status = "okay"; port { - composite: endpoint { + composite_in: endpoint { hsync-active = <1>; vsync-active = <1>; pclk-sample = <0>; /* VPIF channel 0 (lower 8-bits) */ - remote-endpoint = <&vpif_ch0>; + remote-endpoint = <&vpif_input_ch0>; + bus-width = <8>; + }; + }; + }; + + adv7343 at 2a { + compatible = "adi,adv7343"; + reg = <0x2a>; + + port { + composite_out: endpoint { + adi,dac-enable = <1 1 1>; + adi,sd-dac-enable = <1>; + + remote-endpoint = <&vpif_output_ch0>; bus-width = <8>; }; }; -- 2.9.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] media: dt-bindings: vpif: extend the example with an output port 2017-02-16 18:03 ` [PATCH 2/2] media: dt-bindings: vpif: extend the example with an output port Bartosz Golaszewski @ 2017-02-21 14:57 ` Rob Herring 2017-02-21 15:07 ` Bartosz Golaszewski 0 siblings, 1 reply; 5+ messages in thread From: Rob Herring @ 2017-02-21 14:57 UTC (permalink / raw) To: linux-arm-kernel On Thu, Feb 16, 2017 at 12:03 PM, Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote: > This makes the example more or less correspond with the da850-evm > hardware setup. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > .../devicetree/bindings/media/ti,da850-vpif.txt | 36 +++++++++++++++++----- > 1 file changed, 29 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt > index 9c7510b..d6f93a1 100644 > --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt > +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt > @@ -16,7 +16,7 @@ Required properties: > Video Capture: > > VPIF has a 16-bit parallel bus input, supporting 2 8-bit channels or a > -single 16-bit channel. It should contain at least one port child node > +single 16-bit channel. It should contain one or two port child nodes When do you not have an output? Seems kind of useless. I'm guessing this is an oversight in the binding and there should always be port 1 and a connector node, so document it that way. This also needs to state what port 0 and port 1 are (i.e. input or output and type of data). > with child 'endpoint' node. Please refer to the bindings defined in > Documentation/devicetree/bindings/media/video-interfaces.txt. > > @@ -28,19 +28,26 @@ I2C-connected TVP5147 decoder: > reg = <0x217000 0x1000>; > interrupts = <92>; > > - port { > - vpif_ch0: endpoint at 0 { > + port at 0 { > + vpif_input_ch0: endpoint at 0 { > reg = <0>; > bus-width = <8>; > - remote-endpoint = <&composite>; > + remote-endpoint = <&composite_in>; > }; > > - vpif_ch1: endpoint at 1 { > + vpif_input_ch1: endpoint at 1 { > reg = <1>; > bus-width = <8>; > data-shift = <8>; > }; > }; > + > + port at 1 { > + vpif_output_ch0: endpoint { > + bus-width = <8>; Isn't this an analog input? bus-width doesn't make sense for that. Rob ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] media: dt-bindings: vpif: extend the example with an output port 2017-02-21 14:57 ` Rob Herring @ 2017-02-21 15:07 ` Bartosz Golaszewski 0 siblings, 0 replies; 5+ messages in thread From: Bartosz Golaszewski @ 2017-02-21 15:07 UTC (permalink / raw) To: linux-arm-kernel 2017-02-21 15:57 GMT+01:00 Rob Herring <robh+dt@kernel.org>: > On Thu, Feb 16, 2017 at 12:03 PM, Bartosz Golaszewski > <bgolaszewski@baylibre.com> wrote: >> This makes the example more or less correspond with the da850-evm >> hardware setup. >> >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> >> --- >> .../devicetree/bindings/media/ti,da850-vpif.txt | 36 +++++++++++++++++----- >> 1 file changed, 29 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >> index 9c7510b..d6f93a1 100644 >> --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt >> @@ -16,7 +16,7 @@ Required properties: >> Video Capture: >> >> VPIF has a 16-bit parallel bus input, supporting 2 8-bit channels or a >> -single 16-bit channel. It should contain at least one port child node >> +single 16-bit channel. It should contain one or two port child nodes > > When do you not have an output? Seems kind of useless. I'm guessing > this is an oversight in the binding and there should always be port 1 > and a connector node, so document it that way. > Sometimes the output pins are not hooked up to anything - for example on the da850-lcdk board we only use input for camera capture, while on da850-evm we have both composite and s-video outputs and inputs. I think it makes sens to leave out the output port if we don't use it. > This also needs to state what port 0 and port 1 are (i.e. input or > output and type of data). > I'll fix that. >> with child 'endpoint' node. Please refer to the bindings defined in >> Documentation/devicetree/bindings/media/video-interfaces.txt. >> >> @@ -28,19 +28,26 @@ I2C-connected TVP5147 decoder: >> reg = <0x217000 0x1000>; >> interrupts = <92>; >> >> - port { >> - vpif_ch0: endpoint at 0 { >> + port at 0 { >> + vpif_input_ch0: endpoint at 0 { >> reg = <0>; >> bus-width = <8>; >> - remote-endpoint = <&composite>; >> + remote-endpoint = <&composite_in>; >> }; >> >> - vpif_ch1: endpoint at 1 { >> + vpif_input_ch1: endpoint at 1 { >> reg = <1>; >> bus-width = <8>; >> data-shift = <8>; >> }; >> }; >> + >> + port at 1 { >> + vpif_output_ch0: endpoint { >> + bus-width = <8>; > > Isn't this an analog input? bus-width doesn't make sense for that. > Not yet - the signals first go to a video DAC (adv7343 in the example). Thanks, Bartosz ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-21 15:07 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-02-16 18:03 [PATCH 0/2] media: dt-bindings: extend the vpif bindings Bartosz Golaszewski 2017-02-16 18:03 ` [PATCH 1/2] media: dt-bindings: vpif: fix whitespace errors Bartosz Golaszewski 2017-02-16 18:03 ` [PATCH 2/2] media: dt-bindings: vpif: extend the example with an output port Bartosz Golaszewski 2017-02-21 14:57 ` Rob Herring 2017-02-21 15:07 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).