* [PATCH] hwtracing: coresight: Fixes coresight DT parse to get correct output port ID.
@ 2017-02-17 19:10 Mike Leach
2017-02-20 18:46 ` Mathieu Poirier
0 siblings, 1 reply; 2+ messages in thread
From: Mike Leach @ 2017-02-17 19:10 UTC (permalink / raw)
To: linux-arm-kernel
Corrected to get the port numbering to allow programmable replicator driver
to operate correctly.
By convention, CoreSight devices number ports, not endpoints in
the .dts files:-
port {
reg<N>
endpoint {
}
}
Existing code read endpoint number - always 0x0, rather than the correct
port number.
Signed-off-by: Mike Leach <mike.leach@linaro.org>
---
drivers/hwtracing/coresight/of_coresight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c
index 629e031..09142e9 100644
--- a/drivers/hwtracing/coresight/of_coresight.c
+++ b/drivers/hwtracing/coresight/of_coresight.c
@@ -149,7 +149,7 @@ struct coresight_platform_data *of_get_coresight_platform_data(
continue;
/* The local out port number */
- pdata->outports[i] = endpoint.id;
+ pdata->outports[i] = endpoint.port;
/*
* Get a handle on the remote port and parent
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] hwtracing: coresight: Fixes coresight DT parse to get correct output port ID.
2017-02-17 19:10 [PATCH] hwtracing: coresight: Fixes coresight DT parse to get correct output port ID Mike Leach
@ 2017-02-20 18:46 ` Mathieu Poirier
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2017-02-20 18:46 UTC (permalink / raw)
To: linux-arm-kernel
On 17 February 2017 at 12:10, Mike Leach <mike.leach@linaro.org> wrote:
> Corrected to get the port numbering to allow programmable replicator driver
> to operate correctly.
>
> By convention, CoreSight devices number ports, not endpoints in
> the .dts files:-
>
> port {
> reg<N>
> endpoint {
> }
> }
>
> Existing code read endpoint number - always 0x0, rather than the correct
> port number.
>
> Signed-off-by: Mike Leach <mike.leach@linaro.org>
> ---
> drivers/hwtracing/coresight/of_coresight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c
> index 629e031..09142e9 100644
> --- a/drivers/hwtracing/coresight/of_coresight.c
> +++ b/drivers/hwtracing/coresight/of_coresight.c
> @@ -149,7 +149,7 @@ struct coresight_platform_data *of_get_coresight_platform_data(
> continue;
>
> /* The local out port number */
> - pdata->outports[i] = endpoint.id;
> + pdata->outports[i] = endpoint.port;
>
> /*
> * Get a handle on the remote port and parent
> --
> 2.7.4
>
Applied - thanks
Mathieu.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-20 18:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-17 19:10 [PATCH] hwtracing: coresight: Fixes coresight DT parse to get correct output port ID Mike Leach
2017-02-20 18:46 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).