From: ben@decadent.org.uk (Ben Hutchings)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419
Date: Mon, 20 Feb 2017 17:22:38 +0000 [thread overview]
Message-ID: <1487611358.2885.3.camel@decadent.org.uk> (raw)
In-Reply-To: <20170220175049.45f319bb@free-electrons.com>
On Mon, 2017-02-20 at 17:50 +0100, Thomas Petazzoni wrote:
> Hello,
>
> On Mon, 20 Feb 2017 16:40:25 +0000, Ben Hutchings wrote:
>
> > That is precisely what I intended.??20-23 are used by the second
> > Ethernet port.??The old board code doesn't assign 4 or 5 at all.
>
> Then I believe it would be more explicit to have separate pin muxing
> configurations for SATA on this board.
You mean, define additional pinmux nodes and override the pinctrl-0
property of &sata? More like this:
--- a/arch/arm/boot/dts/kirkwood-ts419.dtsi
+++ b/arch/arm/boot/dts/kirkwood-ts419.dtsi
@@ -73,3 +73,19 @@
phy-handle = <ðphy1>;
};
};
+
+&pinctrl {
+ pmx_sata0_ts419: pmx-sata0-ts419 {
+ marvell,pins = "mpp15";
+ marvell,function = "sata0";
+ };
+
+ pmx_sata1_ts419: pmx-sata1-ts419 {
+ marvell,pins = "mpp16";
+ marvell,function = "sata1";
+ };
+};
+
+&sata {
+ pinctrl-0 = <&pmx_sata0_ts419 &pmx_sata1_ts419>;
+};
--- END ---
Ben.
--
Ben Hutchings
If at first you don't succeed, you're doing about average.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170220/f795a5b5/attachment-0001.sig>
next prev parent reply other threads:[~2017-02-20 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 0:32 [PATCH] ARM: dts: kirkwood: Fix SATA pinmux-ing for TS419 Ben Hutchings
2017-02-20 12:59 ` Thomas Petazzoni
2017-02-20 16:40 ` Ben Hutchings
2017-02-20 16:50 ` Thomas Petazzoni
2017-02-20 17:22 ` Ben Hutchings [this message]
2017-02-20 20:31 ` Thomas Petazzoni
2017-03-07 17:16 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487611358.2885.3.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox