From: leo.yan@linaro.org (Leo Yan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] coresight: refactor with function of_coresight_get_cpu
Date: Fri, 3 Mar 2017 14:00:06 +0800 [thread overview]
Message-ID: <1488520809-31670-3-git-send-email-leo.yan@linaro.org> (raw)
In-Reply-To: <1488520809-31670-1-git-send-email-leo.yan@linaro.org>
This is refactor to add function of_coresight_get_cpu(), so it's used to
retrieve CPU id for coresight component. Finally can use it as a common
function for multiple places.
Suggested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
drivers/hwtracing/coresight/of_coresight.c | 37 ++++++++++++++++++++----------
include/linux/coresight.h | 2 ++
2 files changed, 27 insertions(+), 12 deletions(-)
diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c
index 629e031..d9a12fb 100644
--- a/drivers/hwtracing/coresight/of_coresight.c
+++ b/drivers/hwtracing/coresight/of_coresight.c
@@ -101,14 +101,36 @@ static int of_coresight_alloc_memory(struct device *dev,
return 0;
}
+int of_coresight_get_cpu(struct device_node *node)
+{
+ int cpu;
+ struct device_node *dn;
+
+ dn = of_parse_phandle(node, "cpu", 0);
+
+ /* Affinity defaults to CPU0 */
+ if (!dn)
+ return 0;
+
+ for_each_possible_cpu(cpu) {
+ if (dn == of_get_cpu_node(cpu, NULL)) {
+ of_node_put(dn);
+ return cpu;
+ }
+ }
+
+ /* Affinity to CPU0 if no cpu nodes are found */
+ of_node_put(dn);
+ return 0;
+}
+
struct coresight_platform_data *of_get_coresight_platform_data(
struct device *dev, struct device_node *node)
{
- int i = 0, ret = 0, cpu;
+ int i = 0, ret = 0;
struct coresight_platform_data *pdata;
struct of_endpoint endpoint, rendpoint;
struct device *rdev;
- struct device_node *dn;
struct device_node *ep = NULL;
struct device_node *rparent = NULL;
struct device_node *rport = NULL;
@@ -175,16 +197,7 @@ struct coresight_platform_data *of_get_coresight_platform_data(
} while (ep);
}
- /* Affinity defaults to CPU0 */
- pdata->cpu = 0;
- dn = of_parse_phandle(node, "cpu", 0);
- for (cpu = 0; dn && cpu < nr_cpu_ids; cpu++) {
- if (dn == of_get_cpu_node(cpu, NULL)) {
- pdata->cpu = cpu;
- break;
- }
- }
- of_node_put(dn);
+ pdata->cpu = of_coresight_get_cpu(node);
return pdata;
}
diff --git a/include/linux/coresight.h b/include/linux/coresight.h
index 2a5982c..7b29743 100644
--- a/include/linux/coresight.h
+++ b/include/linux/coresight.h
@@ -263,9 +263,11 @@ static inline int coresight_timeout(void __iomem *addr, u32 offset,
#endif
#ifdef CONFIG_OF
+extern int of_coresight_get_cpu(struct device_node *node);
extern struct coresight_platform_data *of_get_coresight_platform_data(
struct device *dev, struct device_node *node);
#else
+static int of_coresight_get_cpu(struct device_node *node) { return 0; }
static inline struct coresight_platform_data *of_get_coresight_platform_data(
struct device *dev, struct device_node *node) { return NULL; }
#endif
--
2.7.4
next prev parent reply other threads:[~2017-03-03 6:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 6:00 [PATCH v3 0/5] coresight: enable debug module Leo Yan
2017-03-03 6:00 ` [PATCH v3 1/5] coresight: bindings for " Leo Yan
2017-03-09 13:27 ` [v3 " Suzuki K Poulose
2017-03-03 6:00 ` Leo Yan [this message]
2017-03-03 6:00 ` [PATCH v3 3/5] coresight: add support " Leo Yan
2017-03-09 16:53 ` [v3 " Suzuki K Poulose
2017-03-09 17:59 ` Leo Yan
2017-03-10 14:29 ` Suzuki K Poulose
2017-03-13 8:12 ` Leo Yan
2017-03-13 16:56 ` Mathieu Poirier
2017-03-15 16:44 ` Suzuki K Poulose
2017-03-15 20:41 ` Mathieu Poirier
2017-03-17 10:13 ` Leo Yan
2017-03-17 15:50 ` Mathieu Poirier
2017-03-17 16:28 ` Leo Yan
2017-03-17 16:47 ` Suzuki K Poulose
2017-03-20 12:30 ` Leo Yan
2017-03-20 16:40 ` Mathieu Poirier
2017-03-21 2:59 ` Leo Yan
2017-03-21 10:16 ` Suzuki K Poulose
2017-03-21 11:47 ` Leo Yan
2017-03-21 15:15 ` Mathieu Poirier
2017-03-13 16:29 ` Mathieu Poirier
2017-03-21 15:39 ` [PATCH v3 " Sudeep Holla
[not found] ` <CAJ9a7VgCjXNGC4C49PxL-nBxzhMCmA8Mb-0C_epahizA5EL2HA@mail.gmail.com>
2017-03-22 14:07 ` Sudeep Holla
2017-03-22 15:45 ` Mike Leach
2017-03-22 16:17 ` Sudeep Holla
2017-03-22 17:09 ` Suzuki K Poulose
2017-03-22 17:25 ` Sudeep Holla
2017-03-23 5:43 ` Leo Yan
2017-03-23 12:27 ` Mike Leach
2017-03-22 16:01 ` Leo Yan
2017-03-22 16:53 ` Sudeep Holla
2017-03-03 6:00 ` [PATCH v3 4/5] clk: hi6220: add debug APB clock Leo Yan
2017-03-03 23:58 ` Stephen Boyd
2017-03-17 15:22 ` Leo Yan
2017-03-03 6:00 ` [PATCH v3 5/5] arm64: dts: hi6220: register debug module Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488520809-31670-3-git-send-email-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).