From: rick.chang@mediatek.com (Rick Chang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [media] vcodev: mediatek: add missing include in JPEG decoder driver
Date: Mon, 13 Mar 2017 11:04:54 +0800 [thread overview]
Message-ID: <1489374294.19716.1.camel@mtksdaap41> (raw)
In-Reply-To: <20170312201329.28357-1-jeremy.lefaure@lse.epita.fr>
On Sun, 2017-03-12 at 16:13 -0400, J?r?my Lefaure wrote:
> The driver uses kzalloc and kfree functions. So it should include
> linux/slab.h. This header file is implicitly included by v4l2-common.h
> if CONFIG_SPI is enabled. But when it is disabled, slab.h is not
> included. In this case, the driver does not compile:
>
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ?mtk_jpeg_open?:
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:8: error: implicit
> declaration of function ?kzalloc?
> [-Werror=implicit-function-declaration]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^~~~~~~
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:6: warning:
> assignment makes pointer from integer without a cast [-Wint-conversion]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1047:2: error: implicit
> declaration of function ?kfree? [-Werror=implicit-function-declaration]
> kfree(ctx);
> ^~~~~
>
> This patch adds the missing include to fix this issue.
>
> Signed-off-by: J?r?my Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Rick Chang <rick.chang@mediatek.com>
next prev parent reply other threads:[~2017-03-13 3:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 20:13 [PATCH] [media] vcodev: mediatek: add missing include in JPEG decoder driver Jérémy Lefaure
2017-03-13 3:04 ` Rick Chang [this message]
2017-03-13 10:17 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1489374294.19716.1.camel@mtksdaap41 \
--to=rick.chang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).