linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: labbott@redhat.com (Laura Abbott)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCHv2 14/21] staging: android: ion: Stop butchering the DMA address
Date: Fri, 17 Mar 2017 17:54:46 -0700	[thread overview]
Message-ID: <1489798493-16600-15-git-send-email-labbott@redhat.com> (raw)
In-Reply-To: <1489798493-16600-1-git-send-email-labbott@redhat.com>


Now that we have proper caching, stop setting the DMA address manually.
It should be set after properly calling dma_map.

Signed-off-by: Laura Abbott <labbott@redhat.com>
---
 drivers/staging/android/ion/ion.c | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 3d979ef5..65638f5 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -81,8 +81,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
 {
 	struct ion_buffer *buffer;
 	struct sg_table *table;
-	struct scatterlist *sg;
-	int i, ret;
+	int ret;
 
 	buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
 	if (!buffer)
@@ -119,20 +118,6 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
 	INIT_LIST_HEAD(&buffer->vmas);
 	INIT_LIST_HEAD(&buffer->attachments);
 	mutex_init(&buffer->lock);
-	/*
-	 * this will set up dma addresses for the sglist -- it is not
-	 * technically correct as per the dma api -- a specific
-	 * device isn't really taking ownership here.  However, in practice on
-	 * our systems the only dma_address space is physical addresses.
-	 * Additionally, we can't afford the overhead of invalidating every
-	 * allocation via dma_map_sg. The implicit contract here is that
-	 * memory coming from the heaps is ready for dma, ie if it has a
-	 * cached mapping that mapping has been invalidated
-	 */
-	for_each_sg(buffer->sg_table->sgl, sg, buffer->sg_table->nents, i) {
-		sg_dma_address(sg) = sg_phys(sg);
-		sg_dma_len(sg) = sg->length;
-	}
 	mutex_lock(&dev->buffer_lock);
 	ion_buffer_add(dev, buffer);
 	mutex_unlock(&dev->buffer_lock);
-- 
2.7.4

  parent reply	other threads:[~2017-03-18  0:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-18  0:54 [RFC PATCHv2 00/21] Ion clean in preparation for moving out of staging Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 01/21] cma: Store a name in the cma structure Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 02/21] cma: Introduce cma_for_each_area Laura Abbott
2017-03-29  8:48   ` Benjamin Gaignard
2017-03-18  0:54 ` [RFC PATCHv2 03/21] staging: android: ion: Remove dmap_cnt Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 04/21] staging: android: ion: Remove alignment from allocation field Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 05/21] staging: android: ion: Duplicate sg_table Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 06/21] staging: android: ion: Call dma_map_sg for syncing and mapping Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 07/21] staging: android: ion: Remove page faulting support Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 08/21] staging: android: ion: Remove crufty cache support Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 09/21] staging: android: ion: Remove custom ioctl interface Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 10/21] staging: android: ion: Remove import interface Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 11/21] staging: android: ion: Remove duplicate ION_IOC_MAP Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 12/21] staging: android: ion: Remove old platform support Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 13/21] staging: android: ion: Use CMA APIs directly Laura Abbott
2017-03-18  0:54 ` Laura Abbott [this message]
2017-03-18  0:54 ` [RFC PATCHv2 15/21] staging: android: ion: Break the ABI in the name of forward progress Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 16/21] staging: android: ion: Get rid of ion_phys_addr_t Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 17/21] staging: android: ion: Collapse internal header files Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 18/21] staging: android: ion: Rework heap registration/enumeration Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 19/21] staging: android: ion: Drop ion_map_kernel interface Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 20/21] staging: android: ion: Remove ion_handle and ion_client Laura Abbott
2017-03-18  0:54 ` [RFC PATCHv2 21/21] staging: android: ion: Set query return value Laura Abbott
2017-03-29  9:03 ` [RFC PATCHv2 00/21] Ion clean in preparation for moving out of staging Benjamin Gaignard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489798493-16600-15-git-send-email-labbott@redhat.com \
    --to=labbott@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).